Page MenuHomeIn-Portal Phabricator
Differential D559

INP-1941 - Make the "secure" and "httponly" cookie flags configurable in the "Session::SetCookie" method
AcceptedPublic
Actions

Authored by alex on Fri, Feb 20, 4:44 AM.

Details

Reviewers
erik
Test Plan

Prerequisites

The cURL debugging must be disabled (the DBG_CURL constant in the /system/debug.php file.

Test Plan

  1. run the core/tests/Unit/kernel/session/sessionTest.php unit test
  2. confirm that it passes

Diff Detail

Repository
rINP In-Portal
Branch
branches/5.2.x
Lint
Lint ErrorsExcuse: Unrelated.
SeverityLocationCodeMessage
Errorcore/kernel/session/session.php:97PHPCS.E.CodingStandard.Classes.PropertyDeclaration.ScopeMissingCodingStandard.Classes.PropertyDeclaration.ScopeMissing
Errorcore/kernel/session/session.php:97PHPCS.E.CodingStandard.Classes.PropertyDeclaration.VarUsedCodingStandard.Classes.PropertyDeclaration.VarUsed
Errorcore/kernel/session/session.php:97PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.MemberNotCamelCapsCodingStandard.NamingConventions.ValidVariableName.MemberNotCamelCaps
Errorcore/kernel/session/session.php:97PHPCS.E.Squiz.Commenting.VariableComment.MissingSquiz.Commenting.VariableComment.Missing
Errorcore/kernel/session/session.php:97PHPCS.E.Squiz.WhiteSpace.MemberVarSpacing.IncorrectSquiz.WhiteSpace.MemberVarSpacing.Incorrect
Errorcore/kernel/session/session.php:98PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.MemberNotCamelCapsCodingStandard.NamingConventions.ValidVariableName.MemberNotCamelCaps
Errorcore/kernel/session/session.php:98PHPCS.E.Squiz.Commenting.VariableComment.MissingSquiz.Commenting.VariableComment.Missing
Errorcore/kernel/session/session.php:98PHPCS.E.Squiz.WhiteSpace.MemberVarSpacing.IncorrectSquiz.WhiteSpace.MemberVarSpacing.Incorrect
Errorcore/kernel/session/session.php:382PHPCS.E.CodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCapsCodingStandard.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Unit
Unit Tests OK
Build Status
Buildable 11199
Build 3899: arc lint + arc unit

Event Timeline

alex created this revision.Fri, Feb 20, 4:44 AM
alex requested review of this revision.Fri, Feb 20, 4:44 AM
alex updated this revision to Diff 1449.Fri, Feb 20, 11:01 AM

Improve fixture PHP script output.

erik accepted this revision.Tue, Feb 24, 12:01 PM

All tests passed, but only after line

define('DBG_CURL', 1);

was commented in the system/debug.php

This revision is now accepted and ready to land.Tue, Feb 24, 12:01 PM
alex edited the test plan for this revision. (Show Details)Wed, Feb 25, 1:31 AM
In D559#11488, @erik wrote:

All tests passed, but only after line

define('DBG_CURL', 1);

was commented in the system/debug.php

Thank you. I've updated the test plan.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1144816869Fri, Feb 20, 4:43 AM
★
★
Diff 2144916869Improve fixture PHP script output.Fri, Feb 20, 11:00 AM
★
★

Diff 1448

View Options

core/kernel/session/session.php

Loading...
View Options

core/tests/Unit/kernel/session/fixtures/cookies.php

Loading...
View Options

core/tests/Unit/kernel/session/sessionTest.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server