Differential D177

INP-1522 - Adapt error output for CLI
ClosedPublic
Actions

Authored by alex on Dec 5 2015, 1:24 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rINP16334: Fixes INP-1522 - Adapt error output for CLI

Test Plan

throw an exception somewhere deep during application initialization (but not during run)
run in-portal script
confirm, that exception class/message is shown in CLI
confirm, that stack trace is shown
confirm, that no HTML is present in the output
trigger fatal error in place of exception
run in-portal script
confirm, that exception class/message is shown in CLI
confirm, that stack trace is shown
confirm, that no HTML is present in the output

Diff Detail

Repository

Branch

/in-portal/branches/5.3.x

Lint

Lint Errors

Excuse: Line with errors were just moved in here, so no fixing.

Severity	Location	Code	Message
Error	core/kernel/utility/logger.php:928	PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVar	Squiz.Strings.DoubleQuoteUsage.ContainsVar
Error	core/kernel/utility/logger.php:928	PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVar	Squiz.Strings.DoubleQuoteUsage.ContainsVar
Error	core/kernel/utility/logger.php:928	PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVar	Squiz.Strings.DoubleQuoteUsage.ContainsVar
Error	core/kernel/utility/logger.php:963	PHPCS.E.CodingStandard.Commenting.FunctionComment.MissingParamTag	CodingStandard.Commenting.FunctionComment.MissingParamTag
Error	core/kernel/utility/logger.php:1205	PHPCS.E.Generic.Files.LineLength.MaxExceeded	Generic.Files.LineLength.MaxExceeded

Unit

No Unit Test Coverage

Build Status

Buildable 269
Build 269: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 425.Dec 5 2015, 1:24 PM

alex retitled this revision from to INP-1522 - Adapt error output for CLI.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1522.

Herald added a reviewer: glebs. · View Herald TranscriptDec 5 2015, 1:24 PM

glebs accepted this revision.Dec 15 2015, 1:38 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2015, 1:38 AM

Closed by commit rINP16334: Fixes INP-1522 - Adapt error output for CLI (authored by alex). · Explain WhyJan 23 2016, 2:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 425

core/kernel/utility/logger.php

Loading...