Page MenuHomeIn-Portal Phabricator

INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method
ClosedPublic

Authored by erik on May 12 2016, 5:17 AM.

Details

Reviewers
alex
Summary

Removed name parameter as list_name alternative.

Test Plan
  1. go to Website & ContentProducts
  2. create some product, make it have approved status
  3. go to front end
  4. input existing product name in the search box, make search
  5. confirm that product is shown on search results page
  6. change template themes/advanced/in-commerce/elements/content_boxes/search_results.elm.tpl - change parameter from list_name="product_search_results" to name="product_search_results" in all 5 places in this template
  7. refresh page with search results
  8. confirm, that no products shown on search results page - that means name parameter has no effect more as list_name alternative

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 384
Build 384: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 524.May 12 2016, 5:17 AM
erik retitled this revision from to TADV-40 Use "list_name" instead of "name" parameter when dealing with lists.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): TADV-40.
alex accepted this revision.Nov 19 2016, 7:01 AM
alex edited edge metadata.

Changes partially overlap with D245 and will be incorporated in there.

This revision is now accepted and ready to land.Nov 19 2016, 7:02 AM
alex closed this revision.Nov 19 2016, 7:02 AM
alex retitled this revision from TADV-40 Use "list_name" instead of "name" parameter when dealing with lists to INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
alex edited edge metadata.
alex updated JIRA issue(s): added 1 INP-1447; removed 1 TADV-40.