INP-1502 - Gracefully handle case of missing file/line keys in stack trace info
ClosedPublic
Actions

Authored by alex on Nov 17 2016, 4:03 PM.

Details

Reviewers

erik

Commits

Test Plan

in IDE:
- open /core/units/phrases/phrases_config.php file for editing
- change value of ListSQLs unit config option to introduce SQL syntax error
in Admin Console
- go to Logs & Reports → System Log section
- press Delete All to remove all logged records
- go to Website & Content → Labels & Phrases section
- confirm, that SQL error happens
- confirm, that in Debugger (when debugger is enabled) the only error is one about broken SQL and it has trace above it
- go to Logs & Reports → System Log section
- confirm, that only present record is one about SQL error

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Maybe will fix in 5.3.x.

Severity	Location	Code	Message
Error	core/kernel/utility/logger.php:205	PHPCS.E.CodingStandard.NamingConventions.ValidVariableName.PublicHasUnderscore	CodingStandard.NamingConventions.ValidVariableName.PublicHasUnderscore

Unit

No Unit Test Coverage

Build Status

Buildable 529
Build 529: arc lint + arc unit

alex retitled this revision from to INP-1502 - Gracefully handle case of missing file/line keys in stack trace info.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1502.

erik edited edge metadata.

This revision is now accepted and ready to land.Nov 22 2016, 5:39 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	616	16431		Nov 17 2016, 4:03 PM	★	★
Diff 2	626	16457	rINP16460	Nov 24 2016, 2:16 PM	★	★