Differential D252

INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons
ClosedPublic
Actions

Authored by alex on Oct 21 2016, 9:35 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16476: Fixes INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons

Test Plan

in IDE:
- open /themes/advanced/index.tpl template for editing
- wrap content block tag in there in A tag (e.g. replace <inp2:st_ContentBlock num="1"/> with <a href="http://www.google.com"><inp2:st_ContentBlock num="1"/></a>)
in Admin Console
- go to Website & Content → Browse Website section
- click on Content Mode button in top frame
- click on orange Edit Content button, that represents content block which was wrapped in A tag before
- confirm, that popup/modal window with CKEditor was opened (before fix a redirect to link url would happen)

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 604.Oct 21 2016, 9:35 AM

alex retitled this revision from to INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1588.

Herald added a reviewer: erik. · View Herald TranscriptOct 21 2016, 9:35 AM

alex edited edge metadata.Oct 21 2016, 9:36 AM

alex added a project: Restricted Project.

erik accepted this revision.Oct 24 2016, 4:07 AM

erik edited edge metadata.

This revision is now accepted and ready to land.Oct 24 2016, 4:07 AM

Closed by commit rINP16476: Fixes INP-1588 - Don't propagate "click" event on orange "Edit Content" buttons (authored by alex). · Explain WhyNov 25 2016, 5:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 642

branches/5.2.x/core/kernel/db/db_tag_processor.php

Loading...