Unexpected output: Affected paths: relative - resubmit patch.
⚙ D274 INP-1660 - Make CKEditor styles dropdown larger
Page MenuHomeIn-Portal Phabricator
Differential D274

INP-1660 - Make CKEditor styles dropdown larger
ClosedPublic
Actions

Authored by alex on Dec 28 2016, 5:13 AM.

Details

Reviewers
erik
Commits
rTADV16593: Bug INP-1660 - Make CKEditor styles dropdown larger
rINP16592: Fixes INP-1660 - Make CKEditor styles dropdown larger
Test Plan
NOTE: Repeat tests below for both clean install and upgraded versions of In-Portal.

Part 1

  • in IDE:
    1. open /themes/advanced/index.tpl template for editing
    2. remove (if present) the mode attribute from the <inp2:st_ContentBlock ... tag
  • login to Admin Console
    1. go to Website & Content → Browse Website section
    2. click on Content Mode button in top frame
    3. click on orange Edit Content button
    4. click on Styles dropdown
    5. confirm, that large (larger, then before patch is applied) dropdown is opened

Part 2

  • in IDE:
    1. open /themes/advanced/index.tpl template for editing
    2. add mode="inline" attribute to the <inp2:st_ContentBlock ... tag
  • login to Admin Console
    1. go to Website & Content → Browse Website section
    2. click on Content Mode button in top frame
    3. click inside orange dotted frame (where orange Edit Content button was displayed in previous test)
    4. click on Styles dropdown
    5. confirm, that large (larger, then before patch is applied) dropdown is opened

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 631
Build 631: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 666.Dec 28 2016, 5:13 AM
alex retitled this revision from to INP-1660 - Make CKEditor styles dropdown larger.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1660.
alex edited edge metadata.Dec 28 2016, 9:11 AM
alex added a project: Restricted Project.
erik accepted this revision.Jan 4 2017, 5:05 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2017, 5:05 AM
Closed by commit rINP16592: Fixes INP-1660 - Make CKEditor styles dropdown larger (authored by alex). · Explain WhyJul 19 2017, 2:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 166616502Dec 28 2016, 5:13 AM
★
★
Diff 279916591rINP16592Jul 19 2017, 2:57 AM
★
★

Diff 666

View Options

core/admin_templates/incs/style_template.css

Loading...
View Options

core/install/install_data.sql

Loading...
View Options

core/install/upgrades.css

Loading...
View Options

core/install/upgrades.sql

Loading...
View Options

themes/advanced/platform/inc/styles.css

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server