Unexpected output:

Affected paths: relative - resubmit patch.

⚙ D275 INP-1661 - Check "CategoryHelper::getCategoryModule" method call result before using it

Differential D275

INP-1661 - Check "CategoryHelper::getCategoryModule" method call result before using it
ClosedPublic
Actions

Authored by alex on Dec 28 2016, 9:51 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16559: Fixes INP-1661 - Check "CategoryHelper::getCategoryModule" method call result…

Test Plan

repeat test plan of D161
login to Admin Console
go to Website & Content → Structure & Data section
click on Sections tab
create a CMS page, that is shown in menu
go to Front-End
confirm, that created page is shown in menu
click on page name to open it
confirm, that breadcrumns are shown and no notice is triggered

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 632
Build 632: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 667.Dec 28 2016, 9:51 AM

alex retitled this revision from to INP-1661 - Check "CategoryHelper::getCategoryModule" method call result before using it.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1661.

Herald added a reviewer: erik. · View Herald TranscriptDec 28 2016, 9:51 AM

alex edited edge metadata.Dec 28 2016, 9:52 AM

alex added a project: Restricted Project.

erik accepted this revision.Jan 4 2017, 4:47 AM

erik edited edge metadata.

This revision is now accepted and ready to land.Jan 4 2017, 4:47 AM

alex added a parent revision: D161: INP-1509 - Change concept used for category path matching to module root category.Jul 16 2017, 7:56 AM

Closed by commit rINP16559: Fixes INP-1661 - Check "CategoryHelper::getCategoryModule" method call result… (authored by alex). · Explain WhyJul 16 2017, 7:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 667

core/units/helpers/category_helper.php

Loading...

core/units/helpers/navigation_bar.php

Loading...