INP-1697 - Automate usage of "allow_html" block parameter
ClosedPublic
Actions

Authored by alex on May 1 2017, 1:52 AM.

Details

Reviewers

Commits

rMCUS16578: Bug INP-1697 - Automate usage of "allow_html" block parameter
rMINB16579: Bug INP-1697 - Automate usage of "allow_html" block parameter
rINP16577: Fixes INP-1697 - Automate usage of "allow_html" block parameter
rMINC16580: Bug INP-1697 - Automate usage of "allow_html" block parameter
rMINL16581: Bug INP-1697 - Automate usage of "allow_html" block parameter
rMINN16582: Bug INP-1697 - Automate usage of "allow_html" block parameter

Test Plan

Preparations

in IDE:
1. open /core/admin_templates/incs/form_blocks.tpl file for editing
2. locate declaration of inp_edit_textarea block
3. after </textarea> on next line add: <div>[[<inp2:$prefix_Field name="$field"/>]]</div>
4. save changes
5. open /modules/in-news/admin_templates/articles/articles_edit.tpl file for editing
6. locate declaration of form row for Excerpt field
7. after </textarea> on next line add: <div>[[<inp2:$prefix_Field name="$field"/>]]</div>
8. save changes
login to Admin Console:
1. go to Website & Content → Structure & Data section
2. click on Sections tab
3. place ID of Directory category (was 139 in my case) in before @@ID@@ after fixture instead of ID

WARNING: When checking for replaced value look between [[ and ]] below textarea !!!

Part 1

login to Admin Console
go to Website & Content → Structure & Data section
click on Sections tab
open any category for editing
for Description field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Meta Keywords, Meta Description and Analytics Tracking Code fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close editing window

Part 2

login to Admin Console
go to Website & Content → Forms section
open new form creation page
for Description field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
fill in required fields
go to E-mail Communication tab during
check Enable checkbox
for Reply Message Signature field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on E-mail Communication tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
close adding window

Part 3

login to Admin Console
go to Website & E-mail Templates section
open any e-mail template for editing
for HTML Version field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Text Version field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
click on Settings tab
for Replacement field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
for Description and Extra Headers fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on Settings tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close editing window

Part 4

login to Admin Console
go to User Management → Mailings section
open new mailing creation page
for HTML Version field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on Save button (ignore validation error) to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Text Version field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on Save button (ignore validation error) to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close adding window

Part 5

login to Admin Console
go to Website & Content → Promo Blocks → Default Group section
open new promo block creation page
for Text field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on Save button (ignore validation error) to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
close adding window

Part 6

NOTE: The D303 needs to be applied to test this part of the plan.

login to Admin Console
go to Configuration → Website → Regional section
open any language for editing
for HTML Version field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Text Version field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
click on E-mail Templates tab
open any e-mail template for editing
remove value from Subject field to cause validation error later
for HTML Version field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on Save button (ignore validation error) to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Extra Headers and Text Version fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on Save button (ignore validation error) to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close email template editing window
click on Labels tab
open any phrase for editing
for Phrase, Hint Phrase and Column Phrase fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on Save button (ignore validation error) to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close phrase editing window
close language editing window

Part 7

in Admin Console:
1. go to Website & Content → Forms section
2. create Contact Us form (even without fields)
3. go to Configuration → Users → General section
4. check Advanced User Management checkbox and save changes
5. go to User Management → Groups section
6. open editing of admin group
7. click on Permissions tab
8. check all permissions for Contact Us form
9. press Save toolbar button
10. remember ID of created form
in Database:
1. execute this SQL (replace {FORM_ID} with ID of created form):

INSERT INTO FormSubmissions (FormSubmissionId, FormId, SubmissionTime, IPAddress, ReferrerURL, LogStatus)
VALUES (DEFAULT, {FORM_ID}, 1493655880, '10.0.0.1', 'http://vm.aik.ninja/', 2);

in Admin Console:
1. go to Website & Content → Forms → Contact Us section
2. open any record for editing
3. for Notes field:
  1. confirm, that WYSIWYG editor icon isn't shown below field field
  2. type/paste fixture into field's textarea
4. click on Save button
5. open same record for editing
6. confirm, that @@ID@@ fragment below Notes field's textarea isn't converted into a link
7. close editing window

Part 8

login to Admin Console
go to User Management → Groups section
open editing of admin group
for Description and IP Restrictions fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close editing window

Part 9

login to Admin Console
go to Website & Content → Labels & Phrases section
open any phrase for editing
remove value from Label field to cause validation error later
for Phrase, Hint Phrase and Column Phrase fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. press Save button to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close editing window

Part 10

login to Admin Console
go to Website & Content → Structure & Data → Links section
click on Links tab
open new link adding window
fill all required fields on General tab
click on Comments (or Reviews) tab
open new comment/review adding
for Comment field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on Save button to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close comment/review adding window
close link adding window

Part 11

NOTE: The D303 needs to be applied to test this part of the plan.

login to Admin Console
go to Configuration → Website → Themes section
open theme for editing
remove value from Name field to cause validation error later
for Description field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close editing window

Part 12

login to Admin Console
go to Custom → Widgets section
open new record adding window
for Phone field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. press Save button to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close adding window

Part 13

login to Admin Console
go to Website & Content → Polls section
open new record adding window
for Question field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
enter all required fields on General tab
click on User Comments tab
open new comment adding window
for Comment field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. press Save button to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close comment adding window
close poll adding window

Part 14

login to Admin Console
go to E-commerce → Manufacturers section
open new record adding window
for Description field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. press Save button to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
close adding window

Part 15

login to Admin Console
go to Website & Content → Structure & Data → Products section
click on Products tab
open new tangible product adding window
for Description field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Excerpt and Meta Description fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
fill all required fields on General tab
click on Inventory tab
click on By Product value in Enabled field
accept confirmation dialog, that will appear
for Comment field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on Inventory tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close adding window

Part 16

login to Admin Console
go to E-commerce → Affiliates section
open new record adding window
for Comment field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
fill all required fields on General tab
press Save button to create new affiliate record
open created record for editing
press Pay Out button on toolbar
remove value from Amount field to cause validation error later
for Comment field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on Pay Out button to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close payment adding window
close affiliate editing window

Part 17

login to Admin Console
go to E-commerce → Orders section
click on Incomplete tab
open new record adding window
for User Comment and Admin Comment fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close adding window

Part 18

login to Admin Console
go to Website & Content → Structure & Data → Directory section
click on Links tab
open new link adding window
for Description field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Meta Description field:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close adding window

Part 19

login to Admin Console
go to Directory → Paid Listings section
click on Listing Types tab
open new record adding window
for Description field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
close adding window

Part 20

login to Admin Console
go to Website & Content → Structure & Data → News section
click on Articles tab
open new article adding window
for Article Body field:
1. confirm, that WYSIWYG editor icon is shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea is converted into a link
for Article Excerpt and Meta Description fields:
1. confirm, that WYSIWYG editor icon isn't shown below field field
2. type/paste fixture into field's textarea
3. click on General tab to reload the page submitting the changes
4. confirm, that @@ID@@ fragment below field's textarea isn't converted into a link
close adding window

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Not yet time for array formatting fixing.

Unit

No Unit Test Coverage

Build Status

Buildable 722
Build 722: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 736.May 1 2017, 1:52 AM

alex retitled this revision from to INP-1697 - Automate usage of "allow_html" block parameter.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1697.

Herald added a reviewer: erik. · View Herald TranscriptMay 1 2017, 1:52 AM

alex edited the test plan for this revision. (Show Details)May 1 2017, 1:25 PM

alex edited edge metadata.

Today tested parts 1..3 only.

Some issues on test plan:

9.5.C. - No clickable General tab on label editing screen. Button Save used for test.
11.4 - no Label field in the theme editing form (Name field is there)
20.6 - Article excerpt do not use standard inp_edit_textarea control, so it can't be tested this way without some additional changes.

This revision is now accepted and ready to land.May 10 2017, 6:01 AM

alex edited the test plan for this revision. (Show Details)May 10 2017, 6:48 AM

alex edited edge metadata.

In D301#5975, @erik wrote:

Some issues on test plan:

9.5.C. - No clickable General tab on label editing screen. Button Save used for test.
11.4 - no Label field in the theme editing form (Name field is there)
20.6 - Article excerpt do not use standard inp_edit_textarea control, so it can't be tested this way without some additional changes.

I've updated test plan to reflect proposed changes.

Closed by commit rINP16577: Fixes INP-1697 - Automate usage of "allow_html" block parameter (authored by alex). · Explain WhyJul 18 2017, 6:30 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	736	16543		May 1 2017, 1:51 AM	★	★
Diff 2	789	16576	rINP16577	Jul 18 2017, 6:30 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Severity	Location	Code	Message
Error	core/units/categories/categories_config.php:329	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:329	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:329	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:329	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:330	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:330	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:331	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:331	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:339	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:339	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:340	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:340	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:341	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:341	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:341	PHPCS.E.CodingStandard.WhiteSpace.CommaSpacing.After	CodingStandard.WhiteSpace.CommaSpacing.After
Error	core/units/categories/categories_config.php:341	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:341	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:382	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:382	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:383	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:383	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:384	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:384	PHPCS.E.CodingStandard.Array.Array.SpaceAfterKeyword	CodingStandard.Array.Array.SpaceAfterKeyword
Error	core/units/categories/categories_config.php:384	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found
Error	core/units/categories/categories_config.php:384	PHPCS.E.Generic.PHP.LowerCaseKeyword.Found	Generic.PHP.LowerCaseKeyword.Found

INP-1697 - Automate usage of "allow_html" block parameterClosedPublicActions

Details

Preparations

Part 1

Part 2

Part 3

Part 4

Part 5

Part 6

Part 7

Part 8

Part 9

Part 10

Part 11

Part 12

Part 13

Part 14

Part 15

Part 16

Part 17

Part 18

Part 19

Part 20

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 736

core/admin_templates/categories/categories_edit.tpl

core/admin_templates/forms/form_edit_emails.tpl

core/admin_templates/forms/forms_edit.tpl

core/admin_templates/incs/form_blocks.tpl

core/admin_templates/languages/email_template_edit.tpl

core/admin_templates/mailing_lists/mailing_list_edit.tpl

core/admin_templates/popups/translator.tpl

core/admin_templates/promo_blocks/promo_block_edit.tpl

core/admin_templates/regional/email_template_edit.tpl

core/admin_templates/regional/languages_edit.tpl

core/units/categories/categories_config.php

core/units/email_templates/email_templates_config.php

core/units/forms/forms/forms_config.php

core/units/forms/submission_log/submission_log_config.php

core/units/groups/groups_config.php

core/units/languages/languages_config.php

core/units/mailing_lists/mailing_lists_config.php

core/units/phrases/phrases_config.php

core/units/reviews/reviews_config.php

core/units/themes/themes_config.php

modules/custom/units/widgets/widgets_config.php

modules/in-bulletin/admin_templates/polls/poll_edit.tpl

modules/in-bulletin/admin_templates/topics/topics_edit.tpl

modules/in-bulletin/units/poll_comments/poll_comments_config.php

modules/in-bulletin/units/topics/topics_config.php

modules/in-commerce/admin_templates/manufacturers/manufacturers_edit.tpl

modules/in-commerce/admin_templates/products/products_edit.tpl

modules/in-commerce/units/affiliate_payments/affiliate_payments_config.php

modules/in-commerce/units/affiliates/affiliates_config.php

modules/in-commerce/units/orders/orders_config.php

modules/in-commerce/units/products/products_config.php

modules/in-link/admin_templates/links/links_edit.tpl

modules/in-link/admin_templates/paid_listings/paid_listing_type_edit.tpl

modules/in-link/units/links/links_config.php

modules/in-news/admin_templates/articles/articles_edit.tpl

modules/in-news/units/articles/articles_config.php

INP-1697 - Automate usage of "allow_html" block parameter
ClosedPublic
Actions

Revision Contents
Changeset List