Page MenuHomeIn-Portal Phabricator
Differential D281

INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL
ClosedPublic
Actions

Authored by alex on Jan 9 2017, 9:57 AM.

Details

Reviewers
erik
Commits
rINP16560: Fixes INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL
Test Plan
NOTE: The advanced theme must be set as primary for this test to work.

Part 1

  • perform installation of In-Portal 5.1.x
  • don't apply the patch yet
  • login to Admin Console
    1. go to Website & Content → Structure & Data → My Account → Login section
    2. click on Sections tab in main frame
    3. open Forgot Password category for editing
    4. specify frg in Short URL field and save changes
  • on the Front-End:
    1. access {base_url}/frg url (replace {base_url} with Base URL of your installation
    2. confirm, that no redirect was made and frg is still written in URL

Part 2

  • upgrade to In-Portal 5.2.x with patch applied
  • on the Front-End:
    1. remember URL to Forgot Password page from Forgot pasword? link in login sidebox on the left
    2. access {base_url}/frg url (replace {base_url} with Base URL of your installation
    3. confirm, that redirect to remembered before URL was made
    4. click on In-Portal logo in top left corner to return to homepage
    5. click on Forgot password? link in login sidebox on the left
    6. confirm, that redirect to URL remembered above was made
    7. click on Register link in login sidebox on the left
    8. confirm, that redirect to {base_url}/platform/login/register.html URL was made

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 763
Build 763: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 681.Jan 9 2017, 9:57 AM
alex retitled this revision from to INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1664.
alex edited the test plan for this revision. (Show Details)Jan 9 2017, 9:58 AM
alex edited edge metadata.
erik accepted this revision.Jan 11 2017, 5:05 AM
erik edited edge metadata.

There were much of SQL errors like

Warning: SQL Error: #1146 - Table 'dev_inportal_51x.inp_SystemLog' doesn't exist. SQL: INSERT INTO inp_SystemLog (LogUniqueId,LogMessage,LogLevel,LogCode,LogType,LogHostname,LogRequestSource,LogRequestURI,LogUserId,IpAddress,LogSessionKey,LogProcessId,LogUserData,LogNotificationStatus,LogInterface,LogSourceFilename,LogSourceFileLine,LogBacktrace,LogMemoryUsed,LogTimestamp,LogDate) VALUES ('799111288','Table \'dev_inportal_51x.inp_Languages\' doesn\'t exist','4','1146','2','erik.office.intechnic.com','1','/SVN/5.2.x/core/install.php','-2','94.30.191.24','0','4492','SELECT LanguageId, IF(AdminInterfaceLang, \"Admin\", \"Front\") AS LanguageKey\n FROM inp_Languages\n WHERE (AdminInterfaceLang = 1 OR PrimaryLang = 1) AND (Enabled = 1)','0','2','/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php','556','a:30:{i:0;a:6:{s:4:\"file\";s:57:\"/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php\";s:4:\"line\";i:556;s:8:\"function\";s:6:\"GetCol\";s:5:\"c #517751288 in /home/sites/dev/web/SVN/5.2.x/core/kernel/utility/logger.php on line

while upgrading from 5.1.x to 5.2.x.

This revision is now accepted and ready to land.Jan 11 2017, 5:05 AM
alex added a comment.Jan 11 2017, 5:14 AM
In D281#5486, @erik wrote:

There were much of SQL errors like

Warning: SQL Error: #1146 - Table 'dev_inportal_51x.inp_SystemLog' doesn't exist. SQL: INSERT INTO inp_SystemLog (LogUniqueId,LogMessage,LogLevel,LogCode,LogType,LogHostname,LogRequestSource,LogRequestURI,LogUserId,IpAddress,LogSessionKey,LogProcessId,LogUserData,LogNotificationStatus,LogInterface,LogSourceFilename,LogSourceFileLine,LogBacktrace,LogMemoryUsed,LogTimestamp,LogDate) VALUES ('799111288','Table \'dev_inportal_51x.inp_Languages\' doesn\'t exist','4','1146','2','erik.office.intechnic.com','1','/SVN/5.2.x/core/install.php','-2','94.30.191.24','0','4492','SELECT LanguageId, IF(AdminInterfaceLang, \"Admin\", \"Front\") AS LanguageKey\n FROM inp_Languages\n WHERE (AdminInterfaceLang = 1 OR PrimaryLang = 1) AND (Enabled = 1)','0','2','/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php','556','a:30:{i:0;a:6:{s:4:\"file\";s:57:\"/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php\";s:4:\"line\";i:556;s:8:\"function\";s:6:\"GetCol\";s:5:\"c #517751288 in /home/sites/dev/web/SVN/5.2.x/core/kernel/utility/logger.php on line

while upgrading from 5.1.x to 5.2.x.

Thanks for reporting. I'll look into that.

alex added a project: Restricted Project.Jul 16 2017, 8:07 AM
alex updated this revision to Diff 771.Jul 16 2017, 8:15 AM

Fixed patch apply conflicts.

Closed by commit rINP16560: Fixes INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL (authored by alex). · Explain WhyJul 16 2017, 8:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 168116502Jan 9 2017, 9:57 AM
★
★
Diff 277116559Fixed patch apply conflicts.Jul 16 2017, 8:15 AM
★
★
Diff 377216559rINP16560Jul 16 2017, 8:17 AM
★
★

Diff 771

View Options

core/install/upgrades.sql

Loading...
View Options

core/kernel/utility/http_query.php

Loading...
View Options

core/units/categories/categories_event_handler.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server