Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Sep 13 2016

erik requested review of D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 13 2016, 4:09 AM
erik updated the test plan for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 13 2016, 4:09 AM

Sep 9 2016

erik planned changes to D5: TADV-34 - Incorrect usage of "block_no_data" attribute.

Needs changes in test plan

Sep 9 2016, 5:27 AM
erik updated the test plan for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 9 2016, 5:16 AM
erik updated the diff for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.

Removed excessive block_no_data parameter from tags in cancel_recurring and cancel_recurring_ok templates.

Sep 9 2016, 5:15 AM

Sep 8 2016

erik updated the test plan for D5: TADV-34 - Incorrect usage of "block_no_data" attribute.
Sep 8 2016, 4:57 AM

Aug 25 2016

erik requested review of D245: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
Aug 25 2016, 8:46 AM
erik updated the test plan for D245: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
Aug 25 2016, 8:43 AM
erik retitled D245: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method from to INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method.
Aug 25 2016, 4:18 AM

Aug 23 2016

erik accepted D244: INP-1581 - Load email sender/recipient from live table.
Aug 23 2016, 4:17 AM

Aug 19 2016

erik accepted D242: INP-1580 - Set current user ID to current frame for Change Password dialog.
Aug 19 2016, 4:30 AM
erik accepted D240: INP-1577 - CS fix all variable type comment.
Aug 19 2016, 4:29 AM
erik accepted D241: INP-1578 - Don't remove "/system/cache/.gitignore" when clearing cache.
Aug 19 2016, 4:28 AM

Aug 10 2016

erik retitled D243: INP-1571 Form field validation should account for array-like field values from to INP-1571 Form field validation should account for array-like field values.
Aug 10 2016, 6:24 AM

Aug 5 2016

erik retitled D239: MINC-177 - Don't send "ORDER.SHIP" email, when email address is missing from to MINC-177 Don't send "ORDER.SHIP" email, when email address is missing.
Aug 5 2016, 5:21 AM

Aug 4 2016

erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

New code moved into "body" tag.

Aug 4 2016, 4:52 AM · Restricted Project
erik accepted D238: MINC-179 - Remove order id/object after the end of checkout process.

No problems found with changed code.

Aug 4 2016, 4:30 AM

Aug 3 2016

erik requested changes to D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.

Some tests failed.

  1. Preparations - "confirm, that Properties tab is visible" - Properties tab is visible, but is not active. Test supposes that Properties must be active - it tells click on Permissions tab to select it.
  2. Part 2 (with mod-rewrite) - "confirm, that clicked link detail page was opened" - not opened. Opened "404 not found" page. When link is under links directory - detail page opens normally. Under home - 404 not found.
Aug 3 2016, 4:51 AM

Aug 2 2016

erik requested changes to D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.

All tests done. No more errors found, excepting reported on Mon, Jul 25, 04:57.

Aug 2 2016, 6:02 AM

Jul 25 2016

erik added a comment to D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.

Testing partially done. Some tests failed.

Jul 25 2016, 4:57 AM

Jul 19 2016

erik accepted D237: INP-1572 - Change semaphores to allow concurrent editing of different DB records.
Jul 19 2016, 6:24 AM · Restricted Project

Jul 14 2016

erik retitled D236: MINC-178 - Replace billing with shipping email on "Shipping" step during checkout from to MINC-178 Replace billing with shipping email on "Shipping" step during checkout.
Jul 14 2016, 4:54 AM
erik retitled D235: INP-1555 - Disable "Advanced Content Filtering" in CKEditor from to INP-1555 Disable "Advanced Content Filtering" in CKEditor.
Jul 14 2016, 4:16 AM

Jul 13 2016

erik updated the diff for D182: MINC-137 Shopping cart update via AJAX support.

Re-submitted patch from 5.3.x project

Jul 13 2016, 5:09 AM · Restricted Project
erik accepted D234: INP-1570 - Make In-Portal Class Locator externally usable.
Jul 13 2016, 4:47 AM

Jul 12 2016

erik accepted D233: MINC-176 - Register missing classes in class factory.
Jul 12 2016, 4:57 AM

Jul 11 2016

erik requested changes to D233: MINC-176 - Register missing classes in class factory.
  1. Can't "confirm, that redirect to thank you page happened", as written in test plan. When not logged in front-end user performs "Place Order" operation, happens redirect to registration page, not to thank you page.
  2. Seems, test plan is incomplete - last line (press Ship toolbar button) requests test action, but no confirmation line following.
  3. Performing that "press Ship toolbar button" results in "mail error: header To is required" exception - http://screencast.com/t/ahSVogRnph6
Jul 11 2016, 4:35 AM

Jul 6 2016

erik accepted D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.
Jul 6 2016, 4:30 AM

Jul 5 2016

erik updated the diff for D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.

Removed CS fixes, added condition for DBType update.

Jul 5 2016, 4:30 AM

Jul 4 2016

erik retitled D231: INP-1560 Migrate "mysql" to "mysqli" database type during upgrade from to INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.
Jul 4 2016, 5:06 AM

Jun 30 2016

erik accepted D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
Jun 30 2016, 4:58 AM

Jun 22 2016

erik accepted D230: INP-1567 - Register missing classes in class factory.
Jun 22 2016, 4:58 AM

Jun 20 2016

erik requested review of D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 20 2016, 5:01 AM
erik added a comment to D222: INP-1327 Simplify custom permission checking in Event Handler.

Done - test plan improved.

Jun 20 2016, 4:48 AM
erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 20 2016, 4:44 AM

Jun 16 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 16 2016, 4:54 AM

Jun 15 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 15 2016, 4:53 AM

Jun 14 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 14 2016, 4:18 AM

Jun 13 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
Jun 13 2016, 4:29 AM

May 26 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 26 2016, 4:30 AM

May 20 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 20 2016, 4:57 AM

May 19 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 19 2016, 4:55 AM
erik added inline comments to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 19 2016, 4:54 AM

May 17 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 17 2016, 4:56 AM

May 16 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 16 2016, 5:12 AM
erik added inline comments to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 16 2016, 5:11 AM

May 12 2016

erik retitled D223: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method from to TADV-40 Use "list_name" instead of "name" parameter when dealing with lists.
May 12 2016, 5:17 AM

May 11 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 11 2016, 4:49 AM
erik updated the diff for D222: INP-1327 Simplify custom permission checking in Event Handler.

Patch transformed to 5.2.x version.

May 11 2016, 4:47 AM

May 5 2016

erik added inline comments to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 5 2016, 4:08 AM

May 3 2016

erik retitled D222: INP-1327 Simplify custom permission checking in Event Handler from to INP-1327 Simplified custom permission checking in Event Handler.
May 3 2016, 4:17 AM

Apr 18 2016

erik retitled D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class from to INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 18 2016, 4:37 AM · Restricted Project

Apr 5 2016

erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

Removed unnecessary links.elm.tpl change.

Apr 5 2016, 9:25 AM · Restricted Project
erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

Made new requested changes.

Apr 5 2016, 9:22 AM · Restricted Project
erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

Made requesred improvements.

Apr 5 2016, 6:25 AM · Restricted Project
erik updated the test plan for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Apr 5 2016, 6:11 AM · Restricted Project

Apr 4 2016

erik retitled D218: INP-1384 Delete "COMMON.FOOTER" event template from to INP-1384 The "COMMON.FOOTER" event is present on Clean Install.
Apr 4 2016, 4:56 AM

Apr 1 2016

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Fixed class variable type, made requested code style fixes.

Apr 1 2016, 4:28 AM · Restricted Project

Mar 30 2016

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Made requested optimization changes.

Mar 30 2016, 11:12 AM · Restricted Project
erik updated the test plan for D120: INP-1470 - Google Sitemap support.
Mar 30 2016, 10:05 AM · Restricted Project
erik updated the diff for D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.

Added silencing, changed doc blocks.

Mar 30 2016, 4:48 AM

Mar 29 2016

erik retitled D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method from to MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.
Mar 29 2016, 4:45 AM

Mar 24 2016

erik updated the test plan for D213: INP-1547 Create "promo-block:ImageField" tag.
Mar 24 2016, 6:06 AM · Restricted Project
erik updated the diff for D213: INP-1547 Create "promo-block:ImageField" tag.

Made fallback to deafult language when corrent langiage field is empty.

Mar 24 2016, 5:36 AM · Restricted Project
erik updated the test plan for D213: INP-1547 Create "promo-block:ImageField" tag.
Mar 24 2016, 5:35 AM · Restricted Project

Mar 23 2016

erik retitled D213: INP-1547 Create "promo-block:ImageField" tag from to INP-1547 Create "promo-block:ImageField" tag.
Mar 23 2016, 5:52 AM · Restricted Project

Mar 18 2016

erik retitled D206: INP-1541 - Add formatter to the "PromoBlockGroupId" field of "promo-block" unit from to INP-1541 - Add formatter to the "PromoBlockGroupId" field of "promo-block" unit.
Mar 18 2016, 5:36 AM · Restricted Project

Mar 16 2016

erik updated the diff for D202: INP-1532 Allow specifying scheduled time for Promo Blocks.

Removed excessive element from edit template

Mar 16 2016, 11:48 AM · Restricted Project
erik updated the diff for D202: INP-1532 Allow specifying scheduled time for Promo Blocks.

Changed error phrase

Mar 16 2016, 10:07 AM · Restricted Project
erik updated the diff for D202: INP-1532 Allow specifying scheduled time for Promo Blocks.

Fixed bugs in displaying wrong date interval error.

Mar 16 2016, 6:54 AM · Restricted Project
erik updated the test plan for D202: INP-1532 Allow specifying scheduled time for Promo Blocks.
Mar 16 2016, 6:50 AM · Restricted Project

Mar 15 2016

erik retitled D202: INP-1532 Allow specifying scheduled time for Promo Blocks from to INP-1532 Allow specifying scheduled time for Promo Blocks.
Mar 15 2016, 6:44 AM · Restricted Project
erik updated the diff for D201: INP-1531 Allow specifying default date/time for "inp_edit_date_time" control.

Fixed for case when date entered in field with "picker" format.

Mar 15 2016, 6:25 AM · Restricted Project

Mar 14 2016

erik updated the diff for D201: INP-1531 Allow specifying default date/time for "inp_edit_date_time" control.

Fixed difference with parent class in Format method declaration.

Mar 14 2016, 12:35 PM · Restricted Project
erik retitled D201: INP-1531 Allow specifying default date/time for "inp_edit_date_time" control from to INP-1531 Allow specifying default date/time for "inp_edit_date_time" control.
Mar 14 2016, 11:45 AM · Restricted Project

Mar 10 2016

erik requested review of D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine.
Mar 10 2016, 5:26 AM · Restricted Project

Feb 16 2016

erik accepted D196: INP-1157 - Support for user-defined fields in "st_CachedMenu" tag.
Feb 16 2016, 10:29 AM · Restricted Project

Jan 28 2016

erik updated the diff for D182: MINC-137 Shopping cart update via AJAX support.

Removed & before $event.

Jan 28 2016, 3:59 AM · Restricted Project

Jan 27 2016

erik updated the diff for D182: MINC-137 Shopping cart update via AJAX support.

Changed permissions checking, made reqiested code reformatting.

Jan 27 2016, 4:33 AM · Restricted Project
erik updated the diff for D182: MINC-137 Shopping cart update via AJAX support.

Changed permission checking, made requested code reformatting.

Jan 27 2016, 4:28 AM · Restricted Project

Jan 18 2016

erik updated the test plan for D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine.
Jan 18 2016, 4:04 AM · Restricted Project
erik updated the test plan for D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine.
Jan 18 2016, 4:03 AM · Restricted Project

Jan 14 2016

erik retitled D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine from to MINC-141 Remove excessive dest_country conversion in shipping quotes engine.
Jan 14 2016, 5:05 AM · Restricted Project

Dec 16 2015

erik retitled D182: MINC-137 Shopping cart update via AJAX support from to MINC-137 Shopping cart update via AJAX support.
Dec 16 2015, 4:25 AM · Restricted Project

Dec 8 2015

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Requested fixes and improvements.

Dec 8 2015, 4:55 AM · Restricted Project

Nov 17 2015

erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed excessive line, improved test plan before this revision

Nov 17 2015, 4:29 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 17 2015, 4:21 AM · Restricted Project

Nov 16 2015

erik updated the test plan for D167: INP-1514 Reset validation errors before object loading.
Nov 16 2015, 4:39 AM · Restricted Project
erik retitled D167: INP-1514 Reset validation errors before object loading from to INP-1514 Reset validation errors before object loading.
Nov 16 2015, 4:33 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed Clear() calls, added in the previous version of revision.

Nov 16 2015, 4:20 AM · Restricted Project

Nov 11 2015

erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Fixed SQL code indent

Nov 11 2015, 6:18 AM · Restricted Project

Nov 10 2015

erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Removed new helper, made inline code with count() in cycle conditions

Nov 10 2015, 11:45 AM · Restricted Project
erik added inline comments to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 10 2015, 4:58 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Changed test plan, added Clear() calls to fit new plan.

Nov 10 2015, 4:39 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 10 2015, 4:34 AM · Restricted Project

Nov 9 2015

erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Made requested code formatting

Nov 9 2015, 9:53 AM · Restricted Project
erik updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 9:12 AM · Restricted Project
erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Made requested changes for code optimization

Nov 9 2015, 7:48 AM · Restricted Project
erik updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 6:59 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed excessive code from shipping_quote_engine_event_handler.php

Nov 9 2015, 5:04 AM · Restricted Project