Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Yesterday

erik requested changes to D542: INP-1926 - Display "Hostname" and "Server Hostname" in the Session Log.

All by test plan is ok, but missing phrase for "Server Hostname" field (Session log grid column title).

Wed, Sep 3, 12:25 PM
erik accepted D541: INP-1924 - Immediately skip tests, that doesn't work without an Internet Connection.
Wed, Sep 3, 10:47 AM
erik accepted D540: INP-1925 - Configure PHPUnit integration with Arcanist.
Wed, Sep 3, 9:28 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Replaced assertEquels with assertSame in all tests, added in this revision.

Wed, Sep 3, 5:28 AM

Tue, Sep 2

erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Added test case when pounds and ounces both are zero.

Tue, Sep 2, 9:09 AM
erik added inline comments to D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 9:05 AM
erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Tue, Sep 2, 7:37 AM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Made all requested fixes. Created tests for kUbitFormatter class.

Tue, Sep 2, 7:33 AM
erik accepted D539: INP-1923 - Display "Server Hostname" in the System Log.
Tue, Sep 2, 5:23 AM

Mon, Sep 1

erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Mon, Sep 1, 1:38 PM
erik updated the diff for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.

Changed ligic, added unit tests.

Mon, Sep 1, 1:33 PM

Thu, Aug 14

erik accepted D372: INP-1774 - Display scaled down file size in uploader.
Thu, Aug 14, 1:36 PM · Restricted Project

Mon, Aug 11

erik requested changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Added tests for Core and Custom modules -

Mon, Aug 11, 6:19 AM

Tue, Aug 5

erik requested changes to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Tested all units, additional bugs found in the In-Commerce module.

Tue, Aug 5, 12:27 PM

Aug 4 2025

erik updated the test plan for D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Aug 4 2025, 6:32 AM
erik updated the test plan for D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Aug 4 2025, 6:29 AM
erik requested review of D538: MINC-212 Fix notice in the "Entire Order" functionality for the di/coupi/api units.
Aug 4 2025, 6:27 AM

Jul 31 2025

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Partially tested (done testing for Core module part).

  1. Languages.

1.1. Broken In-Portal clean install due error in lang prefix, preventing language record creation, required in normal installation process.
1.2. Due specific option_sql configuration for PackName and LocalName fields, possible add only record with values, that already exists. So, when no records in Languages table - can't add first language record.

  1. Categories - works well in admin interface, but problematic to add through object, because of Priority field options, that are populated only in OnPreSaveCreated event hook.
  2. Change logs - sometimes can't create through object same as languages, due specific Prefix and MasterPrefix field options_sql configuration. But in system records are created by direct SQL, so this not a problem. maybe.
  3. Users - can't create and update records with US State, because state options are populated too late - after SetFieldsFromHash already set error to the State field.
Jul 31 2025, 12:10 PM
erik updated the test plan for D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.
Jul 31 2025, 5:51 AM
erik requested review of D537: MINC-211 Remove "TitleField" option for the di/coupi/api units.
Jul 31 2025, 5:51 AM
erik accepted D535: INP-1921 - Improve Change Log performance.
Jul 31 2025, 5:30 AM

Jul 28 2025

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

I do not understand relation between test plan and proposed automation logic.

Jul 28 2025, 11:46 AM
erik accepted D534: INP-1920 - Ensure consistent named tab preset usage.
Jul 28 2025, 6:37 AM

Jul 24 2025

erik added a comment to D529: INP-1917 - Validate "kOptionsFormatter::Parse" method values.

Made partial testing. In the u and addr units, on State field Detected unknown_option validation error. As discussed in Zoom, started writing code for automated unit test to check create/update all units with kOptionsFormatter.

Jul 24 2025, 1:51 PM

Jul 23 2025

erik updated the test plan for D533: INP-1919 Reset unit config cache after Module Root Category change.
Jul 23 2025, 12:50 PM
erik requested review of D533: INP-1919 Reset unit config cache after Module Root Category change.
Jul 23 2025, 12:48 PM
erik accepted D531: INP-1916 - Correct scroll-to-error behavior on the Configuration Pages.
Jul 23 2025, 6:25 AM
erik requested changes to D531: INP-1916 - Correct scroll-to-error behavior on the Configuration Pages.

Part 3 - "confirm that the Select Module Root Section system setting value was properly saved" - It's not properly saved. After "Save" button pressed, page reloads and returns old Home → Products value.

Jul 23 2025, 6:00 AM
erik accepted D530: MINC-210 - Repair Downloadable products file downloads on the Front-End.
Jul 23 2025, 5:45 AM

Jul 22 2025

erik accepted D528: INP-1915 - Add support for IPv6 addresses.
Jul 22 2025, 7:03 AM

Jul 11 2025

erik requested changes to D528: INP-1915 - Add support for IPv6 addresses.

After clean install:

Jul 11 2025, 6:55 AM

Jul 10 2025

erik accepted D527: TADV-54 - Repair poll commenting in Mod-Rewrite mode.
Jul 10 2025, 9:50 AM

Jun 30 2025

erik accepted D526: INP-1914 - Disable "pass_through" handling on the Front-End.
Jun 30 2025, 1:07 PM

May 30 2025

erik accepted D525: INP-1913 - Allow sending custom HTTP headers.
May 30 2025, 7:51 AM
erik requested changes to D525: INP-1913 - Allow sending custom HTTP headers.

All test plan passed.

May 30 2025, 7:07 AM

May 27 2025

erik accepted D524: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
May 27 2025, 6:00 AM
erik accepted D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.
May 27 2025, 5:51 AM

May 26 2025

erik requested changes to D523: INP-1912 - Show "404 Page Not Found" page on the Front-End for unaccessible events.

2.2 - this part of test plan is excessive
2.3 - Failed all front-end tests. Always shown Oops, something went wrong text, not 404 page. Always System Log IS created about incident

May 26 2025, 11:05 AM
erik accepted D522: INP-1911 - Adjust exception message, when accessing non-existing event of an existing unit.
May 26 2025, 10:10 AM
erik accepted D521: INP-1910 - Allow specifying upcoming System Log record defaults.
May 26 2025, 9:12 AM

May 2 2025

erik accepted D505: INP-1894 - Extract "Change Log" code to a central place.
May 2 2025, 11:44 AM
erik accepted D514: INP-1822 - Use modern cookie encryption library.
May 2 2025, 11:40 AM

Apr 30 2025

erik updated the test plan for D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Apr 30 2025, 6:09 AM
erik requested review of D520: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Apr 30 2025, 6:09 AM

Apr 29 2025

erik accepted D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.
Apr 29 2025, 8:00 AM

Apr 25 2025

erik updated the diff for D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installation.

Boyscout improvements in session.php

Apr 25 2025, 11:31 AM

Apr 16 2025

erik requested changes to D519: INP-1908 - Discard template parser opened output buffers before doing a redirect.

Part 2 - "confirm, that you're seeing an Admin Console" - no, adding test code to OnLogin prevents from login to the adm.console.
Part 3 - "replace the tab URL with the provided URL (text after #redirect#)" - seems, missing some action and/or confirmation after this step ot the test plan

Apr 16 2025, 5:29 AM

Apr 9 2025

erik added a comment to D518: INP-1907 - Permit file uploads in any Web Browser.

Today I have z-index; 0; in DIV Can't provide screenshot without -index today.

Apr 9 2025, 6:27 AM

Apr 8 2025

erik accepted D518: INP-1907 - Permit file uploads in any Web Browser.

Part 2 - all right, so revision is accepted.

Apr 8 2025, 9:27 AM

Apr 3 2025

erik updated the diff for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.

done all requested code improvements

Apr 3 2025, 6:03 AM
erik updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 3 2025, 6:01 AM

Apr 2 2025

erik updated the test plan for D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 2 2025, 6:23 AM
erik requested review of D517: INP-1906 Execute "customProcessing" method in the "OnDelete" and "OnDeleteAll" events.
Apr 2 2025, 6:20 AM

Mar 25 2025

erik accepted D516: INP-1905 - Clear the "Temp Mode" flag after the Temp Table removal from the "OnCancelEdit" event.
Mar 25 2025, 7:57 AM

Mar 13 2025

erik accepted D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 13 2025, 12:59 PM
erik accepted D513: INP-1904 - Support opening an Admin Console from a Site Domain.
Mar 13 2025, 11:48 AM
erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.1 login to the Admin Console by accessing it on the sd1.test.domain.com domain over http:// protocol - FAILED, after login attempt - redirect to the login page. SUCCESS after cookies deleted (beyond test plan)
Part 3.1.12 confirm, that orange buttons for editing page/content blocks are now shown - NOT STABLE. At first attempt - no orange buttons. Then I logged in from main domain, set Default theme as primary theme, checked that orange buttons shown, restored Advanced theme as primary theme, then tried again login to sd1 domain, failed, cleared cookies, login to sd1 admin - and only then orange buttons shown

Mar 13 2025, 6:14 AM

Mar 12 2025

erik requested changes to D513: INP-1904 - Support opening an Admin Console from a Site Domain.

Part 3.1.7 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) - NO, [SD ID: ] is added. And this is right, because at Preparations 10 "add 1st site domain with: Domain Name=sd1-http.test.domain.com", not sd1.test.domain.com
Part 3.1.9 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 3.1.12 logout - FAILED, infinite redirect to http://sd1.test.domain.com/SVN/5.3.x/admin/index.php?env=-index%3Am0--default---&expired=1 happens
Part 3.2.2 confirm that you're looking at Admin Console at the test.domain.com domain over https:// protocol - NO, I'm looking at Admin Console at the sd1.test.domain.com domain over https:// protocol
Part 3.2.3 confirm that [SD ID: 1] is added in the current page blur bar (the 1 is site domain ID) = NO, [SD ID: ] is added in the current page blue bar
Part 3.2.5 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.2 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]
Part 4.4 confirm, that you'll see [Site Domain ID: 1] text (the 1 is site domain ID) - NO I see [Site Domain ID: 0]

Mar 12 2025, 10:04 AM
erik requested changes to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

Part 3.2 go to the Configuration → Website → Advanced section - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.
Part 7.9 confirm, that domain/protocol combo is allowed - NO The "https://front-https.test.domain.com" protocol/domain combo is not allowed.
Part 10.2 login - FAILED, can't. login, redirects to login screen. Logged in only after all current site cookies deleted before login.

Mar 12 2025, 7:48 AM

Mar 10 2025

erik updated the test plan for D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installation.
Mar 10 2025, 10:16 AM
erik requested review of D512: INP-1902 Populate the "SessionCookieDomains" system setting upon installation.
Mar 10 2025, 10:14 AM
erik accepted D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.
Mar 10 2025, 6:38 AM

Mar 6 2025

erik requested changes to D511: INP-1903 - Disallow opening a website on unsupported domains/protocols.

All tested, there is list of possible differences from test plan expectations.

Mar 6 2025, 6:27 AM

Feb 10 2025

erik updated the test plan for D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Feb 10 2025, 4:58 AM
erik requested review of D509: INP-1900 Ensure numeric parameter values inside "kUtil::Pounds2Kg" method.
Feb 10 2025, 4:55 AM

Feb 5 2025

erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 5:02 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 5:00 AM
erik updated the test plan for D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 4:59 AM
erik requested review of D508: INP-1897 Query for HTTP headers in the "kLogger::addRequestData" method only when the HTTPQuery object is available.
Feb 5 2025, 4:58 AM
erik updated the test plan for D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:43 AM
erik updated the test plan for D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:42 AM
erik requested review of D507: INP-1899 Preserve original formatting of multi-line error messages/exceptions in Debugger.
Feb 5 2025, 4:40 AM

Jan 29 2025

erik updated the test plan for D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:28 AM
erik updated the test plan for D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:26 AM
erik requested review of D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method.
Jan 29 2025, 10:24 AM

Jan 28 2025

erik accepted D504: INP-1894 - Extract "Change Log" code to a central place.
Jan 28 2025, 8:55 AM

Jan 23 2025

erik updated the diff for D503: INP-1893 Denormalize "ChangeLogs" database table.

Done all requested minor fixes

Jan 23 2025, 10:45 AM
erik added inline comments to D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 23 2025, 9:27 AM
erik updated the diff for D503: INP-1893 Denormalize "ChangeLogs" database table.

Done all requested improvements

Jan 23 2025, 5:19 AM
erik added inline comments to D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 23 2025, 4:54 AM

Jan 22 2025

erik updated the test plan for D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 22 2025, 12:21 PM
erik requested review of D503: INP-1893 Denormalize "ChangeLogs" database table.
Jan 22 2025, 12:20 PM

Dec 23 2024

erik accepted D502: INP-1891 - Display PHP errors in the Phing build log.
Dec 23 2024, 6:04 AM

Dec 19 2024

erik added a comment to D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.

Error fixed after svn update and clear memory cache.

Dec 19 2024, 12:48 PM
erik accepted D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.
Dec 19 2024, 12:42 PM
erik added a comment to D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.

Yes, when restarting before open index.php, then all is ok - no delay after patch applied

Dec 19 2024, 12:01 PM
erik accepted D491: INP-1880 - Fix notice on missing event permission mapping.
Dec 19 2024, 11:51 AM · Restricted Project
erik accepted D498: INP-1887 - Don't define the "EDITING_MODE" constant in the Installation Wizard.
Dec 19 2024, 11:34 AM
erik accepted D499: INP-1888 - Detect Memcache availability during installation using Memcache/Memcached PHP modules.
Dec 19 2024, 11:24 AM
erik requested changes to D500: INP-1889 - Don't use DB Load Balancer during PHPUnit Testing.

There happens error, due to this line in the AbstractBrowserTestCase.php

Dec 19 2024, 10:52 AM
erik accepted D501: INP-1890 - Force "\kApplication::NextResourceId" method to use master database connection.

Tests passed, but first time after patch applied need wait long time (2-3 minutes) to get ID shown. Next page refreshes becomes fast (~1 sec).

Dec 19 2024, 10:25 AM

Dec 10 2024

erik accepted D497: INP-1886 - Add value-clearing support for "kDateFormatter::UpdateSubFields" method.

All tests passed.

Dec 10 2024, 10:55 AM · Restricted Project

Nov 29 2024

erik accepted D494: INP-1863 - Correct PHPUnit integration.

All tested, All formal checks passed. But all builds, that has call to selenium - failed with message like.

Nov 29 2024, 4:36 AM

Nov 27 2024

erik requested changes to D494: INP-1863 - Correct PHPUnit integration.

Same way failed all builds until part 5.7 tests continued, because all formal requirements passed.

Nov 27 2024, 5:45 AM
erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Failed build at part 4 after command

phing -f tools/build/build_all.xml phpunit
Nov 27 2024, 5:11 AM

Nov 25 2024

erik added a comment to D494: INP-1863 - Correct PHPUnit integration.

Partialy tested, build failed after "run the phing -f tools/build/build_all.xml phpunit command" in the part 4 of test plan

Nov 25 2024, 5:34 AM

Nov 22 2024

erik accepted D495: INP-1884 - Actualize "/system/config.php" created during the build.

accepted, detected difference fixed in new patch version

Nov 22 2024, 4:51 AM
erik requested changes to D495: INP-1884 - Actualize "/system/config.php" created during the build.

All passed, excepting last part - config.php comparision.

Nov 22 2024, 4:40 AM

Nov 21 2024

erik accepted D496: INP-1885 - Consistently use PHP binary during the Build.
Nov 21 2024, 5:20 AM
erik requested changes to D496: INP-1885 - Consistently use PHP binary during the Build.

2 B part ir the test plan is failed. Build was not successful -

Nov 21 2024, 4:16 AM