Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Tue, Oct 8

erik accepted D487: INP-1877 - Check meta-permissions for "root" user.
Tue, Oct 8, 10:37 AM
erik requested changes to D487: INP-1877 - Check meta-permissions for "root" user.

Not passed test plan part

Tue, Oct 8, 10:06 AM

Thu, Oct 3

erik accepted D486: INP-1876 - Verify system settings access permissions before allowing to change them.
Thu, Oct 3, 11:21 AM · Restricted Project
erik accepted D486: INP-1876 - Verify system settings access permissions before allowing to change them.

Test by plan is passed, but, to have Groups section visible, with root user go to Configuration->Users-General section, press Save button - and got "Exception: Permission section not specified for prefix conf in w:\SVN\5.2.x\core\kernel\utility\event.php on line 439"

Thu, Oct 3, 9:53 AM · Restricted Project

Aug 5 2024

erik accepted D481: INP-1873 - Support MySQL 8 database collations.
Aug 5 2024, 9:38 AM · Restricted Project
erik requested changes to D480: INP-1872 - Properly handle constant absence during category cache rebuild.

System log errors exists, but, seems, not related to the current patch. Equal errors count with patch and without patch.

Aug 5 2024, 9:12 AM · Restricted Project

Jul 31 2024

erik accepted D478: INP-1756 - Create "Security*" classes for security-related jobs.
Jul 31 2024, 6:40 AM · Restricted Project

Jul 29 2024

erik accepted D477: INP-1871 - Properly dispose session during logout workflow.

Tested by using PHPStorm+XDebug with breakpoint in the SessionStorage::RemoveFromData method. Before patch applying SQL, that removes the priority_deleted session variable was executed. After patch applying SQL, that removes the priority_deleted session variable was not executed, because SessionSet property is set to false.

Jul 29 2024, 9:43 AM
erik accepted D476: INP-1870 - Save the session to the database immediately after the user login.
Jul 29 2024, 5:36 AM

Jul 25 2024

erik accepted D475: INP-1869 - Add vendor autoloader support for Class Locator.
Jul 25 2024, 6:44 AM

Jul 5 2024

erik requested review of D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:14 AM
erik updated the test plan for D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:13 AM
erik updated the test plan for D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 5 2024, 6:12 AM

Jul 4 2024

erik requested review of D474: MINC-202 - Fix currency selection in Site Domain scenario.
Jul 4 2024, 11:16 AM

Jun 21 2024

erik accepted D473: INP-1867 - Remove the MySQL password warning from Phing DB dumps.

No words "mysqldump", "Warning" in the resulting files.

Jun 21 2024, 5:21 AM

Jun 17 2024

erik accepted D470: INP-1866 - Verify SSL certificate on cURL connections.
Jun 17 2024, 11:03 AM
erik requested review of D472: INP-1865 Use cryptographically safe session key generator.
Jun 17 2024, 9:14 AM
erik requested review of D471: INP-1864 Require Username on the Login Form.
Jun 17 2024, 7:42 AM
erik requested changes to D470: INP-1866 - Verify SSL certificate on cURL connections.

Last line from test result is: "Test 5 (correct custom cert failure): Failed"
Not match with defined in test plan "Test 5 (correct custom cert failure): Passed"

Jun 17 2024, 7:10 AM

Jun 3 2024

erik accepted D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.
Jun 3 2024, 11:15 AM

May 31 2024

erik accepted D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

all right, test times:

May 31 2024, 7:13 AM · Restricted Project
erik accepted D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.
May 31 2024, 5:34 AM · Restricted Project

May 30 2024

erik requested changes to D467: INP-1860 - Remove HTML from "Site_Name" system setting result based on usage place.

All right in general, but

May 30 2024, 12:06 PM
erik requested changes to D469: INP-1861 - Cache results of the PHP_CodeSniffer & PHP_MessDetector.

Time reports for all 8 tests

May 30 2024, 11:33 AM · Restricted Project
erik accepted D468: INP-1862 - Execute "lint" prior to deploy during the build.
May 30 2024, 10:35 AM · Restricted Project

Jan 24 2024

erik accepted D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.

All works right, only test plan must be corrected.

Jan 24 2024, 8:43 AM
erik accepted D464: INP-1859 - Escape MySQL 8.3 keywords.

Can't test with correct MySQL version, but visually code looks good and works good with current MySQL version.

Jan 24 2024, 5:01 AM · Restricted Project

Jan 22 2024

erik accepted D461: INP-1855 - Support for window scrolling offset in the "Form" JS class.
Jan 22 2024, 10:33 AM · Restricted Project
erik accepted D462: INP-1857 - Prevent recursion in the "\kUrlManager::show404" method.
Jan 22 2024, 10:23 AM · Restricted Project

Jan 16 2024

erik requested changes to D460: INP-1840 - Reset form scroll prior to window resizing handling (bugfix).

In the chrome browser, after reload frame. window is not scrolled. In the firefox browser this auto-scrolling works good.

Jan 16 2024, 9:08 AM · Restricted Project

Jan 15 2024

erik accepted D459: INP-1853 - Use the "\kUtil::varDumpColorized" method in the System Log Web UI.
Jan 15 2024, 6:58 AM
erik accepted D458: INP-1852 - Create the "\kUtil::varDumpColorized" method.
Jan 15 2024, 6:32 AM · Restricted Project
erik requested changes to D458: INP-1852 - Create the "\kUtil::varDumpColorized" method.

Not working as expected in test plan. No result_number key detected.

Jan 15 2024, 6:19 AM · Restricted Project
erik accepted D457: INP-1851 - Log file upload meta-infomation as part of the Request Data.
Jan 15 2024, 4:31 AM · Restricted Project

Jan 11 2024

erik accepted D456: INP-1850 - Repair the "kHTTPQuery::getHeaders" method.
Jan 11 2024, 4:07 AM · Restricted Project

Jan 10 2024

erik added a comment to D456: INP-1850 - Repair the "kHTTPQuery::getHeaders" method.

Can't test - local system has apache_request_headers function and test array looks good without patch.

Jan 10 2024, 4:41 AM · Restricted Project

Jan 2 2024

erik added a comment to D453: INP-1847 - Specify image resizing defaults for category item images.

After in-portal update, test plan works well only after patch applying.

Jan 2 2024, 5:33 AM
erik accepted D453: INP-1847 - Specify image resizing defaults for category item images.

Test plan works well also without applying this patch.

Jan 2 2024, 5:02 AM

Dec 13 2023

erik requested review of D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice.

Written requested test plan

Dec 13 2023, 4:08 AM

Nov 27 2023

erik updated the test plan for D13: INP-1383 - Don't translate phrase from "empty_label" parameter of "PedefinedOptions" tag twice.
Nov 27 2023, 5:21 AM
erik accepted D278: INP-1653 - Emulate "CURLINFO_REDIRECT_URL" option in "kCurlHelper" class.
Nov 27 2023, 4:24 AM

Nov 15 2023

erik accepted D451: INP-1827 - Connect a testing framework.
Nov 15 2023, 5:17 AM · Restricted Project

Nov 14 2023

erik accepted D450: INP-1845 - Support for Nginx as a Reverse Proxy.
Nov 14 2023, 6:07 AM · Restricted Project

Aug 28 2023

erik accepted D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.
Aug 28 2023, 9:31 AM · Restricted Project

Jul 21 2023

erik accepted D448: INP-1843 - Cache results of the "kCountryStatesHelper::getCountryIso" method.
Jul 21 2023, 10:42 AM · Restricted Project

Jul 20 2023

erik accepted D449: MINC-200 - Cache results of the "ShippingQuoteEngine::initProperties" method.
Jul 20 2023, 6:04 AM · Restricted Project

Jul 7 2023

erik accepted D447: INP-1842 - Cache user primary group detection during Checkout.
Jul 7 2023, 3:11 AM · Restricted Project

Apr 19 2023

erik accepted D446: INP-1841 - Improve performance of System Log record removal code.
Apr 19 2023, 9:57 AM

Apr 17 2023

erik accepted D442: INP-1837 - Record code fragment in the System Log backtrace.
Apr 17 2023, 12:11 PM

Apr 11 2023

erik accepted D445: INP-1840 - Reset form scroll prior to window resizing handling.
Apr 11 2023, 11:50 AM · Restricted Project

Mar 22 2023

erik accepted D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 22 2023, 12:22 PM · Restricted Project
erik requested changes to D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 22 2023, 5:44 AM · Restricted Project
erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Failed test "Testing internal caches expiration for DB cache" in the part "all other keys have an expiration of 25 days (with a few seconds margin) relative to the time they're set".

Mar 22 2023, 5:35 AM · Restricted Project

Mar 21 2023

erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Partially tested for Memcached. Failed test with $application->addCache('key_with_exp', 'v2', 3600);

Mar 21 2023, 1:56 PM · Restricted Project

Mar 20 2023

erik requested changes to D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 20 2023, 9:38 AM · Restricted Project
erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Testing internal caches expiration for Memcache
ITEM test [1 b; 0 s]
Failed condition "these keys have infinite expiration (the 1738250904 number might differ on your install)" - given "0 s" is not like some great integer like "1738250904"

Mar 20 2023, 7:54 AM · Restricted Project
erik updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Done requested changes - returned fallback to FakeCacheHandler zero time parameterusage and comments.

Mar 20 2023, 6:28 AM · Restricted Project
erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Testing internal caches expiration for Memcache
ITEM site_serial:1766886194:1:master:last_cache_rebuild [68 b; 0 s]
Failed condition "these keys have infinite expiration (the 1738250904 number might differ on your install)" - given "0 s" is not like some great integer like "1738250904"

Mar 20 2023, 6:10 AM · Restricted Project

Mar 17 2023

erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Detected that after memcache restart, test setCache with $application->setCache('key_with_def_exp', 'v1');, is passed only when twice open index.php. First index.php opening does not set value.

Mar 17 2023, 1:55 PM · Restricted Project

Feb 23 2023

erik updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Renoved fallback logic, updated test plan.

Feb 23 2023, 4:45 AM · Restricted Project

Feb 22 2023

erik updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Feb 22 2023, 5:02 AM · Restricted Project

Feb 7 2023

erik accepted D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.
Feb 7 2023, 5:03 AM

Feb 3 2023

erik requested changes to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Tried test part 4. No messages in system log given. Maybe, because of START TRANSACTION SQL command. Transaction not committed, so no records created in DB.

Feb 3 2023, 1:46 AM · Restricted Project

Dec 5 2022

erik added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

On processing line with "Step 4." comment, i have lock much more then 50 seconds. Practically, it never ends. In case, when lock continue, in other debug window go to step 5 - lock ends, but no system log record about this lock created.

Dec 5 2022, 5:10 AM · Restricted Project

Dec 2 2022

erik added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

@alex trouble in part3 1 G - cant't get "detailed lock retry info is shown in the system log".

Dec 2 2022, 12:42 PM · Restricted Project

Nov 8 2022

erik accepted D438: INP-1834 - Connect "mtdowling/cron-expression" library.
Nov 8 2022, 12:51 PM · Restricted Project
erik requested changes to D438: INP-1834 - Connect "mtdowling/cron-expression" library.

Found difference from test plan expectation:
test Hour field validation: has error on 30-35 value

Nov 8 2022, 11:30 AM · Restricted Project

Oct 25 2022

erik accepted D437: INP-1833 - Add database server index to the error messages.
Oct 25 2022, 6:39 AM · Restricted Project

Oct 10 2022

erik accepted D436: INP-1832 - Use "p-rel" unit for relation management in the In-Commerce module.
Oct 10 2022, 5:36 AM · Restricted Project
erik accepted D435: INP-1831 - Allow specifying "HookToModule" in hook declarations.
Oct 10 2022, 5:30 AM · Restricted Project

Oct 7 2022

erik accepted D434: INP-1830 - Clear incompletely configured e-mail on error.
Oct 7 2022, 2:16 AM · Restricted Project

Oct 6 2022

erik accepted D433: INP-1829 - Add "keep_cents" field option for "kFormatter::Format" method.
Oct 6 2022, 5:06 AM · Restricted Project

Sep 19 2022

erik accepted D432: INP-1828 - Preserve engine type, when creating a temporary tables.
Sep 19 2022, 7:02 AM

Sep 15 2022

erik accepted D431: INP-1826 - Convert search/custom having filters into a where filters in grids.
Sep 15 2022, 5:18 AM

Sep 14 2022

erik requested changes to D431: INP-1826 - Convert search/custom having filters into a where filters in grids.

There is not simple filter by g.Name, but complex filter "((1) AND ( (g.Name) LIKE '%mem%'))", where part "(1) AND" is excessive. Maybe, this "(1) AND" should be removed from SQL request.

Sep 14 2022, 5:26 AM

Sep 9 2022

erik accepted D429: INP-1825 - Show In-Portal-specific superglobals in Debugger.
Sep 9 2022, 9:34 AM

Aug 24 2022

erik accepted D426: INP-1756 - Create "Security*" classes for security-related jobs.
Aug 24 2022, 6:50 AM
erik accepted D427: INP-1422 - Store class map on disk.
Aug 24 2022, 6:37 AM

Aug 17 2022

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Aug 17 2022, 7:17 AM · Restricted Project

Aug 10 2022

erik accepted D425: INP-1821 - Don't check event-based permissions from template for "root" user.
Aug 10 2022, 5:21 AM

Aug 9 2022

erik accepted D422: INP-1818 - Reset cURL settings only upon connection closing.
Aug 9 2022, 5:53 AM
erik accepted D423: INP-1819 - Allow retrieving response headers after making the cURL request.
Aug 9 2022, 5:53 AM

Aug 8 2022

erik accepted D424: INP-1820 - Optionally store added record data in the Changes Log.

Tested with clean install only.

Aug 8 2022, 9:36 AM · Restricted Project

Jul 27 2022

erik requested changes to D229: INP-1565 Add support for "relative" date format.

Math is incorrect.

Jul 27 2022, 1:43 PM

Jul 20 2022

erik accepted D421: MINN-27 - Add missing export-related virtual fields.
Jul 20 2022, 5:22 AM
erik accepted D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.
Jul 20 2022, 5:10 AM · Restricted Project

Jul 19 2022

erik updated the diff for D243: INP-1571 Form field validation should account for array-like field values.

Added code to avoid "Array to string conversion" notice. Added related test plan part.

Jul 19 2022, 9:53 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Jul 19 2022, 9:46 AM
erik accepted D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 19 2022, 7:58 AM · Restricted Project
erik accepted D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
Jul 19 2022, 7:56 AM

Jul 15 2022

erik requested changes to D388: INP-1791 - Add "picker" control type for configuration settings.
  1. In the test plan part 4 need "Picker" value, not "Checkboxes"
  2. However, if "Checkboxes" selected, looks incorrect - shown only one checkbox, not multiple checkboxes with one-two-three labels.
  3. Items alphabetical sorting is not applied on page load, so after save/on page reload options order may change.
Jul 15 2022, 12:48 PM · Restricted Project

Jul 14 2022

erik requested changes to D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.

Работает всё как надо, но наверное надо исправить Test Plan. В "Plan 2" и "Plan 3" в SQL не хватает фильтра WHERE ((52x_Users.UserType = 0))

Jul 14 2022, 10:35 AM
erik accepted D269: INP-1645 - Create categories during theme scan based on their location in SMS.
Jul 14 2022, 10:09 AM
erik accepted D419: INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method.
Jul 14 2022, 9:19 AM · Restricted Project

Jul 6 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Added missing table creation on in-portal upgrade

Jul 6 2022, 10:45 AM

Jul 5 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Changed install schema due Jenkins message - all primary key fields must be without null values

Jul 5 2022, 10:01 AM
erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Made all requested improvements

Jul 5 2022, 6:03 AM

Jul 4 2022

erik requested review of D420: INP-1817 - Change engine for storing export user presets.
Jul 4 2022, 12:57 PM

Apr 6 2022

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Apr 6 2022, 12:49 PM · Restricted Project

Sep 22 2021

erik accepted D415: INP-1811 - Support partitions in grids and direct INSERT/UPDATE clauses.
Sep 22 2021, 10:37 AM