Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Jan 20 2017

alex committed rMINL16517: Bug INP-1577 - CS fix all variable type comment.
Bug INP-1577 - CS fix all variable type comment
Jan 20 2017, 8:12 AM
alex committed rMINC16516: Bug INP-1577 - CS fix all variable type comment.
Bug INP-1577 - CS fix all variable type comment
Jan 20 2017, 8:12 AM
alex committed rMINB16515: Bug INP-1577 - CS fix all variable type comment.
Bug INP-1577 - CS fix all variable type comment
Jan 20 2017, 8:12 AM
alex committed rMCUS16514: Bug INP-1577 - CS fix all variable type comment.
Bug INP-1577 - CS fix all variable type comment
Jan 20 2017, 8:11 AM
alex committed rINP16513: Fixes INP-1577 - CS fix all variable type comment.
Fixes INP-1577 - CS fix all variable type comment
Jan 20 2017, 8:11 AM
alex closed D240: INP-1577 - CS fix all variable type comment by committing rINP16513: Fixes INP-1577 - CS fix all variable type comment.
Jan 20 2017, 8:11 AM
alex updated the diff for D240: INP-1577 - CS fix all variable type comment.

Restoring manual fixes (from original patch), that were done after automatic fixes.

Jan 20 2017, 7:56 AM
alex updated the diff for D240: INP-1577 - CS fix all variable type comment.

Replaying fix after In-Portal 5.2.2-B1 release.

Jan 20 2017, 6:55 AM
alex updated the diff for D232: INP-1566 - Don't log errors from 3rd party libraries to System Log.

Fixing cases, when error that should be logged wasn't logged and vice versa.

Jan 20 2017, 6:31 AM
alex requested review of D250: INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed.
Jan 20 2017, 5:26 AM · Restricted Project
alex updated the diff for D250: INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed.

Fixing implementation issue, that caused Template File field to be validated only on category type change.

Jan 20 2017, 5:24 AM · Restricted Project
alex updated the test plan for D250: INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed.
Jan 20 2017, 5:22 AM · Restricted Project
alex updated the test plan for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Jan 20 2017, 4:36 AM
alex added a comment to D282: INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method.

Forgot to post test plan originally. Posted now and can be tested for real.

Jan 20 2017, 4:31 AM
alex updated the test plan for D282: INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method.
Jan 20 2017, 4:30 AM

Jan 19 2017

alex added a comment to D256: INP-1325 - Perform intellectual cache update on category changes.

Fixing plan:

Jan 19 2017, 12:16 PM · Restricted Project
alex added a parent revision for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI: D282: INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method.
Jan 19 2017, 10:06 AM
alex retitled D282: INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method from to INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method.
Jan 19 2017, 10:02 AM

Jan 11 2017

alex added a comment to D281: INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL.
In D281#5486, @erik wrote:

There were much of SQL errors like

Warning: SQL Error: #1146 - Table 'dev_inportal_51x.inp_SystemLog' doesn't exist. SQL: INSERT INTO inp_SystemLog (LogUniqueId,LogMessage,LogLevel,LogCode,LogType,LogHostname,LogRequestSource,LogRequestURI,LogUserId,IpAddress,LogSessionKey,LogProcessId,LogUserData,LogNotificationStatus,LogInterface,LogSourceFilename,LogSourceFileLine,LogBacktrace,LogMemoryUsed,LogTimestamp,LogDate) VALUES ('799111288','Table \'dev_inportal_51x.inp_Languages\' doesn\'t exist','4','1146','2','erik.office.intechnic.com','1','/SVN/5.2.x/core/install.php','-2','94.30.191.24','0','4492','SELECT LanguageId, IF(AdminInterfaceLang, \"Admin\", \"Front\") AS LanguageKey\n FROM inp_Languages\n WHERE (AdminInterfaceLang = 1 OR PrimaryLang = 1) AND (Enabled = 1)','0','2','/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php','556','a:30:{i:0;a:6:{s:4:\"file\";s:57:\"/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php\";s:4:\"line\";i:556;s:8:\"function\";s:6:\"GetCol\";s:5:\"c #517751288 in /home/sites/dev/web/SVN/5.2.x/core/kernel/utility/logger.php on line

while upgrading from 5.1.x to 5.2.x.

Jan 11 2017, 5:14 AM · Restricted Project

Jan 10 2017

alex planned changes to D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Jan 10 2017, 4:03 AM
alex updated the diff for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Reconsidered relations between root user and permission system:

Jan 10 2017, 4:02 AM

Jan 9 2017

alex updated the test plan for D281: INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL.
Jan 9 2017, 9:58 AM · Restricted Project
alex retitled D281: INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL from to INP-1664 - Redirect to Canonical URL, when page is accessed via Short URL.
Jan 9 2017, 9:57 AM · Restricted Project

Jan 7 2017

alex planned changes to D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Jan 7 2017, 2:13 PM
alex updated the diff for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Don't consider installation-specific code, that checks for root user as permission-related code.

Jan 7 2017, 2:11 PM
alex planned changes to D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Jan 7 2017, 12:49 PM
alex updated the diff for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Override kApplication::Run and kApplication::Done methods in ConsoleApplication class to perform CLI-specific actions.

Jan 7 2017, 12:49 PM
alex planned changes to D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Jan 7 2017, 10:46 AM
alex updated the diff for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Removed composer.lock file, that was added by accident.

Jan 7 2017, 10:29 AM
alex updated the diff for D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.

Rebuilt against current 5.3.x code. Fixed some CS issues along the way.

Jan 7 2017, 10:26 AM
alex updated the test plan for D280: INP-1663 - Register missing classes in class factory V2.
Jan 7 2017, 5:13 AM
alex retitled D280: INP-1663 - Register missing classes in class factory V2 from to INP-1663 - Register missing classes in class factory V2.
Jan 7 2017, 5:04 AM

Jan 5 2017

alex requested changes to D269: INP-1645 - Create categories during theme scan based on their location in SMS.
Jan 5 2017, 3:35 AM
alex updated the diff for D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.

Removed debugging code.

Jan 5 2017, 3:23 AM
alex updated the diff for D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.

Changed additional_title_render_as block to be rendering as table cell.

Jan 5 2017, 3:23 AM
alex updated the test plan for D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.
Jan 5 2017, 3:21 AM
alex updated the test plan for D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.
Jan 5 2017, 3:16 AM

Jan 4 2017

alex requested review of D276: INP-1662 - Add methods for handling deprecations.
Jan 4 2017, 5:07 AM
alex updated the test plan for D276: INP-1662 - Add methods for handling deprecations.
Jan 4 2017, 5:06 AM

Jan 3 2017

alex requested changes to D278: INP-1653 - Emulate "CURLINFO_REDIRECT_URL" option in "kCurlHelper" class.

Also issues with Test Plan:

Jan 3 2017, 5:00 AM
alex requested changes to D277: INP-1589 - Actualize version/hash used in CKEditor PHP connector.

Existing code changes are fine, but here are few additions:

Jan 3 2017, 4:03 AM

Jan 1 2017

alex updated the test plan for D276: INP-1662 - Add methods for handling deprecations.
Jan 1 2017, 3:49 PM
alex updated the diff for D276: INP-1662 - Add methods for handling deprecations.

Rolling back accidental function to method replacements in non-changed code.

Jan 1 2017, 3:46 PM
alex updated the test plan for D276: INP-1662 - Add methods for handling deprecations.
Jan 1 2017, 3:41 PM
alex updated the test plan for D276: INP-1662 - Add methods for handling deprecations.
Jan 1 2017, 3:40 PM
alex retitled D276: INP-1662 - Add methods for handling deprecations from to INP-1662 - Add methods for handling deprecations.
Jan 1 2017, 3:33 PM

Dec 29 2016

alex committed rMINB16512: Merge of "modules/in-bulletin/branches/5.2.x@16488" to "modules/in….
Merge of "modules/in-bulletin/branches/5.2.x@16488" to "modules/in…
Dec 29 2016, 3:41 PM

Dec 28 2016

alex added a project to D275: INP-1661 - Check "CategoryHelper::getCategoryModule" method call result before using it: Unknown Object (Project).
Dec 28 2016, 9:52 AM · Unknown Object (Project)
alex retitled D275: INP-1661 - Check "CategoryHelper::getCategoryModule" method call result before using it from to INP-1661 - Check "CategoryHelper::getCategoryModule" method call result before using it.
Dec 28 2016, 9:51 AM · Unknown Object (Project)
alex added a project to D271: INP-1658 - Don't trigger clicks inside click event handler of CMS revision history dropdown: Restricted Project.
Dec 28 2016, 9:14 AM · Restricted Project
alex added a project to D273: INP-1659 - Add HTML5 runtime to Plupload options: Unknown Object (Project).
Dec 28 2016, 9:13 AM · Unknown Object (Project)
alex added a project to D274: INP-1660 - Make CKEditor styles dropdown larger: Restricted Project.
Dec 28 2016, 9:11 AM · Restricted Project
alex requested review of D273: INP-1659 - Add HTML5 runtime to Plupload options.

That won't do unfortunately. You need to test in real browser, not just a compatibility mode.

Dec 28 2016, 5:29 AM · Unknown Object (Project)
alex retitled D274: INP-1660 - Make CKEditor styles dropdown larger from to INP-1660 - Make CKEditor styles dropdown larger.
Dec 28 2016, 5:13 AM · Restricted Project

Dec 27 2016

alex retitled D273: INP-1659 - Add HTML5 runtime to Plupload options from to INP-1659 - Add HTML5 runtime to Plupload options.
Dec 27 2016, 5:08 AM · Unknown Object (Project)

Dec 26 2016

alex committed rTSIM16511: Merge of "themes/simple/releases/1.2.2-B1@16453" to "themes/simple/branches/1..
Merge of "themes/simple/releases/1.2.2-B1@16453" to "themes/simple/branches/1.
Dec 26 2016, 12:34 PM
alex committed rTDEF16510: Merge of "themes/default/releases/5.2.2-B1@16452" to….
Merge of "themes/default/releases/5.2.2-B1@16452" to…
Dec 26 2016, 12:34 PM
alex committed rTADV16509: Merge of "themes/advanced/releases/1.2.2-B1@16451" to….
Merge of "themes/advanced/releases/1.2.2-B1@16451" to…
Dec 26 2016, 12:33 PM
alex committed rMINN16508: Merge of "modules/in-news/branches/5.2.x@16487" to "modules/in….
Merge of "modules/in-news/branches/5.2.x@16487" to "modules/in…
Dec 26 2016, 12:32 PM
alex committed rMINL16507: Merge of "modules/in-link/branches/5.2.x@16486" to "modules/in….
Merge of "modules/in-link/branches/5.2.x@16486" to "modules/in…
Dec 26 2016, 12:30 PM
alex committed rMINC16506: Merge of "w/in-commerce/branches/5.2.x@16489" to "w/in-commerce/branches/5.3..
Merge of "w/in-commerce/branches/5.2.x@16489" to "w/in-commerce/branches/5.3.
Dec 26 2016, 12:27 PM
alex committed rMINB16505: Merge of "modules/in-bulletin/branches/5.2.x@16445" to "modules/in….
Merge of "modules/in-bulletin/branches/5.2.x@16445" to "modules/in…
Dec 26 2016, 12:20 PM
alex committed rMCUS16504: Merge of "modules/custom/branches/1.2.x@16485" to "modules/custom/branches/1..
Merge of "modules/custom/branches/1.2.x@16485" to "modules/custom/branches/1.
Dec 26 2016, 12:18 PM
alex committed rINP16503: Merge of "in-portal/branches/5.2.x@16484" to "in-portal/branches/5.3.x@16440"..
Merge of "in-portal/branches/5.2.x@16484" to "in-portal/branches/5.3.x@16440".
Dec 26 2016, 12:16 PM

Dec 22 2016

alex retitled D271: INP-1658 - Don't trigger clicks inside click event handler of CMS revision history dropdown from to INP-1658 - Don't trigger clicks inside click event handler of CMS revision history dropdown.
Dec 22 2016, 5:08 AM · Restricted Project

Dec 20 2016

alex requested review of D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.

Please test.

Dec 20 2016, 3:05 PM · Restricted Project
alex updated the diff for D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.

Fixing No Permission error, when pressing Edit Content button while being logged-in by non-root user.

Dec 20 2016, 3:04 PM · Restricted Project
alex updated the test plan for D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.
Dec 20 2016, 2:47 PM · Restricted Project
alex planned changes to D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.

When trying to edit content when non-root user is logged-in to the Admin Console getting No Permission error for c:OnStoreSelected event.

Dec 20 2016, 2:40 PM · Restricted Project

Dec 7 2016

alex retitled D268: INP-1656 - Emulate SVG file resize in "ImageHelper" from to INP-1656 - Emulate SVG file resize in "ImageHelper".
Dec 7 2016, 6:38 AM

Dec 6 2016

alex requested changes to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Haven't tested code yet, but here are needed corrections.

Dec 6 2016, 6:31 AM · Restricted Project

Dec 5 2016

alex requested changes to D11: INP-1313 - Add support for copying content blocks between themes.
Dec 5 2016, 3:10 AM
alex updated the test plan for D11: INP-1313 - Add support for copying content blocks between themes.
Dec 5 2016, 3:09 AM

Dec 4 2016

alex updated the diff for D253: INP-1590 - Add sub-item support to "AdminEditButton" tag.

Recreating patch to avoid conflicts during applying.

Dec 4 2016, 12:49 PM · Restricted Project

Dec 2 2016

alex added a comment to D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.

My bad. I haven't noticed, that:

  • there should be a TD in additional_title_render_as element itself
  • there should be a TABLE/TR around rendering of additional_title_render_as element
Dec 2 2016, 5:00 AM
alex retitled D267: INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block from to INP-1655 - Improve "additional_title_render_as" parameter support in "combined_header" block.
Dec 2 2016, 3:03 AM

Nov 29 2016

alex accepted D186: Remove excessive "dest_country" conversion in Shipping Quotes Engine.
Nov 29 2016, 7:51 AM · Restricted Project

Nov 28 2016

alex added inline comments to D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.
Nov 28 2016, 3:52 AM

Nov 26 2016

alex added a child revision for D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag: D266: INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation.
Nov 26 2016, 10:26 AM
alex added a parent revision for D266: INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation: D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
Nov 26 2016, 10:26 AM
alex updated the test plan for D266: INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation.
Nov 26 2016, 10:24 AM
alex retitled D266: INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation from to INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation.
Nov 26 2016, 10:19 AM

Nov 25 2016

alex committed rINP16501: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'in….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'in…
Nov 25 2016, 8:26 AM
alex committed rINP16500: Deleting version 'releases/5.2.2-B1' of 'in-portal' module..
Deleting version 'releases/5.2.2-B1' of 'in-portal' module.
Nov 25 2016, 8:26 AM
alex committed rINP16502: Committing 'svn:externals' property to 'releases/5.2.2-B1' in 'in-portal'….
Committing 'svn:externals' property to 'releases/5.2.2-B1' in 'in-portal'…
Nov 25 2016, 8:26 AM
alex committed rMINL16499: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of…
Nov 25 2016, 8:25 AM
alex committed rMINL16498: Deleting version 'releases/5.2.2-B1' of 'modules/in-link' module..
Deleting version 'releases/5.2.2-B1' of 'modules/in-link' module.
Nov 25 2016, 8:25 AM
alex committed rMINN16497: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of…
Nov 25 2016, 8:24 AM
alex committed rMINN16496: Deleting version 'releases/5.2.2-B1' of 'modules/in-news' module..
Deleting version 'releases/5.2.2-B1' of 'modules/in-news' module.
Nov 25 2016, 8:24 AM
alex committed rMINB16495: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of…
Nov 25 2016, 8:23 AM
alex committed rMINB16494: Deleting version 'releases/5.2.2-B1' of 'modules/in-bulletin' module..
Deleting version 'releases/5.2.2-B1' of 'modules/in-bulletin' module.
Nov 25 2016, 8:23 AM
alex committed rMINC16493: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'w/in….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'w/in…
Nov 25 2016, 8:22 AM
alex committed rMINC16492: Deleting version 'releases/5.2.2-B1' of 'w/in-commerce' module..
Deleting version 'releases/5.2.2-B1' of 'w/in-commerce' module.
Nov 25 2016, 8:22 AM
alex committed rMCUS16491: Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of….
Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of…
Nov 25 2016, 8:21 AM
alex committed rMCUS16490: Deleting version 'releases/1.2.2-B1' of 'modules/custom' module..
Deleting version 'releases/1.2.2-B1' of 'modules/custom' module.
Nov 25 2016, 8:21 AM
alex committed rMINC16489: Bug INP-1552 - Import language pack without overwrite on separate module install.
Bug INP-1552 - Import language pack without overwrite on separate module install
Nov 25 2016, 8:14 AM
alex committed rMINB16488: Bug INP-1552 - Import language pack without overwrite on separate module install.
Bug INP-1552 - Import language pack without overwrite on separate module install
Nov 25 2016, 8:14 AM
alex committed rMINN16487: Fixes INP-1552 - Import language pack without overwrite on separate module….
Fixes INP-1552 - Import language pack without overwrite on separate module…
Nov 25 2016, 8:13 AM
alex committed rMINL16486: Bug INP-1552 - Import language pack without overwrite on separate module install.
Bug INP-1552 - Import language pack without overwrite on separate module install
Nov 25 2016, 8:13 AM
alex committed rMCUS16485: Fixes INP-1552 - Import language pack without overwrite on separate module….
Fixes INP-1552 - Import language pack without overwrite on separate module…
Nov 25 2016, 8:13 AM