Build #110 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/110/

Build #58 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-53x_modules/58/

Build #107 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/107/

Restoring manual fixes (from original patch), that were done after automatic fixes.

Replaying fix after In-Portal 5.2.2-B1 release.

Fixing cases, when error that should be logged wasn't logged and vice versa.

Fixing implementation issue, that caused Template File field to be validated only on category type change.

Forgot to post test plan originally. Posted now and can be tested for real.

Fixing plan:

In D281#5486, @erik wrote:

There were much of SQL errors like

Warning: SQL Error: #1146 - Table 'dev_inportal_51x.inp_SystemLog' doesn't exist. SQL: INSERT INTO inp_SystemLog (LogUniqueId,LogMessage,LogLevel,LogCode,LogType,LogHostname,LogRequestSource,LogRequestURI,LogUserId,IpAddress,LogSessionKey,LogProcessId,LogUserData,LogNotificationStatus,LogInterface,LogSourceFilename,LogSourceFileLine,LogBacktrace,LogMemoryUsed,LogTimestamp,LogDate) VALUES ('799111288','Table \'dev_inportal_51x.inp_Languages\' doesn\'t exist','4','1146','2','erik.office.intechnic.com','1','/SVN/5.2.x/core/install.php','-2','94.30.191.24','0','4492','SELECT LanguageId, IF(AdminInterfaceLang, \"Admin\", \"Front\") AS LanguageKey\n FROM inp_Languages\n WHERE (AdminInterfaceLang = 1 OR PrimaryLang = 1) AND (Enabled = 1)','0','2','/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php','556','a:30:{i:0;a:6:{s:4:\"file\";s:57:\"/home/sites/dev/web/SVN/5.2.x/core/kernel/application.php\";s:4:\"line\";i:556;s:8:\"function\";s:6:\"GetCol\";s:5:\"c #517751288 in /home/sites/dev/web/SVN/5.2.x/core/kernel/utility/logger.php on line

while upgrading from 5.1.x to 5.2.x.

There were much of SQL errors like

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Reconsidered relations between root user and permission system:

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Don't consider installation-specific code, that checks for root user as permission-related code.

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Override kApplication::Run and kApplication::Done methods in ConsoleApplication class to perform CLI-specific actions.

I wasn't planning to send this one out for review, but arc diff --update did that automatically.

Removed composer.lock file, that was added by accident.

Rebuilt against current 5.3.x code. Fixed some CS issues along the way.

Removed debugging code.

Changed additional_title_render_as block to be rendering as table cell.

Test plan must be fixed. "Enable Debug Mode in /system/debug.php file" must be added somewhere between Part 2 and Part 3. Otherwise at Part 3 Debug Mode is disabled and confirmation about appearance of notices is not possible - notices does not appear.

Tasted also on https://www.browserstack.com (IE8 part)

Also issues with Test Plan:

Existing code changes are fine, but here are few additions:

Requested changes

Rolling back accidental function to method replacements in non-changed code.

That won't do unfortunately. You need to test in real browser, not just a compatibility mode.

Tested all with IE10. Tested with IE8, as browser mode of IE10 (through IE8 mode selection in developer tools).

Build #41 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-53x/41/