Page MenuHomeIn-Portal Phabricator
Feed Advanced Search

Apr 25 2019

erik accepted D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 9:15 AM · Restricted Project
erik accepted D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 25 2019, 7:31 AM · Restricted Project
erik added a comment to D359: INP-1762 - Destroy query object before logging.

Part 1 - general logging - tested. No issues found. Waiting for part 2 and part 3 of the test plan.

Apr 25 2019, 7:25 AM · Restricted Project
erik requested changes to D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.

Happens fatal error in the line

Apr 25 2019, 7:02 AM · Restricted Project

Mar 27 2019

erik accepted D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 27 2019, 5:55 AM · Restricted Project
erik accepted D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 27 2019, 5:16 AM · Restricted Project

Jan 11 2019

erik updated the diff for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

Added fallback to DB cache when Memcache is not available.

Jan 11 2019, 9:11 AM · Restricted Project
erik updated the test plan for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 9:06 AM · Restricted Project
erik created D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 5:27 AM · Restricted Project

Dec 19 2018

erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Changed SQL expression formatting

Dec 19 2018, 9:42 AM · Restricted Project
erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Improved SQL expression formatting, updated test plan.

Dec 19 2018, 8:04 AM · Restricted Project
erik updated the test plan for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 6:58 AM · Restricted Project

Dec 18 2018

erik created D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 18 2018, 10:39 AM · Restricted Project

Nov 16 2018

erik accepted D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 16 2018, 4:24 AM · Restricted Project

Nov 15 2018

erik requested changes to D354: INP-1756 - Create "Security*" classes for security-related jobs.
  1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.
  2. After installation with PHP v.7.2 new "SecurityHmacKey" and "SecurityEncryptionKey" settings were added normally, but test.php resulting in exception: -
Nov 15 2018, 11:33 AM · Restricted Project

Nov 14 2018

erik accepted D340: INP-1741 - Vertically align grid icons.
Nov 14 2018, 4:14 AM · Restricted Project

Nov 12 2018

erik requested changes to D340: INP-1741 - Vertically align grid icons.
  1. I do not understand where is improvement. I see, that before icon was 1 pixel over checkox. Now it is 1 pixel under checkbox, and I do not see any issue related to row count in "before" case
Nov 12 2018, 5:01 AM · Restricted Project

Nov 8 2018

erik requested review of D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 8 2018, 4:26 AM · Restricted Project
erik updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 8 2018, 4:25 AM · Restricted Project

Nov 7 2018

erik updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 7 2018, 4:59 AM · Restricted Project

Nov 5 2018

erik updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Made requested code fixes. TODO - test plan changes.

Nov 5 2018, 4:55 AM · Restricted Project

Oct 31 2018

erik accepted D350: INP-1751 - Use PHP5-style constructor names only in LibChart library code.
Oct 31 2018, 6:17 AM · Restricted Project
erik accepted D352: INP-1752 - Update sub-class method signatures to match overridden methods in parent class.
Oct 31 2018, 5:53 AM · Restricted Project

Oct 30 2018

erik created D351: INP-1750 - Support PHP Memcached extension for caching.
Oct 30 2018, 10:59 AM · Restricted Project

Oct 29 2018

erik updated the diff for D348: MINC-195 Don't use "break" during shipping quote aggregation.

Condition moved one level up.

Oct 29 2018, 6:13 AM · Restricted Project
erik updated the test plan for D348: MINC-195 Don't use "break" during shipping quote aggregation.
Oct 29 2018, 6:08 AM · Restricted Project

Oct 26 2018

erik updated the diff for D343: INP-1744 Make page content blocks searcheable.

Added missing phrase translation.

Oct 26 2018, 10:11 AM · Restricted Project
erik requested review of D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 8:20 AM · Restricted Project
erik commandeered D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 8:19 AM · Restricted Project
erik updated the diff for D343: INP-1744 Make page content blocks searcheable.

GROUP_CONCAT usage replaced with concatenation on php level.

Oct 26 2018, 6:46 AM · Restricted Project
erik updated the test plan for D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 6:40 AM · Restricted Project

Oct 25 2018

erik updated the diff for D349: INP-1721 Correct math for detecting allowed file size during upload.

Improvement for calculations result caching

Oct 25 2018, 12:09 PM
erik updated the test plan for D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 25 2018, 12:04 PM
erik created D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 25 2018, 7:38 AM

Oct 24 2018

erik created D348: MINC-195 Don't use "break" during shipping quote aggregation.
Oct 24 2018, 11:06 AM · Restricted Project

Sep 27 2018

erik added a comment to D243: INP-1571 Form field validation should account for array-like field values.

No, this error is not related to current task changes.

Sep 27 2018, 7:35 AM
erik added a comment to D243: INP-1571 Form field validation should account for array-like field values.

No strlen error in debugger from changed ValidateRange method. 'FirstName' test value detected as invalid in other validation method (ValidateType) and not passed to ValidateRange method.

Sep 27 2018, 6:37 AM
erik updated the diff for D243: INP-1571 Form field validation should account for array-like field values.

Done refactoring.

Sep 27 2018, 6:33 AM

Sep 21 2018

erik updated the test plan for D346: INP-1746 Correct time parsing in date range filter.
Sep 21 2018, 6:00 AM · Restricted Project
erik updated the diff for D346: INP-1746 Correct time parsing in date range filter.

Fixed bug in recursive call parameter.

Sep 21 2018, 5:54 AM · Restricted Project

Sep 19 2018

erik accepted D345: INP-1748 - Follow location, when generating static version of Maintenance Page.
Sep 19 2018, 6:00 AM · Restricted Project
erik accepted D347: INP-1749 - Load all content blocks of a page with a single database query.
Sep 19 2018, 5:46 AM · Restricted Project
erik updated the test plan for D346: INP-1746 Correct time parsing in date range filter.
Sep 19 2018, 5:35 AM · Restricted Project
erik updated the diff for D346: INP-1746 Correct time parsing in date range filter.

Made filter out all records when incorrect date entered.

Sep 19 2018, 5:31 AM · Restricted Project

Sep 17 2018

erik updated the test plan for D346: INP-1746 Correct time parsing in date range filter.
Sep 17 2018, 1:44 PM · Restricted Project
erik created D346: INP-1746 Correct time parsing in date range filter.
Sep 17 2018, 1:41 PM · Restricted Project

May 16 2018

erik updated the diff for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.

Made "Modified By" username output in place of e-mail in the edit forms.

May 16 2018, 8:30 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 8:26 AM
erik updated the diff for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.

Changed "Modified" output on topic edit form.

May 16 2018, 7:13 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 7:10 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 7:08 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 7:08 AM

May 15 2018

erik updated the diff for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
  1. Fixed phrase module.
  2. Fixed CS errors.
May 15 2018, 10:50 AM
erik created D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 15 2018, 10:43 AM

May 11 2018

erik accepted D343: INP-1744 Make page content blocks searcheable.
May 11 2018, 9:17 AM · Restricted Project

May 2 2018

erik requested changes to D337: INP-1738 - Apply CKEditor style changes in portable form.

Tested - this change does not affect CKEditor style dropdown in the other themes (default, simple). While testing, cms.css was changed to have width 300px. In the advanced theme dropdown become about square (300x300), and dropdowns in the other themes (default, simple) has no changes.

May 2 2018, 5:36 AM · Restricted Project

Apr 30 2018

erik added a comment to D337: INP-1738 - Apply CKEditor style changes in portable form.

Testing in progress, not finished. Cant normally upgrade from 5.1.c to 5.2.x. -

Patching to 5.2.2-B2 version:

Hunk #1 FAILED at 801.
1 out of 1 hunk FAILED -- saving rejects to file /tmp/skin_css_8ikYD3.rej

Apr 30 2018, 6:08 AM · Restricted Project
erik accepted D341: INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs.
Apr 30 2018, 5:11 AM · Restricted Project

Apr 26 2018

erik accepted D342: INP-1742 Apply "ItemType" filter in JOIN to Search Results table.
Apr 26 2018, 10:56 AM · Restricted Project

Apr 25 2018

erik accepted D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.
Apr 25 2018, 6:08 AM

Apr 19 2018

erik accepted D339: INP-1740 - Make CKEditor URL preview respect "SEO URL Ending".
Apr 19 2018, 6:02 AM · Restricted Project
erik accepted D340: INP-1741 - Vertically align grid icons.
Apr 19 2018, 5:50 AM · Restricted Project

Apr 11 2018

erik accepted D336: INP-1737 - Fallback to category title on primary language in Admin Console.
Apr 11 2018, 5:12 AM

Apr 5 2018

erik accepted D335: INP-1736 - Make "\kNavigationBar::getCategoryParentPath" method language-aware.
Apr 5 2018, 9:50 AM

Apr 2 2018

erik accepted D334: INP-1735 - Normalize block parameter values, used during function name creation.
Apr 2 2018, 5:18 AM · Restricted Project

Feb 23 2018

erik updated the diff for D333: INP-1733 Remove ".tmp" sub-extension from sub-item uploaded files.

Removed old Id hardcoding.

Feb 23 2018, 7:58 AM
erik updated the test plan for D333: INP-1733 Remove ".tmp" sub-extension from sub-item uploaded files.
Feb 23 2018, 6:54 AM
erik created D333: INP-1733 Remove ".tmp" sub-extension from sub-item uploaded files.
Feb 23 2018, 6:52 AM

Feb 8 2018

erik accepted D331: INP-1731 - Add support for "_" in option keys in grid filters and editing controls.
Feb 8 2018, 5:40 AM
erik accepted D332: INP-1732 Create user session, when search is performed.
Feb 8 2018, 5:28 AM

Dec 14 2017

erik requested changes to D330: INP-1730 - Add param/skip_param support for "key" parameter of "m_Cache" tag.

Tested, all tests passed, excepting Test2 in part "value after T_ADD_VAR[test]: haven't changed" - this value changed in this test
https://www.screencast.com/t/25QIBxii

Dec 14 2017, 6:36 AM · Restricted Project

Dec 12 2017

erik added a comment to D330: INP-1730 - Add param/skip_param support for "key" parameter of "m_Cache" tag.

Part 1 test not passed. - https://www.screencast.com/t/n8hWHlZ8zes

Dec 12 2017, 2:00 PM · Restricted Project

Dec 7 2017

erik updated the test plan for D329: MINC-194 Fix ECB currency rate downloader.
Dec 7 2017, 9:42 AM
erik updated the diff for D329: MINC-194 Fix ECB currency rate downloader.

Fixed notices.

Dec 7 2017, 9:23 AM
erik updated the test plan for D329: MINC-194 Fix ECB currency rate downloader.
Dec 7 2017, 9:07 AM
erik updated the test plan for D329: MINC-194 Fix ECB currency rate downloader.
Dec 7 2017, 9:03 AM

Dec 6 2017

erik created D329: MINC-194 Fix ECB currency rate downloader.
Dec 6 2017, 9:39 AM

Oct 25 2017

erik updated the test plan for D327: INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead" events.
Oct 25 2017, 5:22 AM
erik created D327: INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead" events.
Oct 25 2017, 5:20 AM

Sep 27 2017

erik accepted D326: INP-498 - Block grid auto-refresh, when Modal Window is opened.
Sep 27 2017, 5:29 AM · Restricted Project

Aug 31 2017

erik accepted D325: INP-1727 - Don't pass any unit info in "No Permission" redirects.
Aug 31 2017, 6:10 AM

Aug 8 2017

erik updated the diff for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Made all requested improvements.

Aug 8 2017, 5:57 AM · Restricted Project
erik updated the test plan for D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Aug 8 2017, 5:51 AM · Restricted Project

Aug 7 2017

erik added a comment to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Today written locally all requested changes code, not tested, stored to Shelf.

Aug 7 2017, 6:03 AM · Restricted Project

Aug 3 2017

erik accepted D324: INP-1726 - Add "Source" button to Content Blocks, edited in inline mode.
Aug 3 2017, 5:57 AM
erik accepted D321: INP-1719 - Only resize fully uploaded file.
Aug 3 2017, 5:48 AM
erik accepted D323: INP-1724 - Define "EDITING_MODE" constant, when not present.
Aug 3 2017, 5:25 AM

Jul 26 2017

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Made requested changes to category helper.

Jul 26 2017, 6:06 AM · Restricted Project

Jul 25 2017

erik updated the test plan for D120: INP-1470 - Google Sitemap support.
Jul 25 2017, 6:18 AM · Restricted Project
erik accepted D320: INP-1720 - Use "FileHelper::urlToPath" for "storage_format" field option handling.
Jul 25 2017, 5:17 AM

Jul 24 2017

erik requested changes to D320: INP-1720 - Use "FileHelper::urlToPath" for "storage_format" field option handling.

At part 3 resulting thumbnail size was not 100x100, but was 120x120.
At part 4 resulting thumbnail size was not 75x100, but was 90x120 (screenshot added for this case).

Jul 24 2017, 5:38 AM

Jul 18 2017

erik updated the diff for D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Reverted change of Enabled field name.

Jul 18 2017, 5:46 AM

Jul 14 2017

erik accepted D315: INP-1712 - Trigger "change" event, when checkbox value is changed by script.

All works properly, but test plan may be corrected:
Part 1, 13 - may be "confirm, that in Console 3 messages about change event appeared (for 2 option checkboxes + select all itself)" - because by previous part of the plan 2 options were unchecked.

Jul 14 2017, 6:07 AM · Restricted Project

Jul 12 2017

erik accepted D318: INP-1717 - Don't use "no_html_escape" attribute with "m_Get" tag.
Jul 12 2017, 6:05 AM

Jul 11 2017

erik accepted D313: INP-1710 - [bc fix] Asynchronous e-mail sending by default.
Jul 11 2017, 4:14 AM

Jul 7 2017

erik requested changes to D313: INP-1710 - [bc fix] Asynchronous e-mail sending by default.

Tested with system log enabled. No deprecation warnings found. All system log messages, got when testing, displayed on screenshot -

Jul 7 2017, 6:16 AM

Jul 5 2017

erik requested changes to D313: INP-1710 - [bc fix] Asynchronous e-mail sending by default.

All tests passed, excepting creating records about deprecated calls in the System Log - on tests such records never created. System Log is empty.

Jul 5 2017, 6:03 AM

Jul 4 2017

erik accepted D314: INP-1711 - Add vertical scrollbar to "grid_multioptions_filter" filter.

All right, but when upgrading from 5.1.x to 5.2.x with debugger enabled, got lot of error messages on all installation steps from 1st to 6th. Like "Table SystemLog doesn't exist"

Jul 4 2017, 5:46 AM · Restricted Project

Jun 28 2017

erik added a comment to D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Today made locally all requested changes, left testing by plan.

Jun 28 2017, 5:58 AM

Jun 21 2017

erik accepted D312: INP-1709 - Validate "Categories.FriendlyURL" field for uniqueness.
Jun 21 2017, 9:54 AM