Page MenuHomeIn-Portal Phabricator
Feed All Stories

Mar 11 2021

erik requested review of D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 11 2021, 10:47 AM · Restricted Project

Mar 8 2021

erik accepted D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Mar 8 2021, 4:42 AM · Restricted Project

Mar 4 2021

alex added a project to D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message: Restricted Project.
Mar 4 2021, 11:32 AM · Restricted Project
alex requested review of D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Mar 4 2021, 11:31 AM · Restricted Project
alex updated the test plan for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 7:22 AM
alex updated the diff for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Fixed outdating sorting resetting code on report change. Before the fix user would have got an SQL error.

Mar 4 2021, 7:20 AM
erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:48 AM
alex requested review of D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:33 AM
alex updated the diff for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Removed artifacts resulted after adding numberic IDField to every report grid:

Mar 4 2021, 5:32 AM
alex planned changes to D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:29 AM

Mar 3 2021

alex added a comment to D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
In D397#7804, @erik wrote:

Test plan is all right. But, beyond this patch, exists SQL error when doing "View Chart" for "By Product" and "By Section" cases. Problematic SQL is like

SELECT LEFT(c.l1_Name, 60) AS Name, c.CategoryId, SUM() as Metric
   FROM inp_Orders AS o
   LEFT JOIN inp_OrderItems AS od ON od.OrderId = o.OrderId
   LEFT JOIN inp_Products AS p ON p.ProductId = od.ProductId
   LEFT JOIN inp_CategoryItems AS ci ON ci.ItemResourceId = p.ResourceId
   LEFT JOIN inp_Categories AS c ON c.CategoryId = ci.CategoryId
   WHERE o.Status IN (4,6) AND o.OrderDate >= 1614718800 AND o.OrderDate <= 1614805199
   GROUP BY c.CategoryId
   HAVING NOT ISNULL(CategoryId)
   ORDER BY Metric DESC

There is "SUM() as Metric" column, where SUM argument is missing.

Mar 3 2021, 1:26 PM
erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Test plan is all right. But, beyond this patch, exists SQL error when doing "View Chart" for "By Product" and "By Section" cases. Problematic SQL is like

Mar 3 2021, 9:14 AM
alex updated the test plan for D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 3 2021, 7:34 AM
alex requested review of D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 3 2021, 6:16 AM
erik accepted D390: INP-1792 - Support HTML markup with Title Presets.
Mar 3 2021, 5:04 AM
erik accepted D391: INP-1793 - Disable output buffering in Console.
Mar 3 2021, 4:56 AM · Restricted Project
erik accepted D396: INP-1797 - Speed up formatter class access from "kDBItem".
Mar 3 2021, 4:48 AM · Restricted Project

Feb 26 2021

alex added a project to D396: INP-1797 - Speed up formatter class access from "kDBItem": Restricted Project.
Feb 26 2021, 9:05 AM · Restricted Project
alex requested review of D396: INP-1797 - Speed up formatter class access from "kDBItem".
Feb 26 2021, 9:04 AM · Restricted Project

Feb 23 2021

erik accepted D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
Feb 23 2021, 4:56 AM · Restricted Project
alex updated the diff for D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.

Previous fix changed logic of the code to allow empty field values, but that wasn't on purpose.

Feb 23 2021, 3:28 AM · Restricted Project
alex added a project to D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields: Restricted Project.
Feb 23 2021, 3:19 AM · Restricted Project
alex requested review of D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
Feb 23 2021, 3:19 AM · Restricted Project

Feb 19 2021

erik accepted D392: INP-1794 - Show database query execution times during deployment.
Feb 19 2021, 3:50 AM · Restricted Project
erik added a comment to D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.

Cant test this - do not have macOS

Feb 19 2021, 3:36 AM · Restricted Project
erik accepted D394: INP-1796 - Add method for setting database error handler.
Feb 19 2021, 3:22 AM

Feb 9 2021

alex added "INP-1742" JIRA issue(s) to rINP16671: Fixes INP-1742 - Apply "ItemType" filter in JOIN to Search Results table.
Feb 9 2021, 3:00 AM
alex committed rINP16671: Fixes INP-1742 - Apply "ItemType" filter in JOIN to Search Results table.
Fixes INP-1742 - Apply "ItemType" filter in JOIN to Search Results table
Feb 9 2021, 3:00 AM
alex closed D342: INP-1742 Apply "ItemType" filter in JOIN to Search Results table.
Feb 9 2021, 3:00 AM · Restricted Project
alex committed rINP16670: Fixes INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs.
Fixes INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs
Feb 9 2021, 2:55 AM
alex added "INP-1743" JIRA issue(s) to rINP16670: Fixes INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs.
Feb 9 2021, 2:55 AM
alex closed D341: INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs.
Feb 9 2021, 2:55 AM · Restricted Project
alex added "INP-1746" JIRA issue(s) to rINP16669: Fixes INP-1746 - Correct time parsing in date range filter.
Feb 9 2021, 2:52 AM
alex committed rINP16669: Fixes INP-1746 - Correct time parsing in date range filter.
Fixes INP-1746 - Correct time parsing in date range filter
Feb 9 2021, 2:52 AM
alex closed D346: INP-1746 Correct time parsing in date range filter.
Feb 9 2021, 2:52 AM · Restricted Project
alex added "INP-1748" JIRA issue(s) to rINP16668: Fixes INP-1748 - Follow location, when generating static version of Maintenance….
Feb 9 2021, 2:48 AM
alex committed rINP16668: Fixes INP-1748 - Follow location, when generating static version of Maintenance….
Fixes INP-1748 - Follow location, when generating static version of Maintenance…
Feb 9 2021, 2:48 AM
alex closed D345: INP-1748 - Follow location, when generating static version of Maintenance Page.
Feb 9 2021, 2:48 AM · Restricted Project

Jan 15 2021

alex added "INP-1749" JIRA issue(s) to rINP16667: Fixes INP-1749 - Load all content blocks of a page with a single database query.
Jan 15 2021, 9:06 AM
alex committed rINP16667: Fixes INP-1749 - Load all content blocks of a page with a single database query.
Fixes INP-1749 - Load all content blocks of a page with a single database query
Jan 15 2021, 9:06 AM
alex closed D347: INP-1749 - Load all content blocks of a page with a single database query.
Jan 15 2021, 9:06 AM · Restricted Project
alex requested changes to D351: INP-1750 - Support PHP Memcached extension for caching.

This change isn't a bug fix request, but a requirement change, that happened over time.

Jan 15 2021, 8:56 AM · Restricted Project

Jan 11 2021

alex added "INP-1751" JIRA issue(s) to rINP16666: Fixes INP-1751 - Use PHP5-style constructor names only in LibChart library code.
Jan 11 2021, 3:01 AM
alex committed rINP16666: Fixes INP-1751 - Use PHP5-style constructor names only in LibChart library code.
Fixes INP-1751 - Use PHP5-style constructor names only in LibChart library code
Jan 11 2021, 3:01 AM
alex closed D350: INP-1751 - Use PHP5-style constructor names only in LibChart library code.
Jan 11 2021, 3:01 AM · Restricted Project
alex added "INP-1753" JIRA issue(s) to rINP16665: Fixes INP-1753 - Protect against racing condition during Scheduled Tasks….
Jan 11 2021, 2:57 AM
alex committed rINP16665: Fixes INP-1753 - Protect against racing condition during Scheduled Tasks….
Fixes INP-1753 - Protect against racing condition during Scheduled Tasks…
Jan 11 2021, 2:57 AM
alex closed D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Jan 11 2021, 2:57 AM · Restricted Project
alex added "INP-1760" JIRA issue(s) to rINP16664: Fixes INP-1760 - Don't attempt to change "CachedUrls" table for units, that are….
Jan 11 2021, 2:51 AM
alex committed rINP16664: Fixes INP-1760 - Don't attempt to change "CachedUrls" table for units, that are….
Fixes INP-1760 - Don't attempt to change "CachedUrls" table for units, that are…
Jan 11 2021, 2:51 AM
alex closed D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2021, 2:51 AM · Restricted Project
alex committed rINP16663: Fixes INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Fixes INP-1761 - Account for LeftJoinOptimizer during grid total calculation
Jan 11 2021, 2:38 AM
alex added "INP-1761" JIRA issue(s) to rINP16663: Fixes INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Jan 11 2021, 2:38 AM
alex closed D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Jan 11 2021, 2:38 AM · Restricted Project

Jan 5 2021

alex added "INP-1762" JIRA issue(s) to rINP16662: Fixes INP-1762 - Destroy query object before logging.
Jan 5 2021, 3:06 AM
alex committed rINP16662: Fixes INP-1762 - Destroy query object before logging.
Fixes INP-1762 - Destroy query object before logging
Jan 5 2021, 3:06 AM
alex closed D359: INP-1762 - Destroy query object before logging.
Jan 5 2021, 3:06 AM · Restricted Project
alex added "INP-1763" JIRA issue(s) to rINP16661: Fixes INP-1763 - Use first found record in update sql in the "\kApplication….
Jan 5 2021, 2:56 AM
alex committed rINP16661: Fixes INP-1763 - Use first found record in update sql in the "\kApplication….
Fixes INP-1763 - Use first found record in update sql in the "\kApplication…
Jan 5 2021, 2:56 AM
alex closed D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Jan 5 2021, 2:56 AM · Restricted Project
alex added "INP-1764" JIRA issue(s) to rINP16660: Fixes INP-1764 - Set correct exit code, when exception happens in CLI.
Jan 5 2021, 2:52 AM
alex committed rINP16660: Fixes INP-1764 - Set correct exit code, when exception happens in CLI.
Fixes INP-1764 - Set correct exit code, when exception happens in CLI
Jan 5 2021, 2:52 AM
alex closed D361: INP-1764 - Set correct exit code, when exception happens in CLI.
Jan 5 2021, 2:52 AM · Restricted Project

Jan 4 2021

alex added "INP-1765" JIRA issue(s) to rINP16659: Fixes INP-1765 - Use table alias, when creating calculated fields for catalog….
Jan 4 2021, 3:01 AM
alex committed rINP16659: Fixes INP-1765 - Use table alias, when creating calculated fields for catalog….
Fixes INP-1765 - Use table alias, when creating calculated fields for catalog…
Jan 4 2021, 3:00 AM
alex closed D362: INP-1765 - Use table alias, when creating calculated fields for catalog items.
Jan 4 2021, 3:00 AM · Restricted Project
alex added "INP-1766" JIRA issue(s) to rINP16658: Fixes INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last….
Jan 4 2021, 2:59 AM
alex committed rINP16658: Fixes INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last….
Fixes INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last…
Jan 4 2021, 2:59 AM
alex closed D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
Jan 4 2021, 2:59 AM · Restricted Project
alex committed rINP16657: Fixes INP-1767 - Purge expired database cache entries.
Fixes INP-1767 - Purge expired database cache entries
Jan 4 2021, 2:55 AM
alex added "INP-1767" JIRA issue(s) to rINP16657: Fixes INP-1767 - Purge expired database cache entries.
Jan 4 2021, 2:55 AM
alex closed D364: INP-1767 - Purge expired database cache entries.
Jan 4 2021, 2:55 AM · Restricted Project
alex committed rINP16656: Fixes INP-1768 - Disable Load Balancing from CRON.
Fixes INP-1768 - Disable Load Balancing from CRON
Jan 4 2021, 2:50 AM
alex added "INP-1768" JIRA issue(s) to rINP16656: Fixes INP-1768 - Disable Load Balancing from CRON.
Jan 4 2021, 2:50 AM
alex closed D365: INP-1768 - Disable Load Balancing from CRON.
Jan 4 2021, 2:50 AM · Restricted Project
alex committed rINP16655: Fixes INP-1769 - Truncate search result table instead of dropping it.
Fixes INP-1769 - Truncate search result table instead of dropping it
Jan 4 2021, 2:48 AM
alex added "INP-1769" JIRA issue(s) to rINP16655: Fixes INP-1769 - Truncate search result table instead of dropping it.
Jan 4 2021, 2:48 AM
alex closed D366: INP-1769 - Truncate search result table instead of dropping it.
Jan 4 2021, 2:48 AM · Restricted Project
alex committed rINP16654: Fixes INP-1770 - Load default user persistent settings all at once.
Fixes INP-1770 - Load default user persistent settings all at once
Jan 4 2021, 2:42 AM
alex added "INP-1770" JIRA issue(s) to rINP16654: Fixes INP-1770 - Load default user persistent settings all at once.
Jan 4 2021, 2:42 AM
alex closed D367: INP-1770 Load default user persistent settings all at once.
Jan 4 2021, 2:42 AM
alex added "INP-1771" JIRA issue(s) to rINP16653: Fixes INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS"….
Jan 4 2021, 2:36 AM
alex committed rINP16653: Fixes INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS"….
Fixes INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS"…
Jan 4 2021, 2:36 AM
alex closed D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jan 4 2021, 2:36 AM · Restricted Project
alex added "INP-1772" JIRA issue(s) to rINP16652: Fixes INP-1772 - Don't use "/tmp" folder, when resizing uploaded images.
Jan 4 2021, 2:33 AM
alex committed rINP16652: Fixes INP-1772 - Don't use "/tmp" folder, when resizing uploaded images.
Fixes INP-1772 - Don't use "/tmp" folder, when resizing uploaded images
Jan 4 2021, 2:33 AM
alex closed D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jan 4 2021, 2:33 AM · Restricted Project
alex added "INP-1773" JIRA issue(s) to rINP16651: Fixes INP-1773 - Use "round" function during image resize instead of "ceil".
Jan 4 2021, 2:32 AM
alex committed rINP16651: Fixes INP-1773 - Use "round" function during image resize instead of "ceil".
Fixes INP-1773 - Use "round" function during image resize instead of "ceil"
Jan 4 2021, 2:32 AM
alex closed D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jan 4 2021, 2:32 AM · Restricted Project

Dec 31 2020

alex requested review of D394: INP-1796 - Add method for setting database error handler.
Dec 31 2020, 6:13 AM
alex added a comment to D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.

@erik , please accept this code as-is, because you don't have an environment setup to test it and the video from http://community.in-portal.org/display/BUG/Speed+up+language+pack+export+during+deployment shows that it's working.

Dec 31 2020, 5:44 AM · Restricted Project
alex added a project to D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript: Restricted Project.
Dec 31 2020, 5:38 AM · Restricted Project
alex updated the test plan for D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.
Dec 31 2020, 5:38 AM · Restricted Project
alex requested review of D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.
Dec 31 2020, 5:38 AM · Restricted Project

Dec 28 2020

alex updated the diff for D392: INP-1794 - Show database query execution times during deployment.

Show total SQL execution time. Show SQL execution time in different color based on it's speed (<1 min, <5 min, longer).

Dec 28 2020, 9:03 AM · Restricted Project
alex updated the test plan for D392: INP-1794 - Show database query execution times during deployment.
Dec 28 2020, 9:01 AM · Restricted Project
alex updated the diff for D392: INP-1794 - Show database query execution times during deployment.

Fixed incorrect minute display (was shown number of seconds instead of number of minutes).

Dec 28 2020, 7:52 AM · Restricted Project
alex updated the test plan for D392: INP-1794 - Show database query execution times during deployment.
Dec 28 2020, 7:43 AM · Restricted Project

Dec 23 2020

alex updated the test plan for D392: INP-1794 - Show database query execution times during deployment.
Dec 23 2020, 9:21 AM · Restricted Project