Combined error messages.

Fixed thrown exceprion messages.

In the themes\advanced\in-bulletin\elements\side_boxes\polls.elm.tpl change poll image output code to:

Removed excessive (array) typecast.

Fixed logic.

Also since task does optimization only, then here we should be checking that persistent setting retrieval with/without fallback code works as before (not covered) + verify performed SQL count (covered).

In D365#7225, @erik wrote:

Tested, working fine, but needs corrections in the test plan.

1. Some additional table must be in the master DB, not in slave DB.
2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:
   
   exit_code(1, 'This script needs to be enabled manually !');

Tested, working fine, but needs corrections in the test plan.

1. Some additional table must be in the master DB, not in slave DB.
2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:

Tested, in both cases got wrong code 255 (not 0 and not 1 )

Please retest all from scratch, because I've rewritten test plan.

Sending latest changes (maybe nothing was changed), but just in case.

Changed the code. Need to update test plan.

Part 1 - general logging - tested. No issues found. Waiting for part 2 and part 3 of the test plan.

I haven't noticed, that even though this fix looks standalone it still results in a Fatal Error until fix from D359 is applied. I've updated test plan to reflect that.

Happens fatal error in the line

Fixed a typo.

Introduce global flag, that allows to disable logging for slow queries for a block of sqls.

1. make sure, that SELECT queries used for slow query logging aren't counted towards total query count limit
2. [bugfix] attemt to get non-debug database query iterator while in debug mode would result in an exception

Added fallback to DB cache when Memcache is not available.

I've found one use case, that wasn't covered by initial plan.

Changed SQL expression formatting

Improved SQL expression formatting, updated test plan.

Build #164 finished with FAILURE status: http://ci.in-portal.org/job/in-portal-52x/164/

1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.

1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.
2. After installation with PHP v.7.2 new "SecurityHmacKey" and "SecurityEncryptionKey" settings were added normally, but test.php resulting in exception: -
   

Removed test file.

Fixed API difference causing a notice (and non-working cache), when attempting to get several keys at once using get method.