Page MenuHomeIn-Portal Phabricator
Feed All Stories

Nov 10 2015

erik added inline comments to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 10 2015, 4:58 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Changed test plan, added Clear() calls to fit new plan.

Nov 10 2015, 4:39 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 10 2015, 4:34 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Please thoroughly look through each comment I leave (every time on every revision). If you decide not to do as I've advised, then please explain why as a reply to relevant comment.

Nov 10 2015, 4:15 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
  1. add temporary line "$event->status = kEvent::erFAIL;" to CategoriesEventHandler::OnBeforeItemUpdate
  2. confirm that Approve and Decline buttons do not change Status for categories, but also no fatal error happens
  3. remove temporary line "$event->status = kEvent::erFAIL;" from CategoriesEventHandler::OnBeforeItemUpdate
Nov 10 2015, 2:27 AM · Restricted Project

Nov 9 2015

erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Made requested code formatting

Nov 9 2015, 9:53 AM · Restricted Project
alex added inline comments to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 9:18 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

The test plan seems to out of sync with reality this time as well.

Nov 9 2015, 9:15 AM · Restricted Project
erik updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 9:12 AM · Restricted Project
erik updated the diff for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Made requested changes for code optimization

Nov 9 2015, 7:48 AM · Restricted Project
erik updated the test plan for D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 9 2015, 6:59 AM · Restricted Project
alex requested changes to D165: INP-1510 Allow rotation of "Session Log" and "Changes Log".

Aside from inline comments following needs to be fixed in the test plan as well:

Nov 9 2015, 5:19 AM · Restricted Project
erik updated the diff for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.

Removed excessive code from shipping_quote_engine_event_handler.php

Nov 9 2015, 5:04 AM · Restricted Project
erik updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 9 2015, 4:53 AM · Restricted Project

Nov 6 2015

erik retitled D165: INP-1510 Allow rotation of "Session Log" and "Changes Log" from to INP-1510 Allow rotation of "Session Log" and "Changes Log".
Nov 6 2015, 11:24 AM · Restricted Project
alex updated the test plan for D161: INP-1509 - Change concept used for category path matching to module root category.
Nov 6 2015, 9:00 AM · Restricted Project
alex requested review of D161: INP-1509 - Change concept used for category path matching to module root category.

Please re-test.

Nov 6 2015, 8:54 AM · Restricted Project
alex updated the diff for D161: INP-1509 - Change concept used for category path matching to module root category.

Selecting Structure & Data category wasn't causing tab auto-switching.

Nov 6 2015, 8:54 AM · Restricted Project
alex planned changes to D161: INP-1509 - Change concept used for category path matching to module root category.

The Sections tab isn't activated when topmost section (the Structure & Data) is clicked.

Nov 6 2015, 8:35 AM · Restricted Project

Nov 5 2015

alex accepted D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 5 2015, 10:52 AM · Restricted Project
erik updated the diff for D162: INP-1511 - Add "export presets" support for category items export dialogs.

Removed excessive IncludeFieldTitles checkbox.

Nov 5 2015, 10:31 AM · Restricted Project
erik updated the diff for D162: INP-1511 - Add "export presets" support for category items export dialogs.

Moved configuration fields ro requested places

Nov 5 2015, 9:09 AM · Restricted Project
alex requested changes to D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 5 2015, 5:15 AM · Restricted Project
erik updated the diff for D158: INP-1487 Create empty search result table, when search keyword is too short.

Used getSearchTable method in additional places

Nov 5 2015, 4:56 AM · Restricted Project
erik updated the test plan for D158: INP-1487 Create empty search result table, when search keyword is too short.
Nov 5 2015, 4:46 AM · Restricted Project
alex requested changes to D158: INP-1487 Create empty search result table, when search keyword is too short.

Also test plan doesn't cover code path, that caused search table removal in past (e.g. make search that finds something and then make search with short/empty keyword).

Nov 5 2015, 2:48 AM · Restricted Project
alex requested changes to D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
  1. test plan is missing tests, that demonstrate, that problem, described in Confluence, no longer happen under same conditions
  2. please remove ShippingQuoteEngineEventHandler::iterateItems method because the only thing it does it rolling back event status change, that no longer happens in parent class method
Nov 5 2015, 2:36 AM · Restricted Project
glebs accepted D164: MINC-135 - Use shipping type from Order, when editing in Admin Console.
Nov 5 2015, 2:22 AM · Restricted Project

Nov 4 2015

alex retitled D164: MINC-135 - Use shipping type from Order, when editing in Admin Console from to MINC-135 - Use shipping type from Order, when editing in Admin Console.
Nov 4 2015, 8:37 AM · Restricted Project
glebs accepted D163: INP-1512 - Each "kDBBase::SetDefaultValues" call should respect "#NOW#" default value.
Nov 4 2015, 1:51 AM · Restricted Project

Nov 3 2015

erik updated the diff for D162: INP-1511 - Add "export presets" support for category items export dialogs.

Made required fixes

Nov 3 2015, 9:28 AM · Restricted Project
alex retitled D163: INP-1512 - Each "kDBBase::SetDefaultValues" call should respect "#NOW#" default value from to INP-1512 - Each "kDBBase::SetDefaultValues" call should respect "#NOW#" default value.
Nov 3 2015, 8:42 AM · Restricted Project
alex requested changes to D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 3 2015, 5:51 AM · Restricted Project
erik updated the test plan for D162: INP-1511 - Add "export presets" support for category items export dialogs.
Nov 3 2015, 5:16 AM · Restricted Project

Nov 2 2015

erik retitled D162: INP-1511 - Add "export presets" support for category items export dialogs from to INP-1511 Presets for category items export.
Nov 2 2015, 9:47 AM · Restricted Project
glebs accepted D161: INP-1509 - Change concept used for category path matching to module root category.
Nov 2 2015, 1:59 AM · Restricted Project

Oct 30 2015

alex retitled D161: INP-1509 - Change concept used for category path matching to module root category from to INP-1509 - Change concept used for category path matching to module root category.
Oct 30 2015, 11:43 AM · Restricted Project

Oct 29 2015

glebs accepted D159: INP-1508 - Enable non-sortable grid column title wrapping.
Oct 29 2015, 2:28 AM · Restricted Project

Oct 28 2015

glebs accepted D157: INP-1507 - Flush OpCode cache for /system/config.php when it's changed.
Oct 28 2015, 4:04 AM

Oct 27 2015

glebs accepted D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.
Oct 27 2015, 3:07 AM

Oct 26 2015

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Applued additional patch, made other requested changes.

Oct 26 2015, 6:01 AM · Restricted Project
erik updated the test plan for D120: INP-1470 - Google Sitemap support.
Oct 26 2015, 5:33 AM · Restricted Project
ci added a comment to rINP16300: Fixes INP-1503 - Search for new units during install/upgrade.

Build #39 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/39/

Oct 26 2015, 12:30 AM

Oct 25 2015

alex updated the test plan for D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.
Oct 25 2015, 3:05 PM
alex updated the diff for D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.

Links placed in Home category weren't shown on Front-End even with all permissions given.

Oct 25 2015, 3:05 PM
alex updated the test plan for D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.
Oct 25 2015, 3:02 PM
ci added a comment to rINP16286: Fixes INP-1444 - Show item name (vs module name) during category permission….

Build #38 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/38/

Oct 25 2015, 2:01 PM
alex committed rINP16300: Fixes INP-1503 - Search for new units during install/upgrade.
Fixes INP-1503 - Search for new units during install/upgrade
Oct 25 2015, 1:27 PM
alex closed D154: INP-1503 - Search for new units during install/upgrade by committing rINP16300: Fixes INP-1503 - Search for new units during install/upgrade.
Oct 25 2015, 1:27 PM
alex committed rINP16299: Fixes INP-1493 - Always expand calculated fields in WHERE filters.
Fixes INP-1493 - Always expand calculated fields in WHERE filters
Oct 25 2015, 1:23 PM
alex closed D145: INP-1493 - Always expand calculated fields in WHERE filters by committing rINP16299: Fixes INP-1493 - Always expand calculated fields in WHERE filters.
Oct 25 2015, 1:23 PM · Restricted Project
alex committed rINP16298: Fixes INP-1492 - Replace "%2$s" with current language in "kDBList….
Fixes INP-1492 - Replace "%2$s" with current language in "kDBList…
Oct 25 2015, 1:18 PM
alex closed D144: INP-1492 - Replace "%2$s" with current language in "kDBList::extractCalculatedFields" method by committing rINP16298: Fixes INP-1492 - Replace "%2$s" with current language in "kDBList….
Oct 25 2015, 1:18 PM · Restricted Project
alex committed rINP16297: Fixes INP-1504 - Correctly use "index_type" option from multilingual field….
Fixes INP-1504 - Correctly use "index_type" option from multilingual field…
Oct 25 2015, 1:05 PM
alex closed D155: INP-1504 - Correctly use "index_type" option from multilingual field declaration by committing rINP16297: Fixes INP-1504 - Correctly use "index_type" option from multilingual field….
Oct 25 2015, 1:05 PM
alex committed rINP16296: Fixes INP-1498 - Add protection against missing EmailEvents table during….
Fixes INP-1498 - Add protection against missing EmailEvents table during…
Oct 25 2015, 1:03 PM
alex closed D150: INP-1498 - Add protection against missing EmailEvents table during language pack import by committing rINP16296: Fixes INP-1498 - Add protection against missing EmailEvents table during….
Oct 25 2015, 1:02 PM
alex committed rINP16295: Fixes INP-1497 - Detect primary key of "email-template" unit automatically….
Fixes INP-1497 - Detect primary key of "email-template" unit automatically…
Oct 25 2015, 12:49 PM
alex closed D149: INP-1497 - Detect primary key of "email-template" unit automatically during upgrade by committing rINP16295: Fixes INP-1497 - Detect primary key of "email-template" unit automatically….
Oct 25 2015, 12:49 PM
alex committed rINP16294: Fixes INP-1496 - Don't initialize "scheduled-task" unit during installation.
Fixes INP-1496 - Don't initialize "scheduled-task" unit during installation
Oct 25 2015, 12:41 PM
alex closed D148: INP-1496 - Don't initialize "scheduled-task" unit during installation by committing rINP16294: Fixes INP-1496 - Don't initialize "scheduled-task" unit during installation.
Oct 25 2015, 12:41 PM
alex committed rINP16293: Fixes INP-1490 - Use width of frame with menu to detect current width in….
Fixes INP-1490 - Use width of frame with menu to detect current width in…
Oct 25 2015, 12:35 PM
alex closed D142: INP-1490 Use "width" method, to calculate menu frame in Admin Console by committing rINP16293: Fixes INP-1490 - Use width of frame with menu to detect current width in….
Oct 25 2015, 12:35 PM · Restricted Project
alex committed rMINC16292: Fixes MINC-134 - Lock tables to generate unique order numbers.
Fixes MINC-134 - Lock tables to generate unique order numbers
Oct 25 2015, 6:14 AM
alex closed D141: MINC-134 - Lock tables to generate unique order numbers by committing rMINC16292: Fixes MINC-134 - Lock tables to generate unique order numbers.
Oct 25 2015, 6:14 AM · Restricted Project
alex committed rINP16291: Fixes INP-1488 - Actualize "bugtraq:logregex" SVN property.
Fixes INP-1488 - Actualize "bugtraq:logregex" SVN property
Oct 25 2015, 6:10 AM
alex closed D139: INP-1488 - Actualize "bugtraq:logregex" SVN property by committing rINP16291: Fixes INP-1488 - Actualize "bugtraq:logregex" SVN property.
Oct 25 2015, 6:10 AM
alex committed rINP16290: Fixes INP-1479 - Define "pp_*" virtual fields in "user-profile" unit config.
Fixes INP-1479 - Define "pp_*" virtual fields in "user-profile" unit config
Oct 25 2015, 6:04 AM
alex closed D132: INP-1479 - Define "pp_*" virtual fields in "user-profile" unit config by committing rINP16290: Fixes INP-1479 - Define "pp_*" virtual fields in "user-profile" unit config.
Oct 25 2015, 6:04 AM
alex committed rMINC16289: Fixes MINC-133 - Don't run "OrdersEventHandler::CheckUser" method in CRON.
Fixes MINC-133 - Don't run "OrdersEventHandler::CheckUser" method in CRON
Oct 25 2015, 5:56 AM
alex closed D131: MINC-133 - Don't run "OrdersEventHandler::CheckUser" method in CRON by committing rMINC16289: Fixes MINC-133 - Don't run "OrdersEventHandler::CheckUser" method in CRON.
Oct 25 2015, 5:56 AM · Restricted Project
alex committed rINP16288: Fixes INP-1477 - Sort catalog items by primary key (id) during export.
Fixes INP-1477 - Sort catalog items by primary key (id) during export
Oct 25 2015, 5:52 AM
alex closed D126: INP-1477 - Sort catalog items by primary key (id) during export by committing rINP16288: Fixes INP-1477 - Sort catalog items by primary key (id) during export.
Oct 25 2015, 5:52 AM · Restricted Project
alex committed rMINC16287: Fixes MINC-132 - Round discounted/couponed price on MySQL side.
Fixes MINC-132 - Round discounted/couponed price on MySQL side
Oct 25 2015, 5:49 AM
alex closed D125: MINC-132 - Round discounted/couponed price on MySQL side by committing rMINC16287: Fixes MINC-132 - Round discounted/couponed price on MySQL side.
Oct 25 2015, 5:49 AM · Restricted Project
alex committed rINP16286: Fixes INP-1444 - Show item name (vs module name) during category permission….
Fixes INP-1444 - Show item name (vs module name) during category permission…
Oct 25 2015, 5:46 AM
alex closed D92: INP-1444 - Show item name (vs module name) during category permission editing by committing rINP16286: Fixes INP-1444 - Show item name (vs module name) during category permission….
Oct 25 2015, 5:46 AM · Restricted Project

Oct 22 2015

alex requested changes to D120: INP-1470 - Google Sitemap support.

Please also add <IN_SITEMAP>false</IN_SITEMAP> to the meta comment of login-protected advanced theme templates (e.g. My Account and such).

Oct 22 2015, 6:36 AM · Restricted Project

Oct 16 2015

erik added inline comments to D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Oct 16 2015, 5:26 AM · Restricted Project
erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

Improved js code for non-popup case.

Oct 16 2015, 5:24 AM · Restricted Project
erik retitled D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method from to INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Oct 16 2015, 4:23 AM · Restricted Project
glebs accepted D156: INP-1505 - Restore e-mail template translation sync code removed during merge.
Oct 16 2015, 2:28 AM

Oct 15 2015

glebs accepted D155: INP-1504 - Correctly use "index_type" option from multilingual field declaration.
Oct 15 2015, 2:01 AM
glebs accepted D154: INP-1503 - Search for new units during install/upgrade.
Oct 15 2015, 1:30 AM
glebs accepted D153: INP-1501 - Replace "emailevents" with "email-template" in 5.3.x upgrade script.
Oct 15 2015, 1:29 AM

Oct 14 2015

alex retitled D159: INP-1508 - Enable non-sortable grid column title wrapping from to INP-1508 - Enable non-sortable grid column title wrapping.
Oct 14 2015, 5:28 AM · Restricted Project

Oct 13 2015

erik retitled D158: INP-1487 Create empty search result table, when search keyword is too short from to INP-1487 Create empty search result table, when search keyword is too short.
Oct 13 2015, 4:47 AM · Restricted Project

Oct 12 2015

glebs accepted D152: INP-1500 - Remove excessing <%TABLE_PREFIX%> usages in "upgrades.sql" file.
Oct 12 2015, 2:17 AM
glebs accepted D151: INP-1499 - Don't use auto-loader for inclusion of ClassMapBuilder class from kFactory.
Oct 12 2015, 1:48 AM
glebs accepted D150: INP-1498 - Add protection against missing EmailEvents table during language pack import.
Oct 12 2015, 1:32 AM

Oct 11 2015

alex retitled D157: INP-1507 - Flush OpCode cache for /system/config.php when it's changed from to INP-1507 - Flush OpCode cache for /system/config.php when it's changed.
Oct 11 2015, 12:21 PM

Oct 9 2015

glebs accepted D149: INP-1497 - Detect primary key of "email-template" unit automatically during upgrade.
Oct 9 2015, 2:07 AM
glebs accepted D148: INP-1496 - Don't initialize "scheduled-task" unit during installation.
Oct 9 2015, 1:31 AM

Oct 8 2015

alex updated the test plan for D156: INP-1505 - Restore e-mail template translation sync code removed during merge.
Oct 8 2015, 6:38 AM
alex updated the test plan for D156: INP-1505 - Restore e-mail template translation sync code removed during merge.
Oct 8 2015, 6:24 AM
alex updated the test plan for D156: INP-1505 - Restore e-mail template translation sync code removed during merge.
Oct 8 2015, 6:24 AM
alex updated the test plan for D156: INP-1505 - Restore e-mail template translation sync code removed during merge.
Oct 8 2015, 6:23 AM
alex updated the test plan for D156: INP-1505 - Restore e-mail template translation sync code removed during merge.
Oct 8 2015, 6:23 AM
alex retitled D156: INP-1505 - Restore e-mail template translation sync code removed during merge from to INP-1505 - Restore e-mail template translation sync code removed during merge.
Oct 8 2015, 6:22 AM
erik updated the diff for D120: INP-1470 - Google Sitemap support.

Added Google maps support, made other requestes fixes.

Oct 8 2015, 4:39 AM · Restricted Project