Page MenuHomeIn-Portal Phabricator
Feed All Stories

Nov 24 2016

alex closed D251: INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS by committing rINP16475: Fixes INP-1587 - Change stylesheet URL for CKEditor to immediately return CSS.
Nov 24 2016, 3:06 PM · Restricted Project
alex planned changes to D250: INP-1586 - Automatically update "ThemeId" field of category, when it's "Type" is changed.

This change introduces a bug, that results in non-validating Template field to be existing file unless I change Type field.

Nov 24 2016, 3:03 PM · Restricted Project
ci added a comment to rINP16470: Fixes INP-1578 - Don't remove "/system/cache/.gitignore" when clearing cache.

Build #101 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/101/

Nov 24 2016, 3:01 PM
ci added a comment to rINP16468: Fixes INP-1572 - Change semaphores to allow concurrent editing of different DB….

Build #115 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x_modules/115/

Nov 24 2016, 3:01 PM
alex committed rINP16474: Fixes INP-1585 - Take value of "style" parameter of "inp_edit_multioptions"….
Fixes INP-1585 - Take value of "style" parameter of "inp_edit_multioptions"…
Nov 24 2016, 2:58 PM
alex closed D249: INP-1585 - Take value of "style" parameter of "inp_edit_multioptions" block into account by committing rINP16474: Fixes INP-1585 - Take value of "style" parameter of "inp_edit_multioptions"….
Nov 24 2016, 2:58 PM · Restricted Project
alex committed rINP16473: Fixes INP-1582 - Disable "codemirror" CKEditor add-on during inline Content….
Fixes INP-1582 - Disable "codemirror" CKEditor add-on during inline Content…
Nov 24 2016, 2:56 PM
alex closed D246: INP-1582 - Disable "codemirror" CKEditor add-on during inline Content Block editing by committing rINP16473: Fixes INP-1582 - Disable "codemirror" CKEditor add-on during inline Content….
Nov 24 2016, 2:56 PM · Restricted Project
alex committed rINP16472: Fixes INP-1581 - Load email sender/recipient from live table.
Fixes INP-1581 - Load email sender/recipient from live table
Nov 24 2016, 2:55 PM
alex closed D244: INP-1581 - Load email sender/recipient from live table by committing rINP16472: Fixes INP-1581 - Load email sender/recipient from live table.
Nov 24 2016, 2:55 PM
alex committed rINP16471: Fixes INP-1580 - Set current user ID to current frame for Change Password dialog.
Fixes INP-1580 - Set current user ID to current frame for Change Password dialog
Nov 24 2016, 2:53 PM
alex closed D242: INP-1580 - Set current user ID to current frame for Change Password dialog by committing rINP16471: Fixes INP-1580 - Set current user ID to current frame for Change Password dialog.
Nov 24 2016, 2:53 PM
ci added a comment to rINP16467: Fixes INP-1564 - Check duplicate SQL revisions across all defined revisions.

Build #100 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/100/

Nov 24 2016, 2:52 PM
alex committed rINP16470: Fixes INP-1578 - Don't remove "/system/cache/.gitignore" when clearing cache.
Fixes INP-1578 - Don't remove "/system/cache/.gitignore" when clearing cache
Nov 24 2016, 2:51 PM
alex closed D241: INP-1578 - Don't remove "/system/cache/.gitignore" when clearing cache by committing rINP16470: Fixes INP-1578 - Don't remove "/system/cache/.gitignore" when clearing cache.
Nov 24 2016, 2:51 PM
alex committed rMINC16469: Fixes MINC-179 - Remove order id/object after the end of checkout process.
Fixes MINC-179 - Remove order id/object after the end of checkout process
Nov 24 2016, 2:49 PM
alex closed D238: MINC-179 - Remove order id/object after the end of checkout process by committing rMINC16469: Fixes MINC-179 - Remove order id/object after the end of checkout process.
Nov 24 2016, 2:49 PM
alex committed rINP16468: Fixes INP-1572 - Change semaphores to allow concurrent editing of different DB….
Fixes INP-1572 - Change semaphores to allow concurrent editing of different…
Nov 24 2016, 2:47 PM
alex closed D237: INP-1572 - Change semaphores to allow concurrent editing of different DB records by committing rINP16468: Fixes INP-1572 - Change semaphores to allow concurrent editing of different DB….
Nov 24 2016, 2:47 PM · Restricted Project
ci added a comment to rINP16465: Fixes INP-1551 - Add the "kDBList::GetSelectedCount" method and….

Build #99 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/99/

Nov 24 2016, 2:43 PM
alex committed rINP16467: Fixes INP-1564 - Check duplicate SQL revisions across all defined revisions.
Fixes INP-1564 - Check duplicate SQL revisions across all defined revisions
Nov 24 2016, 2:43 PM
alex closed D227: INP-1564 Check duplicate SQL revisions across all defined revisions by committing rINP16467: Fixes INP-1564 - Check duplicate SQL revisions across all defined revisions.
Nov 24 2016, 2:43 PM
alex committed rINP16466: Fixes INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
Fixes INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag
Nov 24 2016, 2:41 PM
alex closed D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag by committing rINP16466: Fixes INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
Nov 24 2016, 2:41 PM
ci added a comment to rINP16461: Fixes INP-1513 - Fix word wrapping in "inp_edit_checkboxes" form control.

Build #98 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/98/

Nov 24 2016, 2:33 PM
alex committed rINP16465: Fixes INP-1551 - Add the "kDBList::GetSelectedCount" method and….
Fixes INP-1551 - Add the "kDBList::GetSelectedCount" method and…
Nov 24 2016, 2:32 PM
alex closed D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it by committing rINP16465: Fixes INP-1551 - Add the "kDBList::GetSelectedCount" method and….
Nov 24 2016, 2:32 PM
alex committed rMINC16464: Fixes MINC-168 - Rename "OrderHelper::getCreditCartType" into "OrderHelper….
Fixes MINC-168 - Rename "OrderHelper::getCreditCartType" into "OrderHelper…
Nov 24 2016, 2:30 PM
alex closed D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method by committing rMINC16464: Fixes MINC-168 - Rename "OrderHelper::getCreditCartType" into "OrderHelper….
Nov 24 2016, 2:30 PM
alex committed rINP16463: Fixes INP-1527 - User's profile update via AJAX support.
Fixes INP-1527 - User's profile update via AJAX support
Nov 24 2016, 2:27 PM
alex closed D189: INP-1527 User's profile update via AJAX support by committing rINP16463: Fixes INP-1527 - User's profile update via AJAX support.
Nov 24 2016, 2:27 PM · Restricted Project
alex committed rMINC16462: Fixes MINC-137 - Shopping cart update via AJAX support.
Fixes MINC-137 - Shopping cart update via AJAX support
Nov 24 2016, 2:24 PM
alex closed D182: MINC-137 Shopping cart update via AJAX support by committing rMINC16462: Fixes MINC-137 - Shopping cart update via AJAX support.
Nov 24 2016, 2:24 PM · Restricted Project
alex committed rINP16461: Fixes INP-1513 - Fix word wrapping in "inp_edit_checkboxes" form control.
Fixes INP-1513 - Fix word wrapping in "inp_edit_checkboxes" form control
Nov 24 2016, 2:23 PM
alex closed D166: INP-1513 Fix word wrapping in "inp_edit_checkboxes" form control by committing rINP16461: Fixes INP-1513 - Fix word wrapping in "inp_edit_checkboxes" form control.
Nov 24 2016, 2:23 PM · Restricted Project
alex committed rINP16460: Fixes INP-1502 - Gracefully handle case of missing file/line keys in stack….
Fixes INP-1502 - Gracefully handle case of missing file/line keys in stack…
Nov 24 2016, 2:16 PM
alex closed D261: INP-1502 - Gracefully handle case of missing file/line keys in stack trace info by committing rINP16460: Fixes INP-1502 - Gracefully handle case of missing file/line keys in stack….
Nov 24 2016, 2:16 PM
ci added a comment to rINP16457: Fixes INP-1486 - Don't give up, when single item update fails in "iterateItems"….

Build #96 finished with FAILURE status: http://ci.in-portal.org/job/in-portal-52x/96/

Nov 24 2016, 11:14 AM
glebs requested review of D229: INP-1565 Add support for "relative" date format.
Nov 24 2016, 11:11 AM
glebs updated the test plan for D229: INP-1565 Add support for "relative" date format.
Nov 24 2016, 11:08 AM
alex committed rMINL16459: Bug INP-1486 - Don't give up, when single item update fails in "iterateItems"….
Bug INP-1486 - Don't give up, when single item update fails in "iterateItems"…
Nov 24 2016, 11:06 AM
alex committed rMINC16458: Bug INP-1486 - Don't give up, when single item update fails in "iterateItems"….
Bug INP-1486 - Don't give up, when single item update fails in "iterateItems"…
Nov 24 2016, 11:05 AM
alex committed rINP16457: Fixes INP-1486 - Don't give up, when single item update fails in "iterateItems"….
Fixes INP-1486 - Don't give up, when single item update fails in…
Nov 24 2016, 11:05 AM
alex closed D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method by committing rINP16457: Fixes INP-1486 - Don't give up, when single item update fails in "iterateItems"….
Nov 24 2016, 11:05 AM · Restricted Project
ci added a comment to rINP16456: Fixes INP-1447 - Remove usage of 'name' parameter in "kDBTagProcessor::GetList"….

Build #95 finished with FAILURE status: http://ci.in-portal.org/job/in-portal-52x/95/

Nov 24 2016, 10:57 AM
alex committed rINP16456: Fixes INP-1447 - Remove usage of 'name' parameter in "kDBTagProcessor::GetList"….
Fixes INP-1447 - Remove usage of 'name' parameter in "kDBTagProcessor…
Nov 24 2016, 10:47 AM
alex closed D245: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method by committing rINP16456: Fixes INP-1447 - Remove usage of 'name' parameter in "kDBTagProcessor::GetList"….
Nov 24 2016, 10:47 AM
glebs accepted D263: INP-1641 - PHP 7 compatibility issues (5.2.x).
Nov 24 2016, 10:29 AM
alex committed rINP16454: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'in….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'in…
Nov 24 2016, 9:11 AM
alex committed rINP16455: Committing 'svn:externals' property to 'releases/5.2.2-B1' in 'in-portal'….
Committing 'svn:externals' property to 'releases/5.2.2-B1' in 'in-portal'…
Nov 24 2016, 9:10 AM
alex committed rTSIM16453: Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of….
Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of…
Nov 24 2016, 9:03 AM
alex committed rTDEF16452: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of…
Nov 24 2016, 9:00 AM
alex committed rTADV16451: Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of….
Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of…
Nov 24 2016, 8:45 AM
alex committed rMCUS16450: Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of….
Releasing version 'releases/1.2.2-B1' (copy from 'branches/1.2.x') of…
Nov 24 2016, 8:38 AM
alex committed rMCUS16449: Bug: INP-921 - Prepare 5.2.x releases.
Bug: INP-921 - Prepare 5.2.x releases
Nov 24 2016, 8:37 AM
alex committed rMINC16448: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'w/in….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of 'w/in…
Nov 24 2016, 8:34 AM
alex committed rMINC16447: Bug: INP-921 - Prepare 5.2.x releases.
Bug: INP-921 - Prepare 5.2.x releases
Nov 24 2016, 8:33 AM
alex committed rMINB16446: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of…
Nov 24 2016, 8:29 AM
alex committed rMINB16445: Bug: INP-921 - Prepare 5.2.x releases.
Bug: INP-921 - Prepare 5.2.x releases
Nov 24 2016, 8:26 AM
alex committed rMINN16444: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of…
Nov 24 2016, 8:22 AM
alex committed rMINN16443: Bug: INP-921 - Prepare 5.2.x releases.
Bug: INP-921 - Prepare 5.2.x releases
Nov 24 2016, 8:21 AM
alex committed rMINL16442: Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of….
Releasing version 'releases/5.2.2-B1' (copy from 'branches/5.2.x') of…
Nov 24 2016, 8:16 AM
alex committed rMINL16441: Bug: INP-921 - Prepare 5.2.x releases.
Bug: INP-921 - Prepare 5.2.x releases
Nov 24 2016, 8:15 AM
alex retitled D265: INP-1643 - Use relative paths in "my_document" CKEditor plugin from to INP-1643 - Use relative paths in "my_document" CKEditor plugin.
Nov 24 2016, 6:10 AM
erik requested changes to D256: INP-1325 - Perform intellectual cache update on category changes.

Detected bug, when one admin user opens to edit category1 with relatively big TreeLeft/TreeRight numbers. Then second admin user moves subtree, where category1 is a leaf to the zone of smaller TreeLeft/TreeTight numbers. Then, first user saves category1 and old, big TreeLeft/TreeRight numbers becomes saved to the zone of small TreeLeft/TreeRight numbers, breaking Treeleft BETWEEN A AND B logic.

Nov 24 2016, 5:37 AM · Restricted Project

Nov 22 2016

alex added a parent revision for D225: INP-1563 - Make "kApplication::QuickRun" method reusable: D106: INP-1457 - Clear template parser state before parsing "404 Not Found" template.
Nov 22 2016, 8:38 AM
alex added a child revision for D106: INP-1457 - Clear template parser state before parsing "404 Not Found" template: D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
Nov 22 2016, 8:38 AM · Restricted Project
erik accepted D255: INP-1593 - Auto-detect format of provided password in "kPasswordFormatter::hashPassword" method for migrated users.
Nov 22 2016, 7:43 AM · Restricted Project
erik accepted D257: INP-1594 - Generate/check category filename after page protection code was executed.
Nov 22 2016, 6:59 AM
alex added a comment to D259: INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.
In D259#5085, @erik wrote:

When editing inline block in adm.console, button "Remove Link" is not available, and this makes problematic to input non-linked text after some link is added to empty editor.

Nov 22 2016, 6:53 AM
alex updated the test plan for D259: INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.
Nov 22 2016, 6:50 AM
alex added a comment to D259: INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.
In D259#5085, @erik wrote:

When editing inline block in adm.console, button "Remove Link" is not available, and this makes problematic to input non-linked text after some link is added to empty editor.

Nov 22 2016, 6:40 AM
erik accepted D259: INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.

Mentioned above not a bug. Clearing editor area after each step helps to avoid link merging problem.

Nov 22 2016, 6:37 AM
erik requested changes to D259: INP-1630 - Actualize link injection code in "my_link" plugin of CKEditor.

When editing inline block in adm.console, button "Remove Link" is not available, and this makes problematic to input non-linked text after some link is added to empty editor.

Nov 22 2016, 6:28 AM
alex requested changes to D229: INP-1565 Add support for "relative" date format.
In D229#4319, @alex wrote:

And test plan still doesn't cover direct method usage of DateHelper class.

Nov 22 2016, 5:53 AM
erik accepted D261: INP-1502 - Gracefully handle case of missing file/line keys in stack trace info.
Nov 22 2016, 5:39 AM
erik accepted D262: INP-1640 - Use "current" function only on arrays in "kDBConnectionDebug::GetIterator" method.
Nov 22 2016, 5:35 AM
erik accepted D264: INP-1642 - Allow "kColumnPickerHelper" class to correctly reorder/resize multilingual columns.
Nov 22 2016, 5:23 AM
glebs updated the diff for D229: INP-1565 Add support for "relative" date format.

Requested fixes

Nov 22 2016, 5:14 AM

Nov 21 2016

erik added a comment to D256: INP-1325 - Perform intellectual cache update on category changes.

Today partially tested part of part 1. Only actions for leaf operation with enabled "Recycle Bin". No bugs found.

Nov 21 2016, 8:56 AM · Restricted Project
alex updated the test plan for D256: INP-1325 - Perform intellectual cache update on category changes.
Nov 21 2016, 4:09 AM · Restricted Project
alex updated the test plan for D256: INP-1325 - Perform intellectual cache update on category changes.
Nov 21 2016, 4:07 AM · Restricted Project
alex requested changes to D12: INP-1312 - Mark themes as deleted instead of actually deleting them.

Also test plan doesn't have regression testing part, where all changed code is invoked and confirmed, that it works as before (places where you now do Status = ThemeStatus::ACTIVE instead of Enabled = 1.

Nov 21 2016, 3:15 AM
alex accepted D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Nov 21 2016, 2:59 AM · Restricted Project

Nov 20 2016

alex requested changes to D243: INP-1571 Form field validation should account for array-like field values.

All length checking code was changed and therefore test plan must include testing of all existing behavior (regression testing), not just the part that was fixed. I guess you can create field declaration with all possible validation options and just confirm, that:

  • when array is passed in no validation error happens
  • when invalid scalar value (maybe several values needs to be used to match each of validation options) is passed the validation error happens
  • when valid scalar value (maybe several values needs to be used to match each of validation options) is passed no validation error happens
Nov 20 2016, 1:24 PM
alex requested changes to D260: INP-1592 - Allow specifying "robots" meta tag for pages.
Nov 20 2016, 1:14 PM
alex requested changes to D229: INP-1565 Add support for "relative" date format.
Nov 20 2016, 1:06 PM
alex updated the test plan for D229: INP-1565 Add support for "relative" date format.
Nov 20 2016, 1:06 PM
alex accepted D189: INP-1527 User's profile update via AJAX support.
Nov 20 2016, 12:21 PM · Restricted Project
alex updated the test plan for D189: INP-1527 User's profile update via AJAX support.
Nov 20 2016, 12:12 PM · Restricted Project
alex accepted D213: INP-1547 Create "promo-block:ImageField" tag.
Nov 20 2016, 11:59 AM · Restricted Project
alex updated the test plan for D213: INP-1547 Create "promo-block:ImageField" tag.
Nov 20 2016, 11:46 AM · Restricted Project
alex accepted D228: INP-1551 Add the "kDBList::GetSelectedCount" method and "SelectedRecords" tag using it.
Nov 20 2016, 6:01 AM
alex accepted D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 20 2016, 5:18 AM · Restricted Project
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 20 2016, 5:15 AM · Restricted Project
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 20 2016, 4:55 AM · Restricted Project
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 20 2016, 4:45 AM · Restricted Project
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 20 2016, 3:52 AM · Restricted Project
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 20 2016, 3:47 AM · Restricted Project
alex updated the test plan for D160: INP-1486 Don't give up, when single item update fails in "iterateItems" method.
Nov 20 2016, 3:37 AM · Restricted Project