Page MenuHomeIn-Portal Phabricator
Feed All Stories

May 30 2019

alex added a project to D366: INP-1769 - Truncate search result table instead of dropping it: Restricted Project.
May 30 2019, 8:09 AM · Restricted Project
alex requested review of D366: INP-1769 - Truncate search result table instead of dropping it.
May 30 2019, 8:08 AM · Restricted Project

May 27 2019

alex added a comment to D365: INP-1768 - Disable Load Balancing from CRON.
In D365#7225, @erik wrote:

Tested, working fine, but needs corrections in the test plan.

  1. Some additional table must be in the master DB, not in slave DB.
  2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:

    exit_code(1, 'This script needs to be enabled manually !');
May 27 2019, 7:27 AM · Restricted Project
alex updated the test plan for D365: INP-1768 - Disable Load Balancing from CRON.
May 27 2019, 7:26 AM · Restricted Project
erik accepted D365: INP-1768 - Disable Load Balancing from CRON.

Tested, working fine, but needs corrections in the test plan.

  1. Some additional table must be in the master DB, not in slave DB.
  2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:
May 27 2019, 5:48 AM · Restricted Project

May 23 2019

alex updated the test plan for D365: INP-1768 - Disable Load Balancing from CRON.
May 23 2019, 11:24 AM · Restricted Project
alex requested review of D365: INP-1768 - Disable Load Balancing from CRON.
May 23 2019, 11:13 AM · Restricted Project

May 21 2019

erik accepted D364: INP-1767 - Purge expired database cache entries.
May 21 2019, 5:57 AM · Restricted Project

May 17 2019

alex added a project to D364: INP-1767 - Purge expired database cache entries: Restricted Project.
May 17 2019, 8:37 AM · Restricted Project
alex requested review of D364: INP-1767 - Purge expired database cache entries.
May 17 2019, 8:36 AM · Restricted Project

May 13 2019

erik accepted D362: INP-1765 - Use table alias, when creating calculated fields for catalog items.
May 13 2019, 5:18 AM · Restricted Project
erik accepted D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 13 2019, 5:10 AM · Restricted Project

May 10 2019

alex updated the test plan for D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 10 2019, 6:14 AM · Restricted Project
alex requested review of D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 10 2019, 6:10 AM · Restricted Project

May 8 2019

alex added a project to D362: INP-1765 - Use table alias, when creating calculated fields for catalog items: Restricted Project.
May 8 2019, 12:26 PM · Restricted Project
alex requested review of D362: INP-1765 - Use table alias, when creating calculated fields for catalog items.
May 8 2019, 12:25 PM · Restricted Project

Apr 26 2019

erik requested changes to D361: INP-1764 - Set correct exit code, when exception happens in CLI.

Tested, in both cases got wrong code 255 (not 0 and not 1 )

Apr 26 2019, 7:17 AM · Restricted Project
alex added a project to D361: INP-1764 - Set correct exit code, when exception happens in CLI: Restricted Project.
Apr 26 2019, 3:04 AM · Restricted Project
alex requested review of D361: INP-1764 - Set correct exit code, when exception happens in CLI.
Apr 26 2019, 3:03 AM · Restricted Project

Apr 25 2019

erik accepted D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 9:15 AM · Restricted Project
alex added a comment to D359: INP-1762 - Destroy query object before logging.

Please retest all from scratch, because I've rewritten test plan.

Apr 25 2019, 8:18 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.

Sending latest changes (maybe nothing was changed), but just in case.

Apr 25 2019, 8:16 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 7:54 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 7:51 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 7:50 AM · Restricted Project
erik accepted D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 25 2019, 7:31 AM · Restricted Project
alex planned changes to D359: INP-1762 - Destroy query object before logging.

Changed the code. Need to update test plan.

Apr 25 2019, 7:25 AM · Restricted Project
erik added a comment to D359: INP-1762 - Destroy query object before logging.

Part 1 - general logging - tested. No issues found. Waiting for part 2 and part 3 of the test plan.

Apr 25 2019, 7:25 AM · Restricted Project
alex requested review of D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.

I haven't noticed, that even though this fix looks standalone it still results in a Fatal Error until fix from D359 is applied. I've updated test plan to reflect that.

Apr 25 2019, 7:18 AM · Restricted Project
alex updated the test plan for D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 25 2019, 7:17 AM · Restricted Project
erik requested changes to D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.

Happens fatal error in the line

Apr 25 2019, 7:02 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.

Fixed a typo.

Apr 25 2019, 6:22 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.

Introduce global flag, that allows to disable logging for slow queries for a block of sqls.

Apr 25 2019, 6:21 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 6:16 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.
  1. make sure, that SELECT queries used for slow query logging aren't counted towards total query count limit
  2. [bugfix] attemt to get non-debug database query iterator while in debug mode would result in an exception
Apr 25 2019, 2:41 AM · Restricted Project

Apr 23 2019

alex updated the test plan for D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 23 2019, 10:59 AM · Restricted Project
alex added a parent revision for D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method: D359: INP-1762 - Destroy query object before logging.
Apr 23 2019, 10:55 AM · Restricted Project
alex added a child revision for D359: INP-1762 - Destroy query object before logging: D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 23 2019, 10:55 AM · Restricted Project
alex added a project to D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method: Restricted Project.
Apr 23 2019, 10:55 AM · Restricted Project
alex requested review of D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 23 2019, 10:55 AM · Restricted Project

Apr 19 2019

alex added a project to D359: INP-1762 - Destroy query object before logging: Restricted Project.
Apr 19 2019, 10:42 AM · Restricted Project
alex requested review of D359: INP-1762 - Destroy query object before logging.
Apr 19 2019, 10:38 AM · Restricted Project

Mar 27 2019

alex added a project to D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution: Restricted Project.
Mar 27 2019, 2:58 PM · Restricted Project
erik accepted D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 27 2019, 5:55 AM · Restricted Project
erik accepted D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 27 2019, 5:16 AM · Restricted Project

Mar 25 2019

alex requested review of D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 25 2019, 11:38 AM · Restricted Project

Mar 21 2019

alex added a project to D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation: Restricted Project.
Mar 21 2019, 4:58 AM · Restricted Project
alex requested review of D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 21 2019, 4:58 AM · Restricted Project

Jan 23 2019

alex accepted D270: INP-1654 Handle resource type in System Log.
Jan 23 2019, 6:16 AM

Jan 11 2019

alex accepted D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 10:21 AM · Restricted Project
erik updated the diff for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

Added fallback to DB cache when Memcache is not available.

Jan 11 2019, 9:11 AM · Restricted Project
erik updated the test plan for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 9:06 AM · Restricted Project
alex requested changes to D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

I've found one use case, that wasn't covered by initial plan.

Jan 11 2019, 8:29 AM · Restricted Project
erik created D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 5:27 AM · Restricted Project

Dec 20 2018

alex accepted D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 20 2018, 2:58 AM · Restricted Project
alex updated the test plan for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 20 2018, 2:57 AM · Restricted Project

Dec 19 2018

Harbormaster failed remote builds in B913: Diff 890 for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation!
Dec 19 2018, 9:42 AM · Restricted Project
erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Changed SQL expression formatting

Dec 19 2018, 9:42 AM · Restricted Project
alex requested changes to D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 9:33 AM · Restricted Project
erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Improved SQL expression formatting, updated test plan.

Dec 19 2018, 8:04 AM · Restricted Project
erik updated the test plan for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 6:58 AM · Restricted Project
alex requested changes to D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 3:50 AM · Restricted Project

Dec 18 2018

erik created D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 18 2018, 10:39 AM · Restricted Project

Dec 9 2018

ci added a comment to rINP16637: Fixes INP-1758 - Support PHP_CodeSniffer 3.x.

Build #164 finished with FAILURE status: http://ci.in-portal.org/job/in-portal-52x/164/

Dec 9 2018, 6:36 AM
alex added "INP-1758" JIRA issue(s) to rINP16637: Fixes INP-1758 - Support PHP_CodeSniffer 3.x.
Dec 9 2018, 6:35 AM
alex committed rINP16637: Fixes INP-1758 - Support PHP_CodeSniffer 3.x.
Fixes INP-1758 - Support PHP_CodeSniffer 3.x
Dec 9 2018, 6:35 AM

Nov 16 2018

erik accepted D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 16 2018, 4:24 AM · Restricted Project

Nov 15 2018

alex updated the test plan for D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 15 2018, 2:06 PM · Restricted Project
alex requested review of D354: INP-1756 - Create "Security*" classes for security-related jobs.
  1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.
Nov 15 2018, 2:05 PM · Restricted Project
erik requested changes to D354: INP-1756 - Create "Security*" classes for security-related jobs.
  1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.
  2. After installation with PHP v.7.2 new "SecurityHmacKey" and "SecurityEncryptionKey" settings were added normally, but test.php resulting in exception: -
Nov 15 2018, 11:33 AM · Restricted Project
alex updated the test plan for D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 15 2018, 9:36 AM · Restricted Project
alex created D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 15 2018, 9:33 AM · Restricted Project

Nov 14 2018

erik accepted D340: INP-1741 - Vertically align grid icons.
Nov 14 2018, 4:14 AM · Restricted Project

Nov 13 2018

alex accepted D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 13 2018, 8:36 AM · Restricted Project
alex updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Nov 13 2018, 8:31 AM · Restricted Project
alex updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Removed test file.

Nov 13 2018, 8:03 AM · Restricted Project
alex updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Fixed API difference causing a notice (and non-working cache), when attempting to get several keys at once using get method.

Nov 13 2018, 8:01 AM · Restricted Project
alex added "INP-1744" JIRA issue(s) to rTSIM16636: Bug INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM
alex committed rTSIM16636: Bug INP-1744 - Make page content blocks searcheable.
Bug INP-1744 - Make page content blocks searcheable
Nov 13 2018, 3:38 AM
alex added "INP-1744" JIRA issue(s) to rTDEF16635: Bug INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM
alex committed rTDEF16635: Bug INP-1744 - Make page content blocks searcheable.
Bug INP-1744 - Make page content blocks searcheable
Nov 13 2018, 3:38 AM
alex committed rINP16634: Fixes INP-1744 - Make page content blocks searcheable.
Fixes INP-1744 - Make page content blocks searcheable
Nov 13 2018, 3:38 AM
alex added "INP-1744" JIRA issue(s) to rINP16634: Fixes INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM
alex closed D343: INP-1744 Make page content blocks searcheable by committing rINP16634: Fixes INP-1744 - Make page content blocks searcheable.
Nov 13 2018, 3:38 AM · Unknown Object (Project)
alex accepted D343: INP-1744 Make page content blocks searcheable.
Nov 13 2018, 3:23 AM · Unknown Object (Project)
alex updated the test plan for D343: INP-1744 Make page content blocks searcheable.
Nov 13 2018, 3:23 AM · Unknown Object (Project)

Nov 12 2018

alex added a comment to D340: INP-1741 - Vertically align grid icons.
In D340#7001, @erik wrote:
  1. When testing, I tried to add more rows to "Regional" grid, and, after 5-6 rows added by standard in-portal grid interface, i got errors.
Nov 12 2018, 6:01 AM · Restricted Project
alex requested review of D340: INP-1741 - Vertically align grid icons.

This must be perception issue with that specific icon and fact, that it has own transparent margins that aren't aligned. Below I've attached 2 images to demonstrate the issue:

Nov 12 2018, 5:58 AM · Restricted Project
alex updated the test plan for D340: INP-1741 - Vertically align grid icons.
Nov 12 2018, 5:54 AM · Restricted Project
erik requested changes to D340: INP-1741 - Vertically align grid icons.
  1. I do not understand where is improvement. I see, that before icon was 1 pixel over checkox. Now it is 1 pixel under checkbox, and I do not see any issue related to row count in "before" case
Nov 12 2018, 5:01 AM · Restricted Project
alex updated the diff for D343: INP-1744 Make page content blocks searcheable.
  1. Updated demo data of "default" and "simple" themes to make them searchable immediately after installation.
  2. Improved trimming logic, when combining content block data to end up in less trailing spaces.
  3. Fixed notice during search about missing PageContent field of categories.
Nov 12 2018, 3:49 AM · Unknown Object (Project)
alex added a project to D343: INP-1744 Make page content blocks searcheable: Unknown Object (Project).
Nov 12 2018, 3:41 AM · Unknown Object (Project)
alex updated the test plan for D343: INP-1744 Make page content blocks searcheable.
Nov 12 2018, 3:38 AM · Unknown Object (Project)

Nov 9 2018

glebs updated the diff for D353: INP-1755 Make images in Admin Console Retina-friendly.

Remove unneded changes from grid_blocks.tpl

Nov 9 2018, 6:06 AM
alex requested changes to D353: INP-1755 Make images in Admin Console Retina-friendly.
Nov 9 2018, 4:16 AM
alex requested review of D340: INP-1741 - Vertically align grid icons.
Nov 9 2018, 4:07 AM · Restricted Project
alex updated the diff for D340: INP-1741 - Vertically align grid icons.

Fixed Firefox icon alignment issues on large (>10 rows) grids

Nov 9 2018, 4:06 AM · Restricted Project

Nov 8 2018

glebs updated the diff for D353: INP-1755 Make images in Admin Console Retina-friendly.

Changes for all modules

Nov 8 2018, 9:44 AM
alex added a comment to D351: INP-1750 - Support PHP Memcached extension for caching.

Not reopening, but test plan have issues:

Nov 8 2018, 5:08 AM · Restricted Project
glebs created D353: INP-1755 Make images in Admin Console Retina-friendly.
Nov 8 2018, 4:34 AM