Page MenuHomeIn-Portal Phabricator
Feed All Stories

Mar 22 2023

erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Failed test "Testing internal caches expiration for DB cache" in the part "all other keys have an expiration of 25 days (with a few seconds margin) relative to the time they're set".

Mar 22 2023, 5:35 AM · Restricted Project

Mar 21 2023

erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Partially tested for Memcached. Failed test with $application->addCache('key_with_exp', 'v2', 3600);

Mar 21 2023, 1:56 PM · Restricted Project
alex added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.
In D443#8977, @erik wrote:

Testing internal caches expiration for Memcache
ITEM test [1 b; 0 s]
Failed condition "these keys have infinite expiration (the 1738250904 number might differ on your install)" - given "0 s" is not like some great integer like "1738250904"

some other keys, containing "master", found only with request

(sleep 1; echo "stats cachedump 3 0"; sleep 1; echo "quit";) | telnet localhost 11211 | grep 'master'
response:
ITEM site_serial:1766886194:1:master:cms_menu_serials [15 b; 0 s]
ITEM site_serial:1766886194:1:master:template_mapping_serials [23 b; 0 s]
ITEM site_serial:1766886194:1:master:last_cache_rebuild_serials [25 b; 0 s]
ITEM site_serial:1766886194:1:master:config_files_serials [19 b; 0 s]

keys have "_serials" at the end, so do not match keys from test plan
no other keys with "master" found with other requests

Mar 21 2023, 12:02 PM · Restricted Project
alex updated the diff for D443: INP-1838 - Set expiration limit for life-time cached keys.

Replicated MemcacheCacheHandler class updates to the MemcachedCacheHandler class.

Mar 21 2023, 11:56 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 21 2023, 11:53 AM · Restricted Project
alex added "INP-1750" JIRA issue(s) to rINP16753: Fixes INP-1750 - Support PHP Memcached extension for caching.
Mar 21 2023, 3:52 AM
alex committed rINP16753: Fixes INP-1750 - Support PHP Memcached extension for caching.
Fixes INP-1750 - Support PHP Memcached extension for caching
Mar 21 2023, 3:52 AM
alex closed D351: INP-1750 - Support PHP Memcached extension for caching.
Mar 21 2023, 3:51 AM · Restricted Project
alex accepted D351: INP-1750 - Support PHP Memcached extension for caching.
Mar 21 2023, 3:50 AM · Restricted Project

Mar 20 2023

erik requested changes to D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 20 2023, 9:38 AM · Restricted Project
erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Testing internal caches expiration for Memcache
ITEM test [1 b; 0 s]
Failed condition "these keys have infinite expiration (the 1738250904 number might differ on your install)" - given "0 s" is not like some great integer like "1738250904"

Mar 20 2023, 7:54 AM · Restricted Project
alex added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.
In D443#8969, @erik wrote:

Testing internal caches expiration for Memcache
ITEM site_serial:1766886194:1:master:last_cache_rebuild [68 b; 0 s]
Failed condition "these keys have infinite expiration (the 1738250904 number might differ on your install)" - given "0 s" is not like some great integer like "1738250904"

Mar 20 2023, 7:15 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 20 2023, 7:14 AM · Restricted Project
erik updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Done requested changes - returned fallback to FakeCacheHandler zero time parameterusage and comments.

Mar 20 2023, 6:28 AM · Restricted Project
erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Testing internal caches expiration for Memcache
ITEM site_serial:1766886194:1:master:last_cache_rebuild [68 b; 0 s]
Failed condition "these keys have infinite expiration (the 1738250904 number might differ on your install)" - given "0 s" is not like some great integer like "1738250904"

Mar 20 2023, 6:10 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 20 2023, 3:47 AM · Restricted Project
alex added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.
In D443#8964, @erik wrote:

Detected that after memcache restart, test setCache with $application->setCache('key_with_def_exp', 'v1');, is passed only when twice open index.php. First index.php opening does not set value.

Mar 20 2023, 3:41 AM · Restricted Project

Mar 17 2023

erik added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.

Detected that after memcache restart, test setCache with $application->setCache('key_with_def_exp', 'v1');, is passed only when twice open index.php. First index.php opening does not set value.

Mar 17 2023, 1:55 PM · Restricted Project
alex retitled D351: INP-1750 - Support PHP Memcached extension for caching from INP-1750 Support PHP Memcached extension for caching to INP-1750 - Support PHP Memcached extension for caching.
Mar 17 2023, 11:45 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 17 2023, 11:06 AM · Restricted Project
alex updated the diff for D443: INP-1838 - Set expiration limit for life-time cached keys.

Fixed ArgumentCountError exception on the System Configuration step during clean install on PHP 7.4.

Mar 17 2023, 11:04 AM · Restricted Project
alex added a parent revision for D443: INP-1838 - Set expiration limit for life-time cached keys: D351: INP-1750 - Support PHP Memcached extension for caching.
Mar 17 2023, 7:18 AM · Restricted Project
alex added a child revision for D351: INP-1750 - Support PHP Memcached extension for caching: D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 17 2023, 7:18 AM · Restricted Project
alex updated the diff for D443: INP-1838 - Set expiration limit for life-time cached keys.

Set infinite expiration for site serial key.

Mar 17 2023, 7:13 AM · Restricted Project
alex requested review of D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 17 2023, 7:11 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 17 2023, 7:10 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 17 2023, 6:43 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 17 2023, 6:15 AM · Restricted Project
alex requested changes to D351: INP-1750 - Support PHP Memcached extension for caching.
Mar 17 2023, 5:43 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 17 2023, 4:58 AM · Restricted Project

Mar 16 2023

alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 16 2023, 12:28 PM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 16 2023, 12:26 PM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 16 2023, 12:20 PM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 16 2023, 11:58 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Mar 16 2023, 10:34 AM · Restricted Project

Feb 23 2023

erik updated the diff for D351: INP-1750 - Support PHP Memcached extension for caching.

Renoved fallback logic, updated test plan.

Feb 23 2023, 4:45 AM · Restricted Project

Feb 22 2023

erik updated the test plan for D351: INP-1750 - Support PHP Memcached extension for caching.
Feb 22 2023, 5:02 AM · Restricted Project
alex added inline comments to D351: INP-1750 - Support PHP Memcached extension for caching.
Feb 22 2023, 4:07 AM · Restricted Project
alex added inline comments to D351: INP-1750 - Support PHP Memcached extension for caching.
Feb 22 2023, 4:02 AM · Restricted Project

Feb 16 2023

alex added a comment to D443: INP-1838 - Set expiration limit for life-time cached keys.
  1. write a test plan for:
    • memory cache testing
    • database cache testing
    • template cache testing (via cache_timeout tag parameter, m_Cache tag and similar stuff)
  2. store site serial with infinite expiration, because otherwise, it's expiration after 1 month will invalidate the whole cache
Feb 16 2023, 1:31 PM · Restricted Project
alex planned changes to D443: INP-1838 - Set expiration limit for life-time cached keys.
Feb 16 2023, 11:33 AM · Restricted Project
alex updated the test plan for D443: INP-1838 - Set expiration limit for life-time cached keys.
Feb 16 2023, 11:30 AM · Restricted Project
alex requested review of D443: INP-1838 - Set expiration limit for life-time cached keys.
Feb 16 2023, 11:23 AM · Restricted Project

Feb 13 2023

alex planned changes to D442: INP-1837 - Record code fragment in the System Log backtrace.
  1. attempts to extract code from the trace, that doesn't contain a file reference
  2. code of the source file/line isn't shown (because it's outside of a trace)
Feb 13 2023, 2:43 AM

Feb 10 2023

alex updated the diff for D442: INP-1837 - Record code fragment in the System Log backtrace.

Adding phrases.

Feb 10 2023, 6:41 AM
alex requested review of D442: INP-1837 - Record code fragment in the System Log backtrace.
Feb 10 2023, 6:39 AM

Feb 7 2023

erik accepted D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.
Feb 7 2023, 5:03 AM

Feb 6 2023

alex updated the diff for D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.

Fixed outdated phrase translation.

Feb 6 2023, 8:16 AM
alex updated the diff for D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.

Changed terminology

Feb 6 2023, 6:46 AM
alex updated the test plan for D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.
Feb 6 2023, 6:44 AM

Feb 3 2023

alex planned changes to D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.
Feb 3 2023, 11:01 AM
alex updated the test plan for D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.
Feb 3 2023, 11:00 AM
alex requested review of D440: INP-1569 - Create System Log record, when stale semaphore is discovered or hit.
Feb 3 2023, 10:57 AM
alex planned changes to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Need to:

  • finalize the plan for dead lock testing
  • may add test plan for reconnect testing
Feb 3 2023, 2:18 AM · Restricted Project
erik requested changes to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Tried test part 4. No messages in system log given. Maybe, because of START TRANSACTION SQL command. Transaction not committed, so no records created in DB.

Feb 3 2023, 1:46 AM · Restricted Project

Jan 29 2023

alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Jan 29 2023, 9:01 AM · Restricted Project

Jan 27 2023

alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Jan 27 2023, 4:28 AM · Restricted Project
alex updated the diff for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Bugfix: logging retry attempts reset retry counter resulting in indefinite retry attempts.

Jan 27 2023, 4:14 AM · Restricted Project
alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Jan 27 2023, 4:08 AM · Restricted Project
alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Jan 27 2023, 1:36 AM · Restricted Project

Jan 25 2023

alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Jan 25 2023, 5:04 AM · Restricted Project
alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Jan 25 2023, 5:02 AM · Restricted Project
alex added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
In D439#8859, @erik wrote:

@alex trouble in part3 1 G - cant't get "detailed lock retry info is shown in the system log".

Jan 25 2023, 5:00 AM · Restricted Project

Dec 5 2022

erik added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

On processing line with "Step 4." comment, i have lock much more then 50 seconds. Practically, it never ends. In case, when lock continue, in other debug window go to step 5 - lock ends, but no system log record about this lock created.

Dec 5 2022, 5:10 AM · Restricted Project

Dec 2 2022

alex added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
In D439#8859, @erik wrote:

@alex trouble in part3 1 G - cant't get "detailed lock retry info is shown in the system log".

Dec 2 2022, 2:30 PM · Restricted Project
erik added a comment to D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

@alex trouble in part3 1 G - cant't get "detailed lock retry info is shown in the system log".

Dec 2 2022, 12:42 PM · Restricted Project
alex updated the diff for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Send e-mail upon retry (for real).

Dec 2 2022, 12:22 PM · Restricted Project
alex updated the diff for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Send e-mail upon retry.

Dec 2 2022, 12:20 PM · Restricted Project
alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Dec 2 2022, 11:35 AM · Restricted Project
alex updated the diff for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.

Added an explanatory comments.

Dec 2 2022, 10:34 AM · Restricted Project
alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Dec 2 2022, 10:26 AM · Restricted Project
alex updated the test plan for D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Dec 2 2022, 10:24 AM · Restricted Project
alex requested review of D439: INP-1835 - Auto-retry database queries, that stumbled upon a lock/deadlock.
Dec 2 2022, 10:19 AM · Restricted Project

Nov 9 2022

alex added "INP-1818" JIRA issue(s) to rINP16752: Fixes INP-1818 - Reset cURL settings only upon connection closing.
Nov 9 2022, 9:56 AM
alex committed rINP16752: Fixes INP-1818 - Reset cURL settings only upon connection closing.
Fixes INP-1818 - Reset cURL settings only upon connection closing
Nov 9 2022, 9:56 AM
alex closed D422: INP-1818 - Reset cURL settings only upon connection closing.
Nov 9 2022, 9:56 AM
alex added "INP-1819" JIRA issue(s) to rINP16751: Fixes INP-1819 - Allow retrieving response headers after making the cURL request.
Nov 9 2022, 9:54 AM
alex committed rINP16751: Fixes INP-1819 - Allow retrieving response headers after making the cURL request.
Fixes INP-1819 - Allow retrieving response headers after making the cURL request
Nov 9 2022, 9:54 AM
alex closed D423: INP-1819 - Allow retrieving response headers after making the cURL request.
Nov 9 2022, 9:53 AM
alex closed D432: INP-1828 - Preserve engine type, when creating a temporary tables.
Nov 9 2022, 9:51 AM
alex committed rINP16750: Fixes INP-1830 - Clear incompletely configured e-mail on error.
Fixes INP-1830 - Clear incompletely configured e-mail on error
Nov 9 2022, 9:46 AM
alex added "INP-1830" JIRA issue(s) to rINP16750: Fixes INP-1830 - Clear incompletely configured e-mail on error.
Nov 9 2022, 9:46 AM
alex closed D434: INP-1830 - Clear incompletely configured e-mail on error.
Nov 9 2022, 9:46 AM · Restricted Project
alex added "INP-1728" JIRA issue(s) to rINP16749: Fixes INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead"….
Nov 9 2022, 9:43 AM
alex committed rINP16749: Fixes INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead"….
Fixes INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead"…
Nov 9 2022, 9:43 AM
alex closed D327: INP-1728 - Add dynamic LEFT JOINs using ENTER in "OnAfterConfigRead" events.
Nov 9 2022, 9:43 AM
alex added "INP-1713" JIRA issue(s) to rINP16748: Fixes INP-1713 - Separate login by email from login by username.
Nov 9 2022, 9:41 AM
alex committed rINP16748: Fixes INP-1713 - Separate login by email from login by username.
Fixes INP-1713 - Separate login by email from login by username
Nov 9 2022, 9:41 AM
alex added "INP-1657" JIRA issue(s) to rINP16747: Fixes INP-1657 - Reposition CMS page revision history dropdown automatically.
Nov 9 2022, 9:38 AM
alex committed rINP16747: Fixes INP-1657 - Reposition CMS page revision history dropdown automatically.
Fixes INP-1657 - Reposition CMS page revision history dropdown automatically
Nov 9 2022, 9:38 AM
alex closed D272: INP-1657 - Reposition CMS page revision history dropdown automatically.
Nov 9 2022, 9:38 AM
alex added "INP-1596" JIRA issue(s) to rINP16746: Fixes INP-1596 - Don't autoload object used in "OnSuggestValues" event.
Nov 9 2022, 9:36 AM
alex committed rINP16746: Fixes INP-1596 - Don't autoload object used in "OnSuggestValues" event.
Fixes INP-1596 - Don't autoload object used in "OnSuggestValues" event
Nov 9 2022, 9:36 AM
alex closed D279: INP-1596 - Don't autoload object used in "OnSuggestValues" event.
Nov 9 2022, 9:36 AM
alex committed rINP16745: Fixes INP-1410 - Change "adm_ListTabs" tag to respect value of section's….
Fixes INP-1410 - Change "adm_ListTabs" tag to respect value of section's…
Nov 9 2022, 9:28 AM
alex added "INP-1410" JIRA issue(s) to rINP16745: Fixes INP-1410 - Change "adm_ListTabs" tag to respect value of section's….
Nov 9 2022, 9:28 AM
alex closed D45: INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter.
Nov 9 2022, 9:28 AM · Restricted Project
alex added "INP-1472" JIRA issue(s) to rINP16744: Fixes INP-1472 - Don't escape HTML in category name in category list.
Nov 9 2022, 9:18 AM
alex committed rINP16744: Fixes INP-1472 - Don't escape HTML in category name in category list.
Fixes INP-1472 - Don't escape HTML in category name in category list
Nov 9 2022, 9:18 AM
alex closed D123: INP-1472 - Don't escape HTML in category name in category list.
Nov 9 2022, 9:18 AM · Restricted Project