Page MenuHomeIn-Portal Phabricator
Feed All Stories

Mar 21 2015

alex committed rINP16138: Fixes INP-1411 - Store empty value in form field as-as.
Fixes INP-1411 - Store empty value in form field as-as
Mar 21 2015, 6:02 AM
alex closed D46: INP-1411 - Store empty value in form field as-as by committing rINP16138: Fixes INP-1411 - Store empty value in form field as-as.
Mar 21 2015, 6:02 AM · Restricted Project
alex committed rMINC16137: Fixes MINC-114 - Cleanup IDs of saved orders before adding/editing new orders.
Fixes MINC-114 - Cleanup IDs of saved orders before adding/editing new orders
Mar 21 2015, 5:59 AM
alex closed D44: MINC-114 - Cleanup IDs of saved orders before adding/editing new orders by committing rMINC16137: Fixes MINC-114 - Cleanup IDs of saved orders before adding/editing new orders.
Mar 21 2015, 5:59 AM · Restricted Project
alex committed rMINC16136: Fixes MINC-117 - Reset backorder flag on orderitems.
Fixes MINC-117 - Reset backorder flag on orderitems
Mar 21 2015, 5:54 AM
alex closed D47: MINC-117 - Update Backorder Flag, when reserving products in the order by committing rMINC16136: Fixes MINC-117 - Reset backorder flag on orderitems.
Mar 21 2015, 5:54 AM · Restricted Project
alex retitled D52: INP-1414 - Remove "perm_prefix" processing code duplication in "perm" unit from to INP-1414 - Remove "perm_prefix" processing code duplication in "perm" unit.
Mar 21 2015, 5:06 AM

Mar 20 2015

alex updated the diff for D51: MINC-119 - Reset more fields during cloning.

Removed assignment by reference (=&), that was introduced in previous patch.

Mar 20 2015, 10:03 AM · Restricted Project
alex retitled D51: MINC-119 - Reset more fields during cloning from to MINC-119 - Reset more fields during cloning.
Mar 20 2015, 10:01 AM · Restricted Project

Mar 19 2015

alex retitled D50: INP-1413 - Don't do full Application Init during deployment from to INP-1413 - Don't do full Application Init during deployment.
Mar 19 2015, 9:18 AM · Restricted Project
alex accepted D10: INP-1315 - Reset cached sorting on sorting configuration change.
Mar 19 2015, 6:28 AM
erik updated the diff for D10: INP-1315 - Reset cached sorting on sorting configuration change.

CS fixes

Mar 19 2015, 5:55 AM
erik updated the test plan for D10: INP-1315 - Reset cached sorting on sorting configuration change.
Mar 19 2015, 5:38 AM
glebs accepted D49: INP-1412 - Always create extra priority for temp-only DB records.
Mar 19 2015, 2:16 AM

Mar 18 2015

alex accepted D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products.
Mar 18 2015, 5:48 AM
erik updated the diff for D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products.

Changed grid configuration to use icons from core module.

Mar 18 2015, 5:31 AM
erik updated the test plan for D18: MINC-111 - Fix broken primary pricing icon for Subscription Type products.
Mar 18 2015, 5:30 AM

Mar 12 2015

alex set the repository for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages to rINP In-Portal.
Mar 12 2015, 6:56 AM
alex added a comment to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.

The http://qa.in-portal.org/D8?id=120 diff was created using wrong command arc diff --update D8 instead of arc diff --update D8 --cl and that's why it doesn't contain any relevant changes.

Mar 12 2015, 6:51 AM
alex retitled D49: INP-1412 - Always create extra priority for temp-only DB records from to INP-1412 - Always create extra priority for temp-only DB records.
Mar 12 2015, 6:28 AM
erik updated the diff for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Mar 12 2015, 6:00 AM
erik updated the diff for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.

Fixes.
Used more proper methods for escape/unescape request values.
Fiх to search logic, to allow keywords in URL without full search results recalculation.

Mar 12 2015, 5:55 AM
alex updated the test plan for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Mar 12 2015, 5:31 AM
erik updated the test plan for D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Mar 12 2015, 5:20 AM
glebs accepted D48: MINC-118 - Fix notices on Shipping/Billing tab of order in "To Ship" status.
Mar 12 2015, 3:13 AM
glebs accepted D46: INP-1411 - Store empty value in form field as-as.
Mar 12 2015, 3:12 AM · Restricted Project
glebs accepted D47: MINC-117 - Update Backorder Flag, when reserving products in the order.
Mar 12 2015, 3:09 AM · Restricted Project

Mar 11 2015

alex added inline comments to D48: MINC-118 - Fix notices on Shipping/Billing tab of order in "To Ship" status.
Mar 11 2015, 1:40 PM
alex retitled D48: MINC-118 - Fix notices on Shipping/Billing tab of order in "To Ship" status from to MINC-118 - Notices on Shipping/Billing tab of order in "To Ship" status.
Mar 11 2015, 1:39 PM
alex updated the test plan for D46: INP-1411 - Store empty value in form field as-as.
Mar 11 2015, 12:51 PM · Restricted Project
alex updated the test plan for D46: INP-1411 - Store empty value in form field as-as.
Mar 11 2015, 12:50 PM · Restricted Project
alex requested review of D46: INP-1411 - Store empty value in form field as-as.
Mar 11 2015, 12:47 PM · Restricted Project
alex updated the diff for D46: INP-1411 - Store empty value in form field as-as.

Now numeric fields (int, float, double) won't have 0 stored in database, when an empty string value is submitted from the form.

Mar 11 2015, 12:47 PM · Restricted Project
alex planned changes to D46: INP-1411 - Store empty value in form field as-as.

Turns out this have negative side effect for numeric fields, where empty string is converted to 0 in database.

Mar 11 2015, 12:40 PM · Restricted Project
alex added inline comments to D47: MINC-117 - Update Backorder Flag, when reserving products in the order.
Mar 11 2015, 11:36 AM · Restricted Project
alex retitled D47: MINC-117 - Update Backorder Flag, when reserving products in the order from to MINC-117 - Reset backorder flag on orderitems.
Mar 11 2015, 11:34 AM · Restricted Project

Mar 10 2015

alex committed rINP16135: Fixes INP-1407 - Move Arcanist linter options to new location.
Fixes INP-1407 - Move Arcanist linter options to new location
Mar 10 2015, 6:33 AM
alex closed D41: INP-1407 - Move Arcanist linter options to new location by committing rINP16135: Fixes INP-1407 - Move Arcanist linter options to new location.
Mar 10 2015, 6:33 AM
alex added inline comments to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Mar 10 2015, 5:10 AM
erik added inline comments to D8: INP-1375 - Ensure "keywords" URL parameter is present on all search related pages.
Mar 10 2015, 5:05 AM
glebs accepted D42: INP-1408 - Perform search, when ENTER used in "grid_like_combo_filter" block (the AJAXDropdown).
Mar 10 2015, 2:51 AM · Restricted Project
glebs accepted D41: INP-1407 - Move Arcanist linter options to new location.
Mar 10 2015, 2:42 AM
glebs accepted D40: INP-1406 - Change odd/even row color in SimpleGrid via jQuery.
Mar 10 2015, 2:38 AM · Restricted Project

Mar 9 2015

glebs accepted D46: INP-1411 - Store empty value in form field as-as.
Mar 9 2015, 7:38 AM · Restricted Project
alex retitled D46: INP-1411 - Store empty value in form field as-as from to INP-1411 - Store empty value in form field as-as.
Mar 9 2015, 7:27 AM · Restricted Project
glebs accepted D37: INP-1401 - Don't use "die" in Debugger.
Mar 9 2015, 2:13 AM

Mar 6 2015

alex accepted D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.
Mar 6 2015, 4:01 AM
glebs updated the diff for D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.

Rename hooks and fix example hook

Mar 6 2015, 3:57 AM
glebs updated the test plan for D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.
Mar 6 2015, 3:56 AM

Mar 3 2015

alex updated the test plan for D45: INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter.
Mar 3 2015, 3:19 AM · Restricted Project
glebs accepted D44: MINC-114 - Cleanup IDs of saved orders before adding/editing new orders.
Mar 3 2015, 3:17 AM · Restricted Project
alex updated the test plan for D45: INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter.
Mar 3 2015, 3:17 AM · Restricted Project
glebs retitled D45: INP-1410 - Change "adm_ListTabs" tag to respect value of section's "show_mode" parameter from to INP-1410 - show_mode section parameter doesn't affect tabs.
Mar 3 2015, 3:11 AM · Restricted Project

Mar 2 2015

alex retitled D44: MINC-114 - Cleanup IDs of saved orders before adding/editing new orders from to MINC-114 - Cleanup IDs of saved orders before adding/editing new orders.
Mar 2 2015, 11:13 AM · Restricted Project

Feb 25 2015

glebs accepted D39: INP-1403 - Trim long argument values in trace.
Feb 25 2015, 3:45 AM
glebs accepted D38: INP-1402 - Use "call_user_func" in System Log.
Feb 25 2015, 3:36 AM

Feb 24 2015

glebs accepted D36: INP-1400 - Store resized images from theme under /system folder.
Feb 24 2015, 2:07 AM · Restricted Project

Feb 22 2015

alex requested changes to D10: INP-1315 - Reset cached sorting on sorting configuration change.

Code works, but it doesn't comply to coding standards.

Feb 22 2015, 3:15 PM
alex requested changes to D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.

Example hook in modules/custom/units/sections/sections_config.php file, that is currently commented out, still uses hAFTER.

Feb 22 2015, 3:01 PM
alex committed rMINC16134: Fixes MINC-110 - Add Addresses tab to user editing form by name, not index.
Fixes MINC-110 - Add Addresses tab to user editing form by name, not index
Feb 22 2015, 2:44 PM
alex updated the diff for D41: INP-1407 - Move Arcanist linter options to new location.

Solve merge conflicts after D33 merge

Feb 22 2015, 10:21 AM
alex retitled D23: INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE from INP-1369 - Transform all hooks to u::OnAfterConfigRead event into hBEFORE to INP-1369 - Transform all hooks to "OnAfterConfigRead" event into hBEFORE.
Feb 22 2015, 9:12 AM
alex committed rMINC16133: Fixes MINC-112 - Remove the SSN field.
Fixes MINC-112 - Remove the SSN field
Feb 22 2015, 9:08 AM
alex committed rTADV16132: Bug MINC-112 - Remove the SSN field.
Bug MINC-112 - Remove the SSN field
Feb 22 2015, 9:07 AM
alex closed D26: MINC-112 - Remove the SSN field by committing rTADV16132: Bug MINC-112 - Remove the SSN field.
Feb 22 2015, 9:07 AM · Restricted Project
alex committed rINP16131: Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper….
Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper…
Feb 22 2015, 8:50 AM
alex closed D19: INP-1389 - Remove hardcoded empty option in "CountryStatesHelper::PopulateStates" method by committing rINP16131: Fixes INP-1389 - The hardcoded empty option in "CountryStatesHelper….
Feb 22 2015, 8:50 AM
alex committed rINP16130: Fixes INP-1397 - Validate PHP syntax during linting.
Fixes INP-1397 - Validate PHP syntax during linting
Feb 22 2015, 7:44 AM
alex closed D33: INP-1397 - Validate PHP syntax during linting by committing rINP16130: Fixes INP-1397 - Validate PHP syntax during linting.
Feb 22 2015, 7:44 AM
alex committed rINP16129: Fixes INP-1399 - Use relative paths during hash calculations.
Fixes INP-1399 - Use relative paths during hash calculations
Feb 22 2015, 7:37 AM
alex closed D35: INP-1399 - Use relative paths during hash calculations by committing rINP16129: Fixes INP-1399 - Use relative paths during hash calculations.
Feb 22 2015, 7:37 AM · Restricted Project

Feb 20 2015

alex accepted D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only.
Feb 20 2015, 10:38 AM · Restricted Project
glebs updated the diff for D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only.

Change weight, applied to search by one word

Feb 20 2015, 10:30 AM · Restricted Project
alex added inline comments to D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only.
Feb 20 2015, 10:10 AM · Restricted Project
alex requested changes to D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only.

Need to think about what are pros/cons of each approach described as inline comment below.

Feb 20 2015, 7:40 AM · Restricted Project
glebs retitled D43: INP-1409 - Don't calculate search relevance twice, when searching for one word only from to INP-1409 Double weight in search relevance calculation.
Feb 20 2015, 6:39 AM · Restricted Project

Feb 11 2015

alex retitled D42: INP-1408 - Perform search, when ENTER used in "grid_like_combo_filter" block (the AJAXDropdown) from to INP-1408 - The "grid_like_combo_filter" doesn't trigger search on ENTER press.
Feb 11 2015, 11:36 AM · Restricted Project

Feb 6 2015

alex retitled D41: INP-1407 - Move Arcanist linter options to new location from to INP-1407 - Move Arcanist linter options to new location.
Feb 6 2015, 4:00 PM

Jan 30 2015

alex retitled D40: INP-1406 - Change odd/even row color in SimpleGrid via jQuery from to INP-1406 - Change odd/even row color in SimpleGrid via jQuery.
Jan 30 2015, 9:17 AM · Restricted Project

Jan 26 2015

glebs accepted D35: INP-1399 - Use relative paths during hash calculations.
Jan 26 2015, 2:56 AM · Restricted Project

Jan 23 2015

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 23 2015, 8:04 AM · Restricted Project
glebs accepted D34: INP-1398 - Add support for "result_to_var" parameter in "m_RenderElement" tag.
Jan 23 2015, 3:02 AM

Jan 22 2015

glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

Fix error templates

Jan 22 2015, 2:54 AM · Restricted Project

Jan 20 2015

alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 4:16 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 4:08 AM · Restricted Project
alex requested changes to D3: INP-1381 - Create special template for fatal error page.

The translation of new setting is missing:

Jan 20 2015, 3:56 AM · Restricted Project
alex added inline comments to D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 3:25 AM · Restricted Project
glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 3:22 AM · Restricted Project
glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.
Jan 20 2015, 3:15 AM · Restricted Project
alex requested changes to D3: INP-1381 - Create special template for fatal error page.

Just this one minor fix and we're done I guess.

Jan 20 2015, 3:10 AM · Restricted Project
glebs accepted D33: INP-1397 - Validate PHP syntax during linting.
Jan 20 2015, 3:00 AM
glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

fixes from http://qa.in-portal.org/D3#627

Jan 20 2015, 2:47 AM · Restricted Project

Jan 19 2015

alex retitled D39: INP-1403 - Trim long argument values in trace from to INP-1403 - Trim long argument values in trace.
Jan 19 2015, 10:39 AM
glebs accepted D27: MINC-113 - Use mod-rewrite for Affiliate links.
Jan 19 2015, 2:20 AM · Restricted Project

Jan 16 2015

alex requested changes to D3: INP-1381 - Create special template for fatal error page.

Almost there. Still I think following can be improved.

Jan 16 2015, 8:31 AM · Restricted Project
glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

QA fixes

Jan 16 2015, 6:29 AM · Restricted Project
glebs updated the diff for D3: INP-1381 - Create special template for fatal error page.

QA fixes

Jan 16 2015, 4:41 AM · Restricted Project
alex retitled D38: INP-1402 - Use "call_user_func" in System Log from to INP-1402 - Use "call_user_func" in System Log.
Jan 16 2015, 4:26 AM
alex added a comment to D37: INP-1401 - Don't use "die" in Debugger.

This will also solve problem in D3, where with enabled debugger System Log never logs fatal error about non-existing object method call.

Jan 16 2015, 3:56 AM
alex retitled D37: INP-1401 - Don't use "die" in Debugger from to INP-1401 - Don't use "die" in Debugger.
Jan 16 2015, 3:53 AM