Differential D50

INP-1413 - Don't do full Application Init during deployment
ClosedPublic
Actions

Authored by alex on Mar 19 2015, 9:18 AM.

Details

Reviewers

glebs

Commits

rINP16245: Fixes INP-1413 - Don't do full Application Init during deployment

Test Plan

NOTE: Use PHP 5.4+ during this test

Preparations:

don't apply patch yet
open the Tools → System Tools section in Admin Console in one tab
open homepage in other tab and confirm, that no error happens
create an empty trait (in separate file) in the /core/units/users/ folder
register trait in RegisterClasses array in users_config.php (don't rebuild any caches yet)
use trait in the UsersEventHandler class
reload tab with homepage and confirm, that now Fatal Error (related to missing trait) is shown in debugger

Actual test:

press Deploy button in Tools → System Tools section in Admin Console and confirm, that now Fatal Error (related to missing trait) is shown in debugger
run do_update script on In-Portal folder and confirm that it ends up with same Fatal Error
apply patch
run do_update script and confirm, that no error happens and homepage can be opened after that
rewind the test to get fatal error again
press Deploy button in Tools → System Tools section in Admin Console and confirm, that no error happens and homepage can be opened after that

Diff Detail

Repository

rINP In-Portal

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 125.Mar 19 2015, 9:18 AM

alex retitled this revision from to INP-1413 - Don't do full Application Init during deployment.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1413.

Herald added a reviewer: glebs. · View Herald TranscriptMar 19 2015, 9:18 AM

glebs accepted this revision.Mar 25 2015, 3:55 AM

glebs edited edge metadata.

This revision is now accepted and ready to land.Mar 25 2015, 3:55 AM

alex added a child revision: D68: INP-1422 - Store class map on disk.Apr 26 2015, 11:17 AM

I've looked deeply at what the adm:OnStartup even really is and what hooks to it do and it can be summarized into: create cookies/session variables based on request/other cookies.

No request or cookies exists in CLI, so we can automatically skip it in there.

core/kernel/application.php
384 ↗	(On Diff #125)	Use `PHP_SAPI !== 'cli'` instead of `1` to prevent `adm:OnStartup` event from executing while in command line.
tools/run_event.php
39–42 ↗	(On Diff #125)	Delete.

alex added inline comments.Apr 27 2015, 6:17 AM

core/kernel/application.php
384 ↗	(On Diff #125)	In fact we can replace that IF with following and remove all other changes in this diff: if ( PHP_SAPI !== 'cli' && !$this->isAdmin ) {

Run the adm:OnStartup event only, when Front-End is used from browser

After successful testing please also:

revert rATV16895 and rATV16896
apply this new patch there
test that all works (e.g. adding new trait to EUserEventHandler won't break deploy on another machine

glebs accepted this revision.Apr 29 2015, 12:57 PM

glebs edited edge metadata.

This revision is now accepted and ready to land.Apr 29 2015, 12:57 PM

Closed by commit rINP16245: Fixes INP-1413 - Don't do full Application Init during deployment (authored by alex). · Explain WhySep 2 2015, 3:34 PM

This revision was automatically updated to reflect the committed changes.

alex added a child revision: D180: INP-1516 - Do not use "Web Request" and "Session" concepts in CLI.Dec 6 2015, 8:36 AM

alex edited edge metadata.Mar 10 2016, 6:47 AM

alex added a project: Restricted Project.

Revision Contents
Changeset List

			Path	Packages
M			branches/5.2.x/core/kernel/application.php (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	125	16128		Mar 19 2015, 9:18 AM	★	★
Diff 2	166	16155	Run the `adm:OnStartup` event only, when Front-End is used from browser	Apr 27 2015, 3:05 PM	★	★
Diff 3	291	16243	Commit rINP16245	Sep 2 2015, 3:34 PM	★	★

Status	Author	Revision
Closed	alex	D17 INP-1388 - Make CKEditor stylesheet within theme editable
Closed	alex	D68 INP-1422 - Store class map on disk
Closed	alex	D62 INP-1424 Don't call "refreshModuleInfo" twice in a row
Closed	alex	D64 INP-1426 Speed up admin tree cache building
Changes Planned	alex	D180 INP-1516 - Do not use "Web Request" and "Session" concepts in CLI
Closed	alex	D50 INP-1413 - Don't do full Application Init during deployment
Closed	alex	D174 INP-1520 - Honor manually set owner of categories/category items created from CLI
Closed	alex	D175 INP-1521 - Don't expose InitList and PrintList tag communication to Web Request
Closed	alex	D179 INP-1523 - Populate user info, when sending membership expiration e-mails
Closed	alex	D176 MINL-18 - Change link categories automatically according to it's Listing Type
Closed	alex	D173 MINN-11 - Specify category for RSS feed articles via "CategoryId" field
Closed	alex	D169 INP-1517 - Define INDEX_FILE constant in each CLI script
Closed	alex	D170 INP-1518 - Remove excessive owner detection code from "cacheItemOwner" method
Closed	alex	D172 MINN-10 - Don't use Web Request during Article adding/editing
Closed	alex	D207 INP-1543 - Return detected theme/language ID immediately from "getPassedID" method
Closed	alex	D16 INP-1387 - Move primary theme/language detection into corresponding units
Closed	alex	D208 INP-1544 - Delete expired session without using "Session" object
Closed	alex	D212 MINB-26 - Don't persist data for anonymous users
Closed	alex	D282 INP-1665 - Add/use "kApplication::permissionCheckingDisabled" method

Diff 291

View Options

branches/5.2.x/core/kernel/application.php

INP-1413 - Don't do full Application Init during deploymentClosedPublicActions