Made requested changes
- Queries
- All Stories
- Search
- Advanced Search
All Stories
Nov 27 2015
Nov 19 2015
Nov 18 2015
Nov 17 2015
Removed excessive line, improved test plan before this revision
The test plan wasn't changed as requested.
Nov 16 2015
Removed Clear() calls, added in the previous version of revision.
... added Clear() calls to fit new plan.
Nov 14 2015
Just send revision for review somehow without making any code changes.
Nov 13 2015
The test plan:
- doesn't include steps for testing clean install/upgrade
- doesn't work (I've tried to do as written in test plan and problem is still there)
Nov 11 2015
Fixed SQL code indent
Code tested according to plan. Please do that last cosmetical change and we're done here.
Nov 10 2015
Removed new helper, made inline code with count() in cycle conditions
Changed test plan, added Clear() calls to fit new plan.
Please thoroughly look through each comment I leave (every time on every revision). If you decide not to do as I've advised, then please explain why as a reply to relevant comment.
- add temporary line "$event->status = kEvent::erFAIL;" to CategoriesEventHandler::OnBeforeItemUpdate
- confirm that Approve and Decline buttons do not change Status for categories, but also no fatal error happens
- remove temporary line "$event->status = kEvent::erFAIL;" from CategoriesEventHandler::OnBeforeItemUpdate
Nov 9 2015
Made requested code formatting
The test plan seems to out of sync with reality this time as well.
Made requested changes for code optimization
Aside from inline comments following needs to be fixed in the test plan as well:
Removed excessive code from shipping_quote_engine_event_handler.php
Nov 6 2015
Please re-test.
Selecting Structure & Data category wasn't causing tab auto-switching.
The Sections tab isn't activated when topmost section (the Structure & Data) is clicked.
Nov 5 2015
Removed excessive IncludeFieldTitles checkbox.
Moved configuration fields ro requested places
Used getSearchTable method in additional places
Also test plan doesn't cover code path, that caused search table removal in past (e.g. make search that finds something and then make search with short/empty keyword).
- test plan is missing tests, that demonstrate, that problem, described in Confluence, no longer happen under same conditions
- please remove ShippingQuoteEngineEventHandler::iterateItems method because the only thing it does it rolling back event status change, that no longer happens in parent class method
Nov 4 2015
Nov 3 2015
Made required fixes
Nov 2 2015
Oct 30 2015
Oct 29 2015
Oct 28 2015
Oct 27 2015
Oct 26 2015
Applued additional patch, made other requested changes.
Build #39 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/39/
Oct 25 2015
Links placed in Home category weren't shown on Front-End even with all permissions given.
Build #38 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/38/