Page MenuHomeIn-Portal Phabricator
Feed All Stories

May 20 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 20 2016, 4:57 AM

May 19 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 19 2016, 4:55 AM
erik added inline comments to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 19 2016, 4:54 AM
alex requested changes to D226: INP-1552 Import language pack without overwrite on separate module install.

Right now, when installing In-Portal with modules in one go no language pack overwrite happened.

May 19 2016, 4:14 AM
alex updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 19 2016, 4:06 AM
alex updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 19 2016, 4:04 AM
alex updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 19 2016, 4:04 AM
glebs updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 19 2016, 3:01 AM
glebs updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 19 2016, 3:01 AM
glebs updated the test plan for D226: INP-1552 Import language pack without overwrite on separate module install.
May 19 2016, 3:01 AM
glebs retitled D226: INP-1552 Import language pack without overwrite on separate module install from to INP-1552 Import language pack without overwrite on separate module install.
May 19 2016, 3:00 AM

May 17 2016

erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 17 2016, 4:56 AM
glebs accepted D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
May 17 2016, 2:43 AM
alex added a comment to D222: INP-1327 Simplify custom permission checking in Event Handler.

Since permission system is affected please also include tests that would demonstrate, that if user has needed permissions no redirect happens and whatever should happen (upon user taking action) will happen.

May 17 2016, 2:41 AM

May 16 2016

alex requested review of D225: INP-1563 - Make "kApplication::QuickRun" method reusable.

Please do a complete retest.

May 16 2016, 8:32 AM
alex updated the test plan for D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
May 16 2016, 8:31 AM
alex updated the test plan for D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
May 16 2016, 8:31 AM
alex updated the diff for D225: INP-1563 - Make "kApplication::QuickRun" method reusable.

Fixed case, when passed request variable wasn't reset, when Page Not Found page was shown.

May 16 2016, 8:27 AM
alex planned changes to D225: INP-1563 - Make "kApplication::QuickRun" method reusable.

The passed request variable isn't reset, when showing Page Not Found page, which results in links using pass="all" using prefixes from url.

May 16 2016, 8:25 AM
erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 16 2016, 5:12 AM
erik added inline comments to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 16 2016, 5:11 AM

May 13 2016

glebs accepted D225: INP-1563 - Make "kApplication::QuickRun" method reusable.
May 13 2016, 2:19 AM
glebs accepted D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
May 13 2016, 1:48 AM

May 12 2016

alex retitled D225: INP-1563 - Make "kApplication::QuickRun" method reusable from to INP-1563 - Make "kApplication::QuickRun" method reusable.
May 12 2016, 3:25 PM
alex updated the test plan for D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
May 12 2016, 2:23 PM
alex updated the test plan for D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
May 12 2016, 2:22 PM
alex updated the test plan for D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
May 12 2016, 2:21 PM
alex retitled D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag from to INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
May 12 2016, 2:12 PM
erik retitled D223: INP-1447 Remove usage of 'name' parameter in "kDBTagProcessor::GetList" method from to TADV-40 Use "list_name" instead of "name" parameter when dealing with lists.
May 12 2016, 5:17 AM

May 11 2016

alex added a comment to D222: INP-1327 Simplify custom permission checking in Event Handler.

To help you out I've pointed out places that should trigger all code paths not covered by test plan. You still need to very that it all works like this and write step-by-step test plan to execute changed code of course.

May 11 2016, 5:49 AM
alex requested changes to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 11 2016, 5:19 AM
erik updated the test plan for D222: INP-1327 Simplify custom permission checking in Event Handler.
May 11 2016, 4:49 AM
erik updated the diff for D222: INP-1327 Simplify custom permission checking in Event Handler.

Patch transformed to 5.2.x version.

May 11 2016, 4:47 AM

May 5 2016

alex added a comment to D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class.

Adding comment to trigger automatic link creation between Phabricator and JIRA (was broken after last upgrade of Phabricator).

May 5 2016, 6:24 AM · Restricted Project
alex added a comment to D221: INP-1561 Don't share Admin Console Menu Width across users.

Adding comment to trigger automatic link creation between Phabricator and JIRA (was broken after last upgrade of Phabricator).

May 5 2016, 6:23 AM
alex added a comment to D222: INP-1327 Simplify custom permission checking in Event Handler.

Adding comment to trigger automatic link creation between Phabricator and JIRA (was broken after last upgrade of Phabricator).

May 5 2016, 6:22 AM
alex added a comment to D222: INP-1327 Simplify custom permission checking in Event Handler.

Actually please create this patch against 5.2.x branch. The changes doesn't look as breaking ones and 5.2.x developers would be happy.

May 5 2016, 5:56 AM
alex added inline comments to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 5 2016, 4:15 AM
erik added inline comments to D222: INP-1327 Simplify custom permission checking in Event Handler.
May 5 2016, 4:08 AM

May 4 2016

glebs accepted D217: INP-1554 - Allow searching category items by meta fields.
May 4 2016, 1:38 AM
glebs accepted D215: INP-1549 - Perform search, when ENTER used in "grid_like_combo_filter" block (the jQueryUI.Autocomplete).
May 4 2016, 12:58 AM

May 3 2016

alex requested changes to D222: INP-1327 Simplify custom permission checking in Event Handler.

Test plan should also include scenarios for testing each changed code fragment (e.g. where finalizePermissionCheck was called, but is no more) to demonstrate that in case of permission violation proper No Permission page is displayed.

May 3 2016, 4:38 AM
erik retitled D222: INP-1327 Simplify custom permission checking in Event Handler from to INP-1327 Simplified custom permission checking in Event Handler.
May 3 2016, 4:17 AM
glebs accepted D212: MINB-26 - Don't persist data for anonymous users.
May 3 2016, 2:29 AM

Apr 28 2016

alex accepted D221: INP-1561 Don't share Admin Console Menu Width across users.
Apr 28 2016, 5:00 AM
alex updated the test plan for D221: INP-1561 Don't share Admin Console Menu Width across users.
Apr 28 2016, 5:00 AM
glebs updated the test plan for D221: INP-1561 Don't share Admin Console Menu Width across users.
Apr 28 2016, 4:52 AM
glebs updated the test plan for D221: INP-1561 Don't share Admin Console Menu Width across users.
Apr 28 2016, 4:52 AM
glebs updated the test plan for D221: INP-1561 Don't share Admin Console Menu Width across users.
Apr 28 2016, 4:44 AM
glebs retitled D221: INP-1561 Don't share Admin Console Menu Width across users from to INP-1561 Don't share Admin Console Menu Width across users.
Apr 28 2016, 4:28 AM
glebs accepted D211: MINB-25 - Declare forum user preferences in the "user-profile" unit.
Apr 28 2016, 1:25 AM

Apr 26 2016

glebs accepted D210: INP-1546 - Make "user-profile:Field" tag support fields of any type.
Apr 26 2016, 3:02 AM
glebs accepted D209: INP-1545 - Enable SQL syntax highlight in "Tools > Query Database" section.
Apr 26 2016, 2:51 AM

Apr 19 2016

glebs accepted D208: INP-1544 - Delete expired session without using "Session" object.
Apr 19 2016, 2:09 AM
glebs accepted D207: INP-1543 - Return detected theme/language ID immediately from "getPassedID" method.
Apr 19 2016, 2:07 AM
glebs accepted D205: INP-1542 - Add "Export" button to "Show All" grid in "Website & Content > Structure & Data" section.
Apr 19 2016, 2:07 AM · Restricted Project

Apr 18 2016

erik retitled D220: INP-1553 Move out template meta comment parsing to TemplateCommentParser class from to INP-1553 Move out template meta comment parsing to TemplateCommentParser class.
Apr 18 2016, 4:37 AM · Restricted Project
glebs accepted D204: INP-1539 - Make styleSet name configurable in FCKEditor tag.
Apr 18 2016, 2:08 AM · Restricted Project

Apr 15 2016

glebs accepted D203: INP-1538 - Enable Mod-Rewrite by default.
Apr 15 2016, 1:32 AM

Apr 14 2016

glebs accepted D200: INP-1537 - Fix CS violations in for "kUtil::array_merge_recursive" method.
Apr 14 2016, 1:51 AM

Apr 13 2016

glebs accepted D197: INP-1533 - Use "EXTR_SKIP" with "extract" function.
Apr 13 2016, 1:39 AM

Apr 7 2016

glebs updated the test plan for D219: INP-1540 - Actualize "toolbar_buttons" array in the Title Presets.
Apr 7 2016, 6:10 AM
glebs retitled D219: INP-1540 - Actualize "toolbar_buttons" array in the Title Presets from to INP-1540 - Actualize "toolbar_buttons" array in the Title Presets.
Apr 7 2016, 2:48 AM

Apr 5 2016

alex accepted D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Apr 5 2016, 9:28 AM · Restricted Project
erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

Removed unnecessary links.elm.tpl change.

Apr 5 2016, 9:25 AM · Restricted Project
erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

Made new requested changes.

Apr 5 2016, 9:22 AM · Restricted Project
alex requested changes to D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

I've enhanced test plan with more details and tested that all works according to plan.

Apr 5 2016, 9:10 AM · Restricted Project
alex updated the test plan for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Apr 5 2016, 9:07 AM · Restricted Project
erik updated the diff for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.

Made requesred improvements.

Apr 5 2016, 6:25 AM · Restricted Project
erik updated the test plan for D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Apr 5 2016, 6:11 AM · Restricted Project
alex requested changes to D124: INP-1473 - Add "edit_field" parameter to "AdminEditButton" tag.
Apr 5 2016, 4:21 AM · Restricted Project

Apr 4 2016

erik retitled D218: INP-1384 Delete "COMMON.FOOTER" event template from to INP-1384 The "COMMON.FOOTER" event is present on Clean Install.
Apr 4 2016, 4:56 AM

Apr 2 2016

alex committed rINP16347: Fixes INP-1558 - Empty internal page dropdown during link adding in CKEditor.
Fixes INP-1558 - Empty internal page dropdown during link adding in CKEditor
Apr 2 2016, 9:40 AM
alex committed rTSIM16346: Bug INP-1557 - Use "http_build_query" to escape url parameters.
Bug INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 9:29 AM
alex committed rTDEF16345: Bug INP-1557 - Use "http_build_query" to escape url parameters.
Bug INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 9:27 AM
alex committed rTADV16344: Bug INP-1557 - Use "http_build_query" to escape url parameters.
Bug INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 9:08 AM
alex committed rMINN16343: Bug INP-1557 - Use "http_build_query" to escape url parameters.
Bug INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 9:04 AM
alex committed rMINL16342: Bug INP-1557 - Use "http_build_query" to escape url parameters.
Bug INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 9:01 AM
alex committed rMINC16341: Bug INP-1557 - Use "http_build_query" to escape url parameters.
Bug INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 8:58 AM
ci added a comment to rINP16339: Fixes INP-1557 - Use "http_build_query" to escape url parameters.

Build #52 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/52/

Apr 2 2016, 8:56 AM
alex committed rMINB16340: Bug INP-1557 - Use "http_build_query" to escape url parameters.
Bug INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 8:53 AM
alex committed rINP16339: Fixes INP-1557 - Use "http_build_query" to escape url parameters.
Fixes INP-1557 - Use "http_build_query" to escape url parameters
Apr 2 2016, 8:46 AM
ci added a comment to rINP16338: Fixes INP-1556 - Make use of "HttpOnly" cookies.

Build #51 finished with UNSTABLE status: http://ci.in-portal.org/job/in-portal-52x/51/

Apr 2 2016, 7:11 AM
alex committed rINP16338: Fixes INP-1556 - Make use of "HttpOnly" cookies.
Fixes INP-1556 - Make use of "HttpOnly" cookies
Apr 2 2016, 6:56 AM

Apr 1 2016

erik updated the diff for D120: INP-1470 - Google Sitemap support.

Fixed class variable type, made requested code style fixes.

Apr 1 2016, 4:28 AM · Restricted Project

Mar 30 2016

alex requested changes to D120: INP-1470 - Google Sitemap support.
Mar 30 2016, 11:18 AM · Restricted Project
erik updated the diff for D120: INP-1470 - Google Sitemap support.

Made requested optimization changes.

Mar 30 2016, 11:12 AM · Restricted Project
alex updated the test plan for D120: INP-1470 - Google Sitemap support.
Mar 30 2016, 10:40 AM · Restricted Project
erik updated the test plan for D120: INP-1470 - Google Sitemap support.
Mar 30 2016, 10:05 AM · Restricted Project
alex updated the test plan for D217: INP-1554 - Allow searching category items by meta fields.
Mar 30 2016, 8:44 AM
alex retitled D217: INP-1554 - Allow searching category items by meta fields from to INP-1554 - Allow searching category items by meta fields.
Mar 30 2016, 8:41 AM
alex added inline comments to D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.
Mar 30 2016, 5:53 AM
erik updated the diff for D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.

Added silencing, changed doc blocks.

Mar 30 2016, 4:48 AM
alex requested changes to D120: INP-1470 - Google Sitemap support.

These are mostly optimization related corrections.

Mar 30 2016, 3:49 AM · Restricted Project

Mar 29 2016

alex committed rMWPP16337: Releasing version 'releases/1.0.0-B1' (copy from 'trunk') of….
Releasing version 'releases/1.0.0-B1' (copy from 'trunk') of…
Mar 29 2016, 11:30 AM
alex committed rMWPP16336: Fixes MWPP-1 - Create initial plugin version.
Fixes MWPP-1 - Create initial plugin version
Mar 29 2016, 11:28 AM
alex requested changes to D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.
Mar 29 2016, 5:58 AM
erik retitled D216: MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method from to MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.
Mar 29 2016, 4:45 AM

Mar 27 2016

alex retitled D30: INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console from INP-1205 - Category item in "Home" category not accessible to INP-1205 - Add "Properties" tab, when editing "Home" category in Admin Console.
Mar 27 2016, 8:35 AM
alex retitled D9: INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username from INP-1373 - Admins are receiving e-mails with empty quotes to INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.
Mar 27 2016, 8:10 AM