Page MenuHomeIn-Portal Phabricator
Feed All Stories

Jun 27 2019

alex accepted D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 27 2019, 4:49 AM · Restricted Project
alex updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 27 2019, 4:49 AM · Restricted Project
alex requested changes to D370: INP-1773 Use "round" function during image resize instead of "ceil".

Opening Front-End gives me these PHP warnings:

Jun 27 2019, 4:43 AM · Restricted Project

Jun 26 2019

erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 9:41 AM · Restricted Project
alex updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 8:52 AM · Restricted Project
alex updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 8:51 AM · Restricted Project
alex added a project to D370: INP-1773 Use "round" function during image resize instead of "ceil": Restricted Project.
Jun 26 2019, 8:46 AM · Restricted Project
alex added a project to D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images: Restricted Project.
Jun 26 2019, 8:46 AM · Restricted Project
erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik requested review of D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:25 AM · Restricted Project
erik added a comment to D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:22 AM · Restricted Project
erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:20 AM · Restricted Project

Jun 25 2019

alex updated the diff for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.

Handle cases, when slave is too busy catching up with a master.

Jun 25 2019, 7:41 AM · Restricted Project
erik accepted D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 25 2019, 5:40 AM · Restricted Project
alex updated the test plan for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 25 2019, 5:19 AM · Restricted Project

Jun 24 2019

alex updated the test plan for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 24 2019, 8:57 AM · Restricted Project
alex updated the test plan for D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 24 2019, 8:56 AM · Restricted Project
alex requested review of D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 24 2019, 8:32 AM · Restricted Project

Jun 20 2019

alex accepted D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 20 2019, 10:03 AM · Restricted Project

Jun 19 2019

erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 19 2019, 7:53 AM · Restricted Project
erik updated the diff for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.

Combined error messages.

Jun 19 2019, 7:52 AM · Restricted Project
alex requested changes to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 19 2019, 3:00 AM · Restricted Project

Jun 18 2019

erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:23 AM · Restricted Project
erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:22 AM · Restricted Project
erik updated the diff for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.

Fixed thrown exceprion messages.

Jun 18 2019, 10:21 AM · Restricted Project
erik added inline comments to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:10 AM · Restricted Project
erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:47 AM · Restricted Project
erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:01 AM · Restricted Project
alex added a project to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing: Restricted Project.
Jun 18 2019, 3:07 AM · Restricted Project
alex requested changes to D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.

In the themes\advanced\in-bulletin\elements\side_boxes\polls.elm.tpl change poll image output code to:

Jun 18 2019, 3:03 AM · Restricted Project

Jun 14 2019

erik updated the test plan for D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:31 AM · Restricted Project
erik requested review of D368: INP-1668 - Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:29 AM · Restricted Project

Jun 7 2019

alex accepted D367: INP-1770 Load default user persistent settings all at once.
Jun 7 2019, 10:12 AM
erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Removed excessive (array) typecast.

Jun 7 2019, 5:29 AM
alex requested changes to D367: INP-1770 Load default user persistent settings all at once.
Jun 7 2019, 2:35 AM

Jun 6 2019

erik updated the test plan for D367: INP-1770 Load default user persistent settings all at once.
Jun 6 2019, 12:24 PM
erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Fixed logic.

Jun 6 2019, 12:23 PM
alex requested changes to D367: INP-1770 Load default user persistent settings all at once.

Also since task does optimization only, then here we should be checking that persistent setting retrieval with/without fallback code works as before (not covered) + verify performed SQL count (covered).

Jun 6 2019, 9:47 AM

Jun 5 2019

erik requested review of D367: INP-1770 Load default user persistent settings all at once.
Jun 5 2019, 10:17 AM

May 31 2019

erik accepted D366: INP-1769 - Truncate search result table instead of dropping it.
May 31 2019, 5:56 AM · Restricted Project

May 30 2019

alex added a project to D366: INP-1769 - Truncate search result table instead of dropping it: Restricted Project.
May 30 2019, 8:09 AM · Restricted Project
alex requested review of D366: INP-1769 - Truncate search result table instead of dropping it.
May 30 2019, 8:08 AM · Restricted Project

May 27 2019

alex added a comment to D365: INP-1768 - Disable Load Balancing from CRON.
In D365#7225, @erik wrote:

Tested, working fine, but needs corrections in the test plan.

  1. Some additional table must be in the master DB, not in slave DB.
  2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:

    exit_code(1, 'This script needs to be enabled manually !');
May 27 2019, 7:27 AM · Restricted Project
alex updated the test plan for D365: INP-1768 - Disable Load Balancing from CRON.
May 27 2019, 7:26 AM · Restricted Project
erik accepted D365: INP-1768 - Disable Load Balancing from CRON.

Tested, working fine, but needs corrections in the test plan.

  1. Some additional table must be in the master DB, not in slave DB.
  2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:
May 27 2019, 5:48 AM · Restricted Project

May 23 2019

alex updated the test plan for D365: INP-1768 - Disable Load Balancing from CRON.
May 23 2019, 11:24 AM · Restricted Project
alex requested review of D365: INP-1768 - Disable Load Balancing from CRON.
May 23 2019, 11:13 AM · Restricted Project

May 21 2019

erik accepted D364: INP-1767 - Purge expired database cache entries.
May 21 2019, 5:57 AM · Restricted Project

May 17 2019

alex added a project to D364: INP-1767 - Purge expired database cache entries: Restricted Project.
May 17 2019, 8:37 AM · Restricted Project
alex requested review of D364: INP-1767 - Purge expired database cache entries.
May 17 2019, 8:36 AM · Restricted Project

May 13 2019

erik accepted D362: INP-1765 - Use table alias, when creating calculated fields for catalog items.
May 13 2019, 5:18 AM · Restricted Project
erik accepted D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 13 2019, 5:10 AM · Restricted Project

May 10 2019

alex updated the test plan for D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 10 2019, 6:14 AM · Restricted Project
alex requested review of D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 10 2019, 6:10 AM · Restricted Project

May 8 2019

alex added a project to D362: INP-1765 - Use table alias, when creating calculated fields for catalog items: Restricted Project.
May 8 2019, 12:26 PM · Restricted Project
alex requested review of D362: INP-1765 - Use table alias, when creating calculated fields for catalog items.
May 8 2019, 12:25 PM · Restricted Project

Apr 26 2019

erik requested changes to D361: INP-1764 - Set correct exit code, when exception happens in CLI.

Tested, in both cases got wrong code 255 (not 0 and not 1 )

Apr 26 2019, 7:17 AM · Restricted Project
alex added a project to D361: INP-1764 - Set correct exit code, when exception happens in CLI: Restricted Project.
Apr 26 2019, 3:04 AM · Restricted Project
alex requested review of D361: INP-1764 - Set correct exit code, when exception happens in CLI.
Apr 26 2019, 3:03 AM · Restricted Project

Apr 25 2019

erik accepted D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 9:15 AM · Restricted Project
alex added a comment to D359: INP-1762 - Destroy query object before logging.

Please retest all from scratch, because I've rewritten test plan.

Apr 25 2019, 8:18 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.

Sending latest changes (maybe nothing was changed), but just in case.

Apr 25 2019, 8:16 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 7:54 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 7:51 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 7:50 AM · Restricted Project
erik accepted D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 25 2019, 7:31 AM · Restricted Project
alex planned changes to D359: INP-1762 - Destroy query object before logging.

Changed the code. Need to update test plan.

Apr 25 2019, 7:25 AM · Restricted Project
erik added a comment to D359: INP-1762 - Destroy query object before logging.

Part 1 - general logging - tested. No issues found. Waiting for part 2 and part 3 of the test plan.

Apr 25 2019, 7:25 AM · Restricted Project
alex requested review of D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.

I haven't noticed, that even though this fix looks standalone it still results in a Fatal Error until fix from D359 is applied. I've updated test plan to reflect that.

Apr 25 2019, 7:18 AM · Restricted Project
alex updated the test plan for D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 25 2019, 7:17 AM · Restricted Project
erik requested changes to D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.

Happens fatal error in the line

Apr 25 2019, 7:02 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.

Fixed a typo.

Apr 25 2019, 6:22 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.

Introduce global flag, that allows to disable logging for slow queries for a block of sqls.

Apr 25 2019, 6:21 AM · Restricted Project
alex updated the test plan for D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 6:16 AM · Restricted Project
alex updated the diff for D359: INP-1762 - Destroy query object before logging.
  1. make sure, that SELECT queries used for slow query logging aren't counted towards total query count limit
  2. [bugfix] attemt to get non-debug database query iterator while in debug mode would result in an exception
Apr 25 2019, 2:41 AM · Restricted Project

Apr 23 2019

alex updated the test plan for D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 23 2019, 10:59 AM · Restricted Project
alex added a parent revision for D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method: D359: INP-1762 - Destroy query object before logging.
Apr 23 2019, 10:55 AM · Restricted Project
alex added a child revision for D359: INP-1762 - Destroy query object before logging: D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 23 2019, 10:55 AM · Restricted Project
alex added a project to D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method: Restricted Project.
Apr 23 2019, 10:55 AM · Restricted Project
alex requested review of D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 23 2019, 10:55 AM · Restricted Project

Apr 19 2019

alex added a project to D359: INP-1762 - Destroy query object before logging: Restricted Project.
Apr 19 2019, 10:42 AM · Restricted Project
alex requested review of D359: INP-1762 - Destroy query object before logging.
Apr 19 2019, 10:38 AM · Restricted Project

Mar 27 2019

alex added a project to D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution: Restricted Project.
Mar 27 2019, 2:58 PM · Restricted Project
erik accepted D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 27 2019, 5:55 AM · Restricted Project
erik accepted D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 27 2019, 5:16 AM · Restricted Project

Mar 25 2019

alex requested review of D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 25 2019, 11:38 AM · Restricted Project

Mar 21 2019

alex added a project to D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation: Restricted Project.
Mar 21 2019, 4:58 AM · Restricted Project
alex requested review of D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 21 2019, 4:58 AM · Restricted Project

Jan 23 2019

alex accepted D270: INP-1654 Handle resource type in System Log.
Jan 23 2019, 6:16 AM

Jan 11 2019

alex accepted D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 10:21 AM · Restricted Project
erik updated the diff for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

Added fallback to DB cache when Memcache is not available.

Jan 11 2019, 9:11 AM · Restricted Project
erik updated the test plan for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 9:06 AM · Restricted Project
alex requested changes to D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

I've found one use case, that wasn't covered by initial plan.

Jan 11 2019, 8:29 AM · Restricted Project
erik created D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 5:27 AM · Restricted Project

Dec 20 2018

alex accepted D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 20 2018, 2:58 AM · Restricted Project
alex updated the test plan for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 20 2018, 2:57 AM · Restricted Project

Dec 19 2018

Harbormaster failed remote builds in B913: Diff 890 for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation!
Dec 19 2018, 9:42 AM · Restricted Project
erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Changed SQL expression formatting

Dec 19 2018, 9:42 AM · Restricted Project
alex requested changes to D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 9:33 AM · Restricted Project