Page Menu
Home
In-Portal Phabricator
Search
Configure Global Search
Log In
Files
F785151
D506.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Subscribers
None
File Metadata
Details
File Info
Storage
Attached
Created
Wed, Feb 12, 4:58 AM
Size
689 B
Mime Type
text/x-diff
Expires
Thu, Feb 13, 4:58 AM (14 h, 54 m)
Engine
blob
Format
Raw Data
Handle
564210
Attached To
D506: INP-1895 Ensure consistent return type of the "kTempTablesHandler::CloneItems" method
D506.id.diff
View Options
Index: core/kernel/utility/temp_handler.php
===================================================================
--- core/kernel/utility/temp_handler.php
+++ core/kernel/utility/temp_handler.php
@@ -388,11 +388,13 @@
}
}
- if (!$ids) {
- $this->savedIDs[$prefix.($special ? '.' : '').$special] = Array();
+ $prefix_special = $prefix . ($special ? '.' : '') . $special;
+
+ if ( !isset($this->savedIDs[$prefix_special]) ) {
+ $this->savedIDs[$prefix_special] = array();
}
- return $this->savedIDs[$prefix.($special ? '.' : '').$special];
+ return $this->savedIDs[$prefix_special];
}
function DeleteItems($prefix, $special, $ids, $master=null, $foreign_key=null)
Event Timeline
Log In to Comment