Page MenuHomeIn-Portal Phabricator

D216.id510.diff
No OneTemporary

File Metadata

Created
Thu, Nov 20, 11:37 PM

D216.id510.diff

Index: modules/in-commerce/units/helpers/order_helper.php
===================================================================
--- modules/in-commerce/units/helpers/order_helper.php
+++ modules/in-commerce/units/helpers/order_helper.php
@@ -171,12 +171,33 @@
/**
* Detects credit card type by it's number
*
- * @param string $number
- * @return int
+ * @param string $number Number.
+ *
+ * @return integer
+ *
* @access public
+ * @deprecated
*/
public function getCreditCartType($number)
{
+ trigger_error(
+ 'Usage of deprecated method OrderHelper::getCreditCartType. Use OrderHelper::getCreditCardType.',
+ E_USER_NOTICE
+ );
+
+ return $this->getCreditCardType($number);
+ }
+
+ /**
+ * Detects credit card type by it's number
+ *
+ * @param string $number Number.
+ *
+ * @return integer
+ * @access public
+ */
+ public function getCreditCardType($number)
+ {
// Get rid of any non-digits
$number = preg_replace('/[^\d]/', '', $number);
Index: modules/in-commerce/units/orders/orders_event_handler.php
===================================================================
--- modules/in-commerce/units/orders/orders_event_handler.php
+++ modules/in-commerce/units/orders/orders_event_handler.php
@@ -2537,7 +2537,10 @@
$order_helper = $this->Application->recallObject('OrderHelper');
/* @var $order_helper OrderHelper */
- $object->SetDBField('PaymentCardType', $order_helper->getCreditCartType($object->GetDBField('PaymentAccount')));
+ $object->SetDBField(
+ 'PaymentCardType',
+ $order_helper->getCreditCardType($object->GetDBField('PaymentAccount'))
+ );
}
else {
$object->SetDBField('PaymentCardType', '');

Event Timeline