added ajax-events and permissions for these events
Details
- Reviewers
alex - Commits
- rMINC16462: Fixes MINC-137 - Shopping cart update via AJAX support
Part 1
- in IDE:
- open /themes/advanced/in-commerce/elements/content_boxes/checkout/shipping_address.elm.tpl template for editing
- change OnUpdate to OnUpdateAjax in it and save changes
- on Front-End:
- add a tangible product to the Shopping Cart
- press Proceed to Checkout button to go to the Shipping Information step
- fill all fields, except Zip Code
- press "Update Address" button
- confirm, that page after reload displays correct JSON data - {"status": "FAILED","uploader_info": [],"field_errors": {"ShippingZip": "Field is required"}}
Part 2
- in IDE:
- revert changes made to /themes/advanced/in-commerce/elements/content_boxes/checkout/shipping_address.elm.tpl template
- open /themes/advanced/in-commerce/elements/content_boxes/checkout/billing_options.elm.tpl template for editing
- change OnProceedToPreview to OnProceedToPreviewAjax in it and save changes
- on Front-End:
- fill the missing Zip Code Field
- select shipping type
- proceed to Billing Information step
- fill all fields, except Zip Code
- press "Proceed to preview" button
- confirm, that page after reload displays correct JSON data - {"status": "FAILED","uploader_info": [],"field_errors": {"BillingZip": "Field is required"}}
Diff Detail
- Repository
- rMINC Modules.In-Commerce
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
modules/in-commerce/units/orders/orders_event_handler.php | ||
---|---|---|
68–72 ↗ | (On Diff #433) | Please remove this. Use same pattern for order update events (the CheckPermission checks request regardless of the event used + mapPermissions allows any event). |
133 ↗ | (On Diff #433) | Please:
Use same pattern for order update events (the CheckPermission checks request regardless of the event used + mapPermissions allows any event). |
4051–4053 ↗ | (On Diff #433) | Please remove & symbols. The & is no longer used in most places since In-Commerce 5.2.0 release. |
4054 ↗ | (On Diff #433) | Please move this above variable declaration. |
4066–4068 ↗ | (On Diff #433) | Please remove & symbols. The & is no longer used in most places since In-Commerce 5.2.0 release. |
4069 ↗ | (On Diff #433) | Please move this above variable declaration. |
Previously I've requested & to be removed (=& and &$event), but only 50% of that (=&) was done.
Please resubmit patch against 5.2.x. I've changed my mind against target version of this change.