Page MenuHomeIn-Portal Phabricator

erik (Erik Snarski [Intechnic])
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 25 2014, 9:29 AM (85 mo, 2 w)

Recent Activity

Tue, Mar 30

erik accepted D404: INP-1801 - Use dynamic protocol during installation.
Tue, Mar 30, 5:27 AM

Wed, Mar 24

erik accepted D402: MINC-198 - Don't use "continue" inside a "switch" statement.
Wed, Mar 24, 5:26 AM

Mar 17 2021

erik requested changes to D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.

Partially tested.
6 records appears in the System Log on one News record export.

  1. Field "ThumbnailImage" is not defined in "n" unit config
  2. Undefined index: ThumbnailImage
  3. Field "FullImage" is not defined in "n" unit config
  4. Undefined index: FullImage
  5. Field "ImageAlt" is not defined in "n" unit config
  6. Undefined index: ImageAlt
Mar 17 2021, 6:04 AM · Restricted Project
erik accepted D400: INP-1800 - Remove duplicate primary theme detection query.

Tested. Parent Section dropdown is not empty, "Home" value is visible in the Parent Section dropdown.

Mar 17 2021, 5:38 AM

Mar 15 2021

erik added a comment to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Made QA changes, extended test plan.

Mar 15 2021, 10:43 AM · Restricted Project
erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 15 2021, 10:41 AM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

QA Fixes

Mar 15 2021, 10:41 AM · Restricted Project

Mar 12 2021

erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 1:00 PM · Restricted Project
erik added inline comments to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 12:17 PM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Added system user check to session LoggedIn method.

Mar 12 2021, 1:54 AM · Restricted Project

Mar 11 2021

erik requested review of D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 11 2021, 10:47 AM · Restricted Project

Mar 8 2021

erik accepted D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Mar 8 2021, 4:42 AM · Restricted Project

Mar 4 2021

erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:48 AM

Mar 3 2021

erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Test plan is all right. But, beyond this patch, exists SQL error when doing "View Chart" for "By Product" and "By Section" cases. Problematic SQL is like

Mar 3 2021, 9:14 AM
erik accepted D390: INP-1792 - Support HTML markup with Title Presets.
Mar 3 2021, 5:04 AM
erik accepted D391: INP-1793 - Disable output buffering in Console.
Mar 3 2021, 4:56 AM · Restricted Project
erik accepted D396: INP-1797 - Speed up formatter class access from "kDBItem".
Mar 3 2021, 4:48 AM · Restricted Project

Feb 23 2021

erik accepted D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
Feb 23 2021, 4:56 AM · Restricted Project

Feb 19 2021

erik accepted D392: INP-1794 - Show database query execution times durning deployment.
Feb 19 2021, 3:50 AM · Restricted Project
erik added a comment to D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.

Cant test this - do not have macOS

Feb 19 2021, 3:36 AM · Restricted Project
erik accepted D394: INP-1796 - Add method for setting database error handler.
Feb 19 2021, 3:22 AM

Aug 27 2020

erik accepted D384: INP-1786 - Don't use "continue" inside a "switch" statement.
Aug 27 2020, 5:31 AM · Restricted Project
erik accepted D385: INP-1787 - Don't use "get_magic_quotes_gpc" function.
Aug 27 2020, 5:29 AM · Restricted Project

Aug 17 2020

erik accepted D381: INP-1783 - Add "checkboxes" control type for configuration settings.
Aug 17 2020, 1:22 PM · Restricted Project
erik accepted D382: INP-1784 - Adjust "grid_total_td" block to respect "format" parameter.
Aug 17 2020, 1:14 PM · Restricted Project
erik accepted D383: INP-1785 - Always apply "no_default" format, when getting original field value.
Aug 17 2020, 1:06 PM · Restricted Project
erik added a comment to D384: INP-1786 - Don't use "continue" inside a "switch" statement.

Can't test - have PHP 7.2.19 only

Aug 17 2020, 1:02 PM · Restricted Project
erik added a comment to D385: INP-1787 - Don't use "get_magic_quotes_gpc" function.

I have no php 7.4 on VM to test/review this.

Aug 17 2020, 6:02 AM · Restricted Project
erik accepted D386: INP-1788 - Trigger a warning, when not all fields were updated via "kDBItem::Update" method call.
Aug 17 2020, 5:52 AM · Restricted Project
erik accepted D387: INP-1789 - Teach "Changes Log" section to respect "kDBItem::Update" calls with limited field set.
Aug 17 2020, 5:42 AM · Restricted Project

Apr 14 2020

erik added a comment to D361: INP-1764 - Set correct exit code, when exception happens in CLI.
Apr 14 2020, 2:03 PM · Restricted Project
erik accepted D361: INP-1764 - Set correct exit code, when exception happens in CLI.

Tested - got 0 and 1 codes, as planned.

Apr 14 2020, 5:45 AM · Restricted Project

Mar 26 2020

erik accepted D379: INP-1781 - Respect sub-item status, when performing unique validation.
Mar 26 2020, 6:12 AM · Restricted Project

Mar 11 2020

erik requested review of D380: INP-1782 Allow multiple sections from single unit to have separate permissions.
Mar 11 2020, 1:46 PM

Mar 9 2020

erik accepted D377: INP-1779 - Throw an exception, when SQL error is detected in CLI.

In the run_event. php first line must be commented to make test plan possible.

Mar 9 2020, 5:43 AM · Restricted Project
erik accepted D378: INP-1780 - Sync "Semaphores" table structure between clean install and upgrade.

Got JS alert "Copying operation in Temporary tables has failed. Please contact website administrator." If this is popup about concurrent Save attempt - then accepted.

Mar 9 2020, 5:30 AM · Restricted Project

Feb 19 2020

erik accepted D379: INP-1781 - Respect sub-item status, when performing unique validation.
Feb 19 2020, 11:47 AM · Restricted Project

Jan 17 2020

erik updated the test plan for D376: INP-1778 Auto-focus correct form control on error.
Jan 17 2020, 8:09 AM
erik requested review of D376: INP-1778 Auto-focus correct form control on error.
Jan 17 2020, 8:06 AM

Oct 17 2019

erik accepted D375: INP-1777 - Preserve non-existing selected options during record field value display.
Oct 17 2019, 12:07 PM · Restricted Project

Aug 6 2019

erik accepted D374: INP-1776 - Define permission mapping for "OnExportCancel" event.
Aug 6 2019, 6:14 AM

Jul 12 2019

erik accepted D372: INP-1774 - Display scaled down file size in uploader.
Jul 12 2019, 5:45 AM · Restricted Project
erik accepted D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 12 2019, 5:38 AM · Restricted Project

Jun 27 2019

erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".

Changed test plan to use image helper.

Jun 27 2019, 5:39 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 27 2019, 5:38 AM · Restricted Project

Jun 26 2019

erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 9:41 AM · Restricted Project
erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik requested review of D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:25 AM · Restricted Project
erik added a comment to D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:22 AM · Restricted Project
erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:20 AM · Restricted Project

Jun 25 2019

erik accepted D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 25 2019, 5:40 AM · Restricted Project

Jun 19 2019

erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 19 2019, 7:53 AM · Restricted Project
erik updated the diff for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.

Combined error messages.

Jun 19 2019, 7:52 AM · Restricted Project

Jun 18 2019

erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:23 AM · Restricted Project
erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:22 AM · Restricted Project
erik updated the diff for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.

Fixed thrown exceprion messages.

Jun 18 2019, 10:21 AM · Restricted Project
erik added inline comments to D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:10 AM · Restricted Project
erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:47 AM · Restricted Project
erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:01 AM · Restricted Project

Jun 14 2019

erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:31 AM · Restricted Project
erik requested review of D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:29 AM · Restricted Project

Jun 7 2019

erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Removed excessive (array) typecast.

Jun 7 2019, 5:29 AM

Jun 6 2019

erik updated the test plan for D367: INP-1770 Load default user persistent settings all at once.
Jun 6 2019, 12:24 PM
erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Fixed logic.

Jun 6 2019, 12:23 PM

Jun 5 2019

erik requested review of D367: INP-1770 Load default user persistent settings all at once.
Jun 5 2019, 10:17 AM

May 31 2019

erik accepted D366: INP-1769 - Truncate search result table instead of dropping it.
May 31 2019, 5:56 AM · Restricted Project

May 27 2019

erik accepted D365: INP-1768 - Disable Load Balancing from CRON.

Tested, working fine, but needs corrections in the test plan.

  1. Some additional table must be in the master DB, not in slave DB.
  2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:
May 27 2019, 5:48 AM · Restricted Project

May 21 2019

erik accepted D364: INP-1767 - Purge expired database cache entries.
May 21 2019, 5:57 AM · Restricted Project

May 13 2019

erik accepted D362: INP-1765 - Use table alias, when creating calculated fields for catalog items.
May 13 2019, 5:18 AM · Restricted Project
erik accepted D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 13 2019, 5:10 AM · Restricted Project

Apr 26 2019

erik requested changes to D361: INP-1764 - Set correct exit code, when exception happens in CLI.

Tested, in both cases got wrong code 255 (not 0 and not 1 )

Apr 26 2019, 7:17 AM · Restricted Project

Apr 25 2019

erik accepted D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 9:15 AM · Restricted Project
erik accepted D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 25 2019, 7:31 AM · Restricted Project
erik added a comment to D359: INP-1762 - Destroy query object before logging.

Part 1 - general logging - tested. No issues found. Waiting for part 2 and part 3 of the test plan.

Apr 25 2019, 7:25 AM · Restricted Project
erik requested changes to D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.

Happens fatal error in the line

Apr 25 2019, 7:02 AM · Restricted Project

Mar 27 2019

erik accepted D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 27 2019, 5:55 AM · Restricted Project
erik accepted D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 27 2019, 5:16 AM · Restricted Project

Jan 11 2019

erik updated the diff for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

Added fallback to DB cache when Memcache is not available.

Jan 11 2019, 9:11 AM · Restricted Project
erik updated the test plan for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 9:06 AM · Restricted Project
erik created D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 5:27 AM · Restricted Project

Dec 19 2018

erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Changed SQL expression formatting

Dec 19 2018, 9:42 AM · Restricted Project
erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Improved SQL expression formatting, updated test plan.

Dec 19 2018, 8:04 AM · Restricted Project
erik updated the test plan for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 6:58 AM · Restricted Project

Dec 18 2018

erik created D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 18 2018, 10:39 AM · Restricted Project

Nov 16 2018

erik accepted D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 16 2018, 4:24 AM · Restricted Project

Nov 15 2018

erik requested changes to D354: INP-1756 - Create "Security*" classes for security-related jobs.
  1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.
  2. After installation with PHP v.7.2 new "SecurityHmacKey" and "SecurityEncryptionKey" settings were added normally, but test.php resulting in exception: -
Nov 15 2018, 11:33 AM · Restricted Project

Nov 14 2018

erik accepted D340: INP-1741 - Vertically align grid icons.
Nov 14 2018, 4:14 AM · Restricted Project

Nov 12 2018

erik requested changes to D340: INP-1741 - Vertically align grid icons.
  1. I do not understand where is improvement. I see, that before icon was 1 pixel over checkox. Now it is 1 pixel under checkbox, and I do not see any issue related to row count in "before" case
Nov 12 2018, 5:01 AM · Restricted Project

Nov 8 2018

erik requested review of D351: INP-1750 Support PHP Memcached extension for caching.
Nov 8 2018, 4:26 AM · Restricted Project
erik updated the test plan for D351: INP-1750 Support PHP Memcached extension for caching.
Nov 8 2018, 4:25 AM · Restricted Project

Nov 7 2018

erik updated the test plan for D351: INP-1750 Support PHP Memcached extension for caching.
Nov 7 2018, 4:59 AM · Restricted Project

Nov 5 2018

erik updated the diff for D351: INP-1750 Support PHP Memcached extension for caching.

Made requested code fixes. TODO - test plan changes.

Nov 5 2018, 4:55 AM · Restricted Project

Oct 31 2018

erik accepted D350: INP-1751 - Use PHP5-style constructor names only in LibChart library code.
Oct 31 2018, 6:17 AM · Restricted Project
erik accepted D352: INP-1752 - Update sub-class method signatures to match overridden methods in parent class.
Oct 31 2018, 5:53 AM · Restricted Project

Oct 30 2018

erik created D351: INP-1750 Support PHP Memcached extension for caching.
Oct 30 2018, 10:59 AM · Restricted Project

Oct 29 2018

erik updated the diff for D348: MINC-195 Don't use "break" during shipping quote aggregation.

Condition moved one level up.

Oct 29 2018, 6:13 AM · Restricted Project
erik updated the test plan for D348: MINC-195 Don't use "break" during shipping quote aggregation.
Oct 29 2018, 6:08 AM · Restricted Project

Oct 26 2018

erik updated the diff for D343: INP-1744 Make page content blocks searcheable.

Added missing phrase translation.

Oct 26 2018, 10:11 AM · Restricted Project
erik requested review of D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 8:20 AM · Restricted Project