Page MenuHomeIn-Portal Phabricator

erik (Erik Snarski [Intechnic])
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 25 2014, 9:29 AM (103 mo, 1 d)

Recent Activity

Wed, Aug 17

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Wed, Aug 17, 7:17 AM · Restricted Project

Wed, Aug 10

erik accepted D425: INP-1821 - Don't check event-based permissions from template for "root" user.
Wed, Aug 10, 5:21 AM

Tue, Aug 9

erik accepted D422: INP-1818 - Reset cURL settings only upon connection closing.
Tue, Aug 9, 5:53 AM
erik accepted D423: INP-1819 - Allow retrieving response headers after making the cURL request.
Tue, Aug 9, 5:53 AM

Mon, Aug 8

erik accepted D424: INP-1820 - Optionally store added record data in the Changes Log.

Tested with clean install only.

Mon, Aug 8, 9:36 AM · Restricted Project

Wed, Jul 27

erik requested changes to D229: INP-1565 Add support for "relative" date format.

Math is incorrect.

Wed, Jul 27, 1:43 PM

Jul 20 2022

erik accepted D421: MINN-27 - Add missing export-related virtual fields.
Jul 20 2022, 5:22 AM
erik accepted D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.
Jul 20 2022, 5:10 AM · Restricted Project

Jul 19 2022

erik updated the diff for D243: INP-1571 Form field validation should account for array-like field values.

Added code to avoid "Array to string conversion" notice. Added related test plan part.

Jul 19 2022, 9:53 AM
erik updated the test plan for D243: INP-1571 Form field validation should account for array-like field values.
Jul 19 2022, 9:46 AM
erik accepted D388: INP-1791 - Add "picker" control type for configuration settings.
Jul 19 2022, 7:58 AM · Restricted Project
erik accepted D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.
Jul 19 2022, 7:56 AM

Jul 15 2022

erik requested changes to D388: INP-1791 - Add "picker" control type for configuration settings.
  1. In the test plan part 4 need "Picker" value, not "Checkboxes"
  2. However, if "Checkboxes" selected, looks incorrect - shown only one checkbox, not multiple checkboxes with one-two-three labels.
  3. Items alphabetical sorting is not applied on page load, so after save/on page reload options order may change.
Jul 15 2022, 12:48 PM · Restricted Project

Jul 14 2022

erik requested changes to D416: INP-1812 - Change "LeftJoinOptimizer" to find table aliases usage only at word boundaries.

Работает всё как надо, но наверное надо исправить Test Plan. В "Plan 2" и "Plan 3" в SQL не хватает фильтра WHERE ((52x_Users.UserType = 0))

Jul 14 2022, 10:35 AM
erik accepted D269: INP-1645 - Create categories during theme scan based on their location in SMS.
Jul 14 2022, 10:09 AM
erik accepted D417: INP-1814 - Use relative paths in error messages.
Jul 14 2022, 9:49 AM · Restricted Project
erik accepted D418: INP-1815 - Anonymize error message content for Regular Website Visitors.
Jul 14 2022, 9:39 AM · Restricted Project
erik accepted D419: INP-1816 - Use argument-based cache in the "kApplication::GetDefaultThemeId" method.
Jul 14 2022, 9:19 AM · Restricted Project

Jul 6 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Added missing table creation on in-portal upgrade

Jul 6 2022, 10:45 AM

Jul 5 2022

erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Changed install schema due Jenkins message - all primary key fields must be without null values

Jul 5 2022, 10:01 AM
erik updated the diff for D420: INP-1817 - Change engine for storing export user presets.

Made all requested improvements

Jul 5 2022, 6:03 AM

Jul 4 2022

erik requested review of D420: INP-1817 - Change engine for storing export user presets.
Jul 4 2022, 12:57 PM

Apr 6 2022

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Apr 6 2022, 12:49 PM · Restricted Project

Sep 22 2021

erik accepted D415: INP-1811 - Support partitions in grids and direct INSERT/UPDATE clauses.
Sep 22 2021, 10:37 AM

Sep 8 2021

erik accepted D414: INP-1810 - Use linked info in "OnNew" event only, when it's available.
Sep 8 2021, 5:37 AM

Aug 27 2021

erik updated the diff for D411: INP-1757 - Replace "each" function usage with equivalent code.

Made all requested fixes

Aug 27 2021, 9:31 AM

Aug 6 2021

erik accepted D412: INP-1808 - Create "E-mail Log" records using corresponding unit.
Aug 6 2021, 9:19 AM

Aug 5 2021

erik updated the diff for D411: INP-1757 - Replace "each" function usage with equivalent code.

Done requested changes in all other modules

Aug 5 2021, 1:59 PM
erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Aug 5 2021, 1:51 PM

Aug 4 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Aug 4 2021, 5:59 AM

Jul 29 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 29 2021, 1:46 PM
erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 29 2021, 6:22 AM

Jul 28 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 28 2021, 1:51 PM

Jul 21 2021

erik accepted D413: INP-1809 - Introduce active editing window tracking system.
Jul 21 2021, 9:35 AM · Restricted Project

Jul 16 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 16 2021, 2:18 AM

Jul 15 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 15 2021, 6:10 AM

Jul 14 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 14 2021, 5:56 AM

Jul 13 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 13 2021, 5:57 AM

Jul 12 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 12 2021, 5:57 AM

Jul 2 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jul 2 2021, 3:05 AM

Jun 30 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 30 2021, 5:56 AM

Jun 29 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 29 2021, 5:59 AM

Jun 23 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 23 2021, 1:57 PM
erik accepted D410: INP-1807 - Use dedicated connection for "kLogger" class.
Jun 23 2021, 5:30 AM

Jun 21 2021

erik updated the test plan for D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 21 2021, 1:18 PM
erik requested review of D411: INP-1757 - Replace "each" function usage with equivalent code.
Jun 21 2021, 11:49 AM

Jun 17 2021

erik accepted D392: INP-1794 - Show database query execution times during deployment.
Jun 17 2021, 5:39 AM · Restricted Project

Jun 2 2021

erik accepted D409: INP-1806 - Display output of executed MySQL commands during build script execution.
Jun 2 2021, 5:57 AM · Restricted Project

May 18 2021

erik requested changes to D407: INP-1804 - Don't reset current user after all Scheduled Tasks were executed.

No output detected after doing test plan.

May 18 2021, 5:09 AM · Restricted Project
erik accepted D408: INP-1805 - Execute "adm:OnBeforeShutdown" event before AJAX request ending.
May 18 2021, 4:30 AM · Restricted Project

May 7 2021

erik accepted D405: INP-1802 - Speed up detection of countries with states.
May 7 2021, 2:44 AM · Restricted Project
erik accepted D406: INP-1803 - Show non-executed SQLs during deployment.
May 7 2021, 2:34 AM · Restricted Project

Mar 30 2021

erik accepted D404: INP-1801 - Use dynamic protocol during installation.
Mar 30 2021, 5:27 AM

Mar 24 2021

erik accepted D402: MINC-198 - Don't use "continue" inside a "switch" statement.
Mar 24 2021, 5:26 AM

Mar 17 2021

erik requested changes to D401: INP-1790 - Remove trailing space from "FieldsSeparatedBy" field of catalog item units.

Partially tested.
6 records appears in the System Log on one News record export.

  1. Field "ThumbnailImage" is not defined in "n" unit config
  2. Undefined index: ThumbnailImage
  3. Field "FullImage" is not defined in "n" unit config
  4. Undefined index: FullImage
  5. Field "ImageAlt" is not defined in "n" unit config
  6. Undefined index: ImageAlt
Mar 17 2021, 6:04 AM · Restricted Project
erik accepted D400: INP-1800 - Remove duplicate primary theme detection query.

Tested. Parent Section dropdown is not empty, "Home" value is visible in the Parent Section dropdown.

Mar 17 2021, 5:38 AM

Mar 15 2021

erik added a comment to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Made QA changes, extended test plan.

Mar 15 2021, 10:43 AM · Restricted Project
erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 15 2021, 10:41 AM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

QA Fixes

Mar 15 2021, 10:41 AM · Restricted Project

Mar 12 2021

erik updated the test plan for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 1:00 PM · Restricted Project
erik added inline comments to D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 12 2021, 12:17 PM · Restricted Project
erik updated the diff for D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.

Added system user check to session LoggedIn method.

Mar 12 2021, 1:54 AM · Restricted Project

Mar 11 2021

erik requested review of D399: INP-1799 - Add/use "system" user instead of "root" for system initiated activities.
Mar 11 2021, 10:47 AM · Restricted Project

Mar 8 2021

erik accepted D398: INP-1798 - Include validation errors and temp mode flag in kDBItem validation error message.
Mar 8 2021, 4:42 AM · Restricted Project

Mar 4 2021

erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.
Mar 4 2021, 5:48 AM

Mar 3 2021

erik accepted D397: MINC-197 - Improve user experience for "E-commerce > Sales Report" section.

Test plan is all right. But, beyond this patch, exists SQL error when doing "View Chart" for "By Product" and "By Section" cases. Problematic SQL is like

Mar 3 2021, 9:14 AM
erik accepted D390: INP-1792 - Support HTML markup with Title Presets.
Mar 3 2021, 5:04 AM
erik accepted D391: INP-1793 - Disable output buffering in Console.
Mar 3 2021, 4:56 AM · Restricted Project
erik accepted D396: INP-1797 - Speed up formatter class access from "kDBItem".
Mar 3 2021, 4:48 AM · Restricted Project

Feb 23 2021

erik accepted D395: MINC-196 - Harden check for "PaymentCCExpMonth" and "PaymentCCExpYear" sale order fields.
Feb 23 2021, 4:56 AM · Restricted Project

Feb 19 2021

erik accepted D392: INP-1794 - Show database query execution times during deployment.
Feb 19 2021, 3:50 AM · Restricted Project
erik added a comment to D393: INP-1795 - Invoke language pack comparison tool upon deploy using AppleScript.

Cant test this - do not have macOS

Feb 19 2021, 3:36 AM · Restricted Project
erik accepted D394: INP-1796 - Add method for setting database error handler.
Feb 19 2021, 3:22 AM

Aug 27 2020

erik accepted D384: INP-1786 - Don't use "continue" inside a "switch" statement.
Aug 27 2020, 5:31 AM · Restricted Project
erik accepted D385: INP-1787 - Don't use "get_magic_quotes_gpc" function.
Aug 27 2020, 5:29 AM · Restricted Project

Aug 17 2020

erik accepted D381: INP-1783 - Add "checkboxes" control type for configuration settings.
Aug 17 2020, 1:22 PM · Restricted Project
erik accepted D382: INP-1784 - Adjust "grid_total_td" block to respect "format" parameter.
Aug 17 2020, 1:14 PM · Restricted Project
erik accepted D383: INP-1785 - Always apply "no_default" format, when getting original field value.
Aug 17 2020, 1:06 PM · Restricted Project
erik added a comment to D384: INP-1786 - Don't use "continue" inside a "switch" statement.

Can't test - have PHP 7.2.19 only

Aug 17 2020, 1:02 PM · Restricted Project
erik added a comment to D385: INP-1787 - Don't use "get_magic_quotes_gpc" function.

I have no php 7.4 on VM to test/review this.

Aug 17 2020, 6:02 AM · Restricted Project
erik accepted D386: INP-1788 - Trigger a warning, when not all fields were updated via "kDBItem::Update" method call.
Aug 17 2020, 5:52 AM · Restricted Project
erik accepted D387: INP-1789 - Teach "Changes Log" section to respect "kDBItem::Update" calls with limited field set.
Aug 17 2020, 5:42 AM · Restricted Project

Apr 14 2020

erik added a comment to D361: INP-1764 - Set correct exit code, when exception happens in CLI.
Apr 14 2020, 2:03 PM · Restricted Project
erik accepted D361: INP-1764 - Set correct exit code, when exception happens in CLI.

Tested - got 0 and 1 codes, as planned.

Apr 14 2020, 5:45 AM · Restricted Project

Mar 26 2020

erik accepted D379: INP-1781 - Respect sub-item status, when performing unique validation.
Mar 26 2020, 6:12 AM · Restricted Project

Mar 11 2020

erik requested review of D380: INP-1782 Allow multiple sections from single unit to have separate permissions.
Mar 11 2020, 1:46 PM

Mar 9 2020

erik accepted D377: INP-1779 - Throw an exception, when SQL error is detected in CLI.

In the run_event. php first line must be commented to make test plan possible.

Mar 9 2020, 5:43 AM · Restricted Project
erik accepted D378: INP-1780 - Sync "Semaphores" table structure between clean install and upgrade.

Got JS alert "Copying operation in Temporary tables has failed. Please contact website administrator." If this is popup about concurrent Save attempt - then accepted.

Mar 9 2020, 5:30 AM · Restricted Project

Feb 19 2020

erik accepted D379: INP-1781 - Respect sub-item status, when performing unique validation.
Feb 19 2020, 11:47 AM · Restricted Project

Jan 17 2020

erik updated the test plan for D376: INP-1778 Auto-focus correct form control on error.
Jan 17 2020, 8:09 AM
erik requested review of D376: INP-1778 Auto-focus correct form control on error.
Jan 17 2020, 8:06 AM

Oct 17 2019

erik accepted D375: INP-1777 - Preserve non-existing selected options during record field value display.
Oct 17 2019, 12:07 PM · Restricted Project

Aug 6 2019

erik accepted D374: INP-1776 - Define permission mapping for "OnExportCancel" event.
Aug 6 2019, 6:14 AM

Jul 12 2019

erik accepted D372: INP-1774 - Display scaled down file size in uploader.
Jul 12 2019, 5:45 AM · Restricted Project
erik accepted D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 12 2019, 5:38 AM · Restricted Project

Jun 27 2019

erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".

Changed test plan to use image helper.

Jun 27 2019, 5:39 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 27 2019, 5:38 AM · Restricted Project

Jun 26 2019

erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 9:41 AM · Restricted Project
erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik requested review of D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project