Page MenuHomeIn-Portal Phabricator

erik (Erik Snarski [Intechnic])
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 25 2014, 9:29 AM (67 mo, 3 w)

Recent Activity

Oct 17 2019

erik accepted D375: INP-1777 - Preserve non-existing selected options during record field value display.
Oct 17 2019, 12:07 PM · Restricted Project

Aug 6 2019

erik accepted D374: INP-1776 - Define permission mapping for "OnExportCancel" event.
Aug 6 2019, 6:14 AM

Jul 12 2019

erik accepted D372: INP-1774 - Display scaled down file size in uploader.
Jul 12 2019, 5:45 AM · Restricted Project
erik accepted D373: INP-1775 - Rename uploaded images to match their image type (when "storage_format" is used).
Jul 12 2019, 5:38 AM · Restricted Project

Jun 27 2019

erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".

Changed test plan to use image helper.

Jun 27 2019, 5:39 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 27 2019, 5:38 AM · Restricted Project

Jun 26 2019

erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 9:41 AM · Restricted Project
erik updated the test plan for D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik requested review of D371: INP-1772 Don't use "/tmp" folder, when resizing uploaded images.
Jun 26 2019, 6:40 AM · Restricted Project
erik updated the test plan for D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:25 AM · Restricted Project
erik added a comment to D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:22 AM · Restricted Project
erik requested review of D370: INP-1773 Use "round" function during image resize instead of "ceil".
Jun 26 2019, 6:20 AM · Restricted Project

Jun 25 2019

erik accepted D369: INP-1771 - Change slave lag detection code to use "SHOW SLAVE STATUS" query.
Jun 25 2019, 5:40 AM · Restricted Project

Jun 19 2019

erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 19 2019, 7:53 AM · Restricted Project
erik updated the diff for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.

Combined error messages.

Jun 19 2019, 7:52 AM · Restricted Project

Jun 18 2019

erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:23 AM · Restricted Project
erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:22 AM · Restricted Project
erik updated the diff for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.

Fixed thrown exceprion messages.

Jun 18 2019, 10:21 AM · Restricted Project
erik added inline comments to D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 10:10 AM · Restricted Project
erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:47 AM · Restricted Project
erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 18 2019, 9:01 AM · Restricted Project

Jun 14 2019

erik updated the test plan for D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:31 AM · Restricted Project
erik requested review of D368: INP-1668 Allow specifying image quality, orientation and output format during resizing.
Jun 14 2019, 9:29 AM · Restricted Project

Jun 7 2019

erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Removed excessive (array) typecast.

Jun 7 2019, 5:29 AM

Jun 6 2019

erik updated the test plan for D367: INP-1770 Load default user persistent settings all at once.
Jun 6 2019, 12:24 PM
erik updated the diff for D367: INP-1770 Load default user persistent settings all at once.

Fixed logic.

Jun 6 2019, 12:23 PM

Jun 5 2019

erik requested review of D367: INP-1770 Load default user persistent settings all at once.
Jun 5 2019, 10:17 AM

May 31 2019

erik accepted D366: INP-1769 - Truncate search result table instead of dropping it.
May 31 2019, 5:56 AM · Restricted Project

May 27 2019

erik accepted D365: INP-1768 - Disable Load Balancing from CRON.

Tested, working fine, but needs corrections in the test plan.

  1. Some additional table must be in the master DB, not in slave DB.
  2. in the tools/run_event.php line #15, which blocks script's test part execution, must be commented:
May 27 2019, 5:48 AM · Restricted Project

May 21 2019

erik accepted D364: INP-1767 - Purge expired database cache entries.
May 21 2019, 5:57 AM · Restricted Project

May 13 2019

erik accepted D362: INP-1765 - Use table alias, when creating calculated fields for catalog items.
May 13 2019, 5:18 AM · Restricted Project
erik accepted D363: INP-1766 - Change "kDBLoadBalancer::openConnection" to always update last used connection index.
May 13 2019, 5:10 AM · Restricted Project

Apr 26 2019

erik requested changes to D361: INP-1764 - Set correct exit code, when exception happens in CLI.

Tested, in both cases got wrong code 255 (not 0 and not 1 )

Apr 26 2019, 7:17 AM · Restricted Project

Apr 25 2019

erik accepted D359: INP-1762 - Destroy query object before logging.
Apr 25 2019, 9:15 AM · Restricted Project
erik accepted D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.
Apr 25 2019, 7:31 AM · Restricted Project
erik added a comment to D359: INP-1762 - Destroy query object before logging.

Part 1 - general logging - tested. No issues found. Waiting for part 2 and part 3 of the test plan.

Apr 25 2019, 7:25 AM · Restricted Project
erik requested changes to D360: INP-1763 - Use first found record in update sql in the "\kApplication::logSlowQuery" method.

Happens fatal error in the line

Apr 25 2019, 7:02 AM · Restricted Project

Mar 27 2019

erik accepted D358: INP-1753 - Protect against racing condition during Scheduled Tasks execution.
Mar 27 2019, 5:55 AM · Restricted Project
erik accepted D357: INP-1761 - Account for LeftJoinOptimizer during grid total calculation.
Mar 27 2019, 5:16 AM · Restricted Project

Jan 11 2019

erik updated the diff for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.

Added fallback to DB cache when Memcache is not available.

Jan 11 2019, 9:11 AM
erik updated the test plan for D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 9:06 AM
erik created D356: INP-1760 Don't attempt to change "CachedUrls" table for units, that are not used in Mod-Rewrite URLs.
Jan 11 2019, 5:27 AM

Dec 19 2018

erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Changed SQL expression formatting

Dec 19 2018, 9:42 AM
erik updated the diff for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.

Improved SQL expression formatting, updated test plan.

Dec 19 2018, 8:04 AM
erik updated the test plan for D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 19 2018, 6:58 AM

Dec 18 2018

erik created D355: INP-1759 Use delayed cached Mod-Rewrite URL invalidation.
Dec 18 2018, 10:39 AM

Nov 16 2018

erik accepted D354: INP-1756 - Create "Security*" classes for security-related jobs.
Nov 16 2018, 4:24 AM · Restricted Project

Nov 15 2018

erik requested changes to D354: INP-1756 - Create "Security*" classes for security-related jobs.
  1. Installation is possible only with PHP v.7 because of "random_int" function, used in added code.
  2. After installation with PHP v.7.2 new "SecurityHmacKey" and "SecurityEncryptionKey" settings were added normally, but test.php resulting in exception: -
Nov 15 2018, 11:33 AM · Restricted Project

Nov 14 2018

erik accepted D340: INP-1741 - Vertically align grid icons.
Nov 14 2018, 4:14 AM · Restricted Project

Nov 12 2018

erik requested changes to D340: INP-1741 - Vertically align grid icons.
  1. I do not understand where is improvement. I see, that before icon was 1 pixel over checkox. Now it is 1 pixel under checkbox, and I do not see any issue related to row count in "before" case
Nov 12 2018, 5:01 AM · Restricted Project

Nov 8 2018

erik requested review of D351: INP-1750 Support PHP Memcached extension for caching.
Nov 8 2018, 4:26 AM · Restricted Project
erik updated the test plan for D351: INP-1750 Support PHP Memcached extension for caching.
Nov 8 2018, 4:25 AM · Restricted Project

Nov 7 2018

erik updated the test plan for D351: INP-1750 Support PHP Memcached extension for caching.
Nov 7 2018, 4:59 AM · Restricted Project

Nov 5 2018

erik updated the diff for D351: INP-1750 Support PHP Memcached extension for caching.

Made requested code fixes. TODO - test plan changes.

Nov 5 2018, 4:55 AM · Restricted Project

Oct 31 2018

erik accepted D350: INP-1751 - Use PHP5-style constructor names only in LibChart library code.
Oct 31 2018, 6:17 AM · Restricted Project
erik accepted D352: INP-1752 - Update sub-class method signatures to match overridden methods in parent class.
Oct 31 2018, 5:53 AM · Restricted Project

Oct 30 2018

erik created D351: INP-1750 Support PHP Memcached extension for caching.
Oct 30 2018, 10:59 AM · Restricted Project

Oct 29 2018

erik updated the diff for D348: MINC-195 Don't use "break" during shipping quote aggregation.

Condition moved one level up.

Oct 29 2018, 6:13 AM · Restricted Project
erik updated the test plan for D348: MINC-195 Don't use "break" during shipping quote aggregation.
Oct 29 2018, 6:08 AM · Restricted Project

Oct 26 2018

erik updated the diff for D343: INP-1744 Make page content blocks searcheable.

Added missing phrase translation.

Oct 26 2018, 10:11 AM · Restricted Project
erik requested review of D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 8:20 AM · Restricted Project
erik commandeered D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 8:19 AM · Restricted Project
erik updated the diff for D343: INP-1744 Make page content blocks searcheable.

GROUP_CONCAT usage replaced with concatenation on php level.

Oct 26 2018, 6:46 AM · Restricted Project
erik updated the test plan for D343: INP-1744 Make page content blocks searcheable.
Oct 26 2018, 6:40 AM · Restricted Project

Oct 25 2018

erik updated the diff for D349: INP-1721 Correct math for detecting allowed file size during upload.

Improvement for calculations result caching

Oct 25 2018, 12:09 PM
erik updated the test plan for D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 25 2018, 12:04 PM
erik created D349: INP-1721 Correct math for detecting allowed file size during upload.
Oct 25 2018, 7:38 AM

Oct 24 2018

erik created D348: MINC-195 Don't use "break" during shipping quote aggregation.
Oct 24 2018, 11:06 AM · Restricted Project

Sep 27 2018

erik added a comment to D243: INP-1571 Form field validation should account for array-like field values.

No, this error is not related to current task changes.

Sep 27 2018, 7:35 AM
erik added a comment to D243: INP-1571 Form field validation should account for array-like field values.

No strlen error in debugger from changed ValidateRange method. 'FirstName' test value detected as invalid in other validation method (ValidateType) and not passed to ValidateRange method.

Sep 27 2018, 6:37 AM
erik updated the diff for D243: INP-1571 Form field validation should account for array-like field values.

Done refactoring.

Sep 27 2018, 6:33 AM

Sep 21 2018

erik updated the test plan for D346: INP-1746 Correct time parsing in date range filter.
Sep 21 2018, 6:00 AM · Restricted Project
erik updated the diff for D346: INP-1746 Correct time parsing in date range filter.

Fixed bug in recursive call parameter.

Sep 21 2018, 5:54 AM · Restricted Project

Sep 19 2018

erik accepted D345: INP-1748 - Follow location, when generating static version of Maintenance Page.
Sep 19 2018, 6:00 AM · Restricted Project
erik accepted D347: INP-1749 - Load all content blocks of a page with a single database query.
Sep 19 2018, 5:46 AM · Restricted Project
erik updated the test plan for D346: INP-1746 Correct time parsing in date range filter.
Sep 19 2018, 5:35 AM · Restricted Project
erik updated the diff for D346: INP-1746 Correct time parsing in date range filter.

Made filter out all records when incorrect date entered.

Sep 19 2018, 5:31 AM · Restricted Project

Sep 17 2018

erik updated the test plan for D346: INP-1746 Correct time parsing in date range filter.
Sep 17 2018, 1:44 PM · Restricted Project
erik created D346: INP-1746 Correct time parsing in date range filter.
Sep 17 2018, 1:41 PM · Restricted Project

May 16 2018

erik updated the diff for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.

Made "Modified By" username output in place of e-mail in the edit forms.

May 16 2018, 8:30 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 8:26 AM
erik updated the diff for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.

Changed "Modified" output on topic edit form.

May 16 2018, 7:13 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 7:10 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 7:08 AM
erik updated the test plan for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 16 2018, 7:08 AM

May 15 2018

erik updated the diff for D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
  1. Fixed phrase module.
  2. Fixed CS errors.
May 15 2018, 10:50 AM
erik created D344: INP-1745 Connect "Modified" and "ModifiedById" fields to Links.
May 15 2018, 10:43 AM

May 11 2018

erik accepted D343: INP-1744 Make page content blocks searcheable.
May 11 2018, 9:17 AM · Restricted Project

May 9 2018

erik updated the diff for D328: INP-1729 Use "preg_replace_callback" instead of "preg_replace" with "e" modifier.

Removed excessive code changes, not related to this task.

May 9 2018, 7:11 AM
erik updated the test plan for D328: INP-1729 Use "preg_replace_callback" instead of "preg_replace" with "e" modifier.
May 9 2018, 6:46 AM
erik updated the test plan for D328: INP-1729 Use "preg_replace_callback" instead of "preg_replace" with "e" modifier.
May 9 2018, 6:46 AM

May 8 2018

erik updated the diff for D328: INP-1729 Use "preg_replace_callback" instead of "preg_replace" with "e" modifier.

Removed e-modifier in second place. Applied advanced test plan.

May 8 2018, 7:11 AM

May 2 2018

erik requested changes to D337: INP-1738 - Apply CKEditor style changes in portable form.

Tested - this change does not affect CKEditor style dropdown in the other themes (default, simple). While testing, cms.css was changed to have width 300px. In the advanced theme dropdown become about square (300x300), and dropdowns in the other themes (default, simple) has no changes.

May 2 2018, 5:36 AM · Restricted Project

Apr 30 2018

erik added a comment to D337: INP-1738 - Apply CKEditor style changes in portable form.

Testing in progress, not finished. Cant normally upgrade from 5.1.c to 5.2.x. -

Patching to 5.2.2-B2 version:

Hunk #1 FAILED at 801.
1 out of 1 hunk FAILED -- saving rejects to file /tmp/skin_css_8ikYD3.rej

Apr 30 2018, 6:08 AM · Restricted Project
erik accepted D341: INP-1743 - Don't use "JOIN" in "ListSQLs" property of unit configs.
Apr 30 2018, 5:11 AM · Restricted Project

Apr 26 2018

erik accepted D342: INP-1742 Apply "ItemType" filter in JOIN to Search Results table.
Apr 26 2018, 10:56 AM · Restricted Project

Apr 25 2018

erik accepted D338: INP-1739 - Cache results of "\fckFCKHelper::getStyles" method.
Apr 25 2018, 6:08 AM

Apr 19 2018

erik accepted D339: INP-1740 - Make CKEditor URL preview respect "SEO URL Ending".
Apr 19 2018, 6:02 AM · Restricted Project
erik accepted D340: INP-1741 - Vertically align grid icons.
Apr 19 2018, 5:50 AM · Restricted Project

Apr 11 2018

erik accepted D336: INP-1737 - Fallback to category title on primary language in Admin Console.
Apr 11 2018, 5:12 AM