Page MenuHomeIn-Portal Phabricator
Differential D187

MINC-143 - Use table aliases in "ord" unit calculated fields
ClosedPublic
Actions

Authored by alex on Jan 18 2016, 6:45 AM.

Details

Reviewers
glebs
Commits
rMINC16364: Fixes MINC-143 - Use table aliases in "ord" unit calculated fields
Test Plan
  1. open orders_config.php file
  2. add LEFT JOIN '.TABLE_PREFIX.'Orders cloned_ord ON cloned_ord.OrderId = %1$s.OrderId to the end of each SQL in ListSQLs and ItemSQLs
  3. go to E-commerce → Orders section
  4. confirm, that no SQL error happens (before this fix there would be one)

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: Is fixed in 5.3.x.
SeverityLocationCodeMessage
Errormodules/in-commerce/units/orders/orders_config.php:265PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/orders/orders_config.php:265PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceBeforeCodingStandard.Formatting.ItemAssignment.MixedWhitespaceBefore
Errormodules/in-commerce/units/orders/orders_config.php:265PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errormodules/in-commerce/units/orders/orders_config.php:265PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/orders/orders_config.php:266PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/orders/orders_config.php:266PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceBeforeCodingStandard.Formatting.ItemAssignment.MixedWhitespaceBefore
Errormodules/in-commerce/units/orders/orders_config.php:266PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errormodules/in-commerce/units/orders/orders_config.php:266PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/orders/orders_config.php:267PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/orders/orders_config.php:267PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceBeforeCodingStandard.Formatting.ItemAssignment.MixedWhitespaceBefore
Errormodules/in-commerce/units/orders/orders_config.php:267PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errormodules/in-commerce/units/orders/orders_config.php:267PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/orders/orders_config.php:268PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/orders/orders_config.php:268PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceBeforeCodingStandard.Formatting.ItemAssignment.MixedWhitespaceBefore
Errormodules/in-commerce/units/orders/orders_config.php:268PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errormodules/in-commerce/units/orders/orders_config.php:268PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/orders/orders_config.php:269PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/orders/orders_config.php:269PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceBeforeCodingStandard.Formatting.ItemAssignment.MixedWhitespaceBefore
Errormodules/in-commerce/units/orders/orders_config.php:269PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errormodules/in-commerce/units/orders/orders_config.php:269PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/orders/orders_config.php:280PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Errormodules/in-commerce/units/orders/orders_config.php:280PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceBeforeCodingStandard.Formatting.ItemAssignment.MixedWhitespaceBefore
Errormodules/in-commerce/units/orders/orders_config.php:280PHPCS.E.CodingStandard.Formatting.SpaceOperator.SpacingBeforeCodingStandard.Formatting.SpaceOperator.SpacingBefore
Errormodules/in-commerce/units/orders/orders_config.php:280PHPCS.E.Squiz.WhiteSpace.OperatorSpacing.SpacingAfterSquiz.WhiteSpace.OperatorSpacing.SpacingAfter
Errormodules/in-commerce/units/orders/orders_config.php:281PHPCS.E.CodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfterCodingStandard.Formatting.ItemAssignment.MixedWhitespaceAfter
Unit
No Unit Test Coverage
Build Status
Buildable 299
Build 299: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 454.Jan 18 2016, 6:45 AM
alex retitled this revision from to MINC-143 - Use table aliases in "ord" unit calculated fields.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): MINC-143.
glebs accepted this revision.Feb 16 2016, 1:38 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2016, 1:38 AM
alex edited edge metadata.Mar 10 2016, 5:34 AM
alex added a project: Restricted Project.
Closed by commit rMINC16364: Fixes MINC-143 - Use table aliases in "ord" unit calculated fields (authored by alex). · Explain WhyJul 12 2016, 2:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 145416303Jan 18 2016, 6:45 AM
★
★
Diff 256516361rMINC16364Jul 12 2016, 2:54 AM
★
★

Diff 454

View Options

modules/in-commerce/units/orders/orders_config.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server