Page MenuHomeIn-Portal Phabricator
Differential D216

MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method
ClosedPublic
Actions

Authored by erik on Mar 29 2016, 4:45 AM.

Details

Reviewers
alex
Commits
rMINC16464: Fixes MINC-168 - Rename "OrderHelper::getCreditCartType" into "OrderHelper…
Test Plan

Part 1

  • in Admin Console
    1. go to E-commerce → Orders section
    2. click on Incomplete tab
    3. click on Add button on toolbar
    4. click on Billing tab
    5. on Billing tab fill only Credit Card Number field with 4716582257254288 value and press Save button
    6. confirm, that after page refresh Card Type field is automatically detected as Visa

Part 2

  • in IDE:
    1. change OrdersEventHandler::OnBeforeItemUpdate method to call $order_helper->getCreditCartType instead of $order_helper->getCreditCardType
  • in Admin Console
    1. set empty value for Card Type field on Billing tab
    2. press Save button on Billing tab
    3. confirm, that after page refresh Card Type field is automatically detected as Visa
    4. confirm, that after page refresh notice about deprecated method usage appeared in Debugger output

Diff Detail

Repository
rMINC Modules.In-Commerce
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erik updated this revision to Diff 510.Mar 29 2016, 4:45 AM
erik retitled this revision from to MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): MINC-168.
alex requested changes to this revision.Mar 29 2016, 5:58 AM
alex edited edge metadata.
alex added inline comments.
modules/in-commerce/units/helpers/order_helper.php
171–180 ↗(On Diff #510)

Please change DocBlock to look like this:

/**
 * Detects credit card type by it's number.
 *
 * @param string $number Credit card number.
 *
 * @return     integer
 * @deprecated
 */

Fixed indentation CS issue with nearby tags in DocBlock.

P.S.
I've fixed "arc" on your machine because it wasn't reporting this CS issue prior to differential revision submission.

183 ↗(On Diff #510)

Please add @ before trigger_error function call.

In task plan it's specifically said that notice should be silenced.

185 ↗(On Diff #510)

Please change E_USER_NOTICE to E_USER_DEPRECATED.

In task plan it's specifically said that deprecation notice should be triggered.

191–198 ↗(On Diff #510)

Please change DocBlock to look like this:

/**
 * Detects credit card type by it's number.
 *
 * @param string $number Credit card number.
 *
 * @return integer
 */

Fixed indentation CS issue with nearby tags in DocBlock.

This revision now requires changes to proceed.Mar 29 2016, 5:58 AM
erik updated this revision to Diff 511.Mar 30 2016, 4:48 AM
erik edited edge metadata.

Added silencing, changed doc blocks.

alex added inline comments.Mar 30 2016, 5:53 AM
modules/in-commerce/units/helpers/order_helper.php
181 ↗(On Diff #511)

I've updated coding standard to allow case, when silencing deprecation error. Updated standard however isn't yet available in this In-Portal version.

alex accepted this revision.Nov 19 2016, 8:25 AM
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex edited edge metadata.
alex edited edge metadata.
alex added inline comments.
modules/in-commerce/units/helpers/order_helper.php
181 ↗(On Diff #511)

https://github.com/aik099/CodingStandard/commit/c7ef78c8ad44b8d00275b223a94d7781a1eeb808

This revision is now accepted and ready to land.Nov 19 2016, 8:26 AM
Closed by commit rMINC16464: Fixes MINC-168 - Rename "OrderHelper::getCreditCartType" into "OrderHelper… (authored by alex). · Explain WhyNov 24 2016, 2:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 151016334Mar 29 2016, 4:45 AM
★
★
Diff 251116337Added silencing, changed doc blocks.Mar 30 2016, 4:48 AM
★
★
Diff 363016462rMINC16464Nov 24 2016, 2:30 PM
★
★

Diff 630

View Options

branches/5.2.x/units/helpers/order_helper.php

Loading...
View Options

branches/5.2.x/units/orders/orders_event_handler.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server