Page MenuHomeIn-Portal Phabricator

MINC-179 - Remove order id/object after the end of checkout process

Authored by alex on Jul 20 2016, 4:39 AM.


Test Plan
  • in Admin Console
    • create new user
    • create new product
  • on the Front-End
    • perform checkout process
  • in Admin Console
    • confirm, that order was created with proper content

Diff Detail

rMINC Modules.In-Commerce
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 577.Jul 20 2016, 4:39 AM
alex retitled this revision from to MINC-179 - Remove order id/object after the end of checkout process.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): MINC-179.
erik accepted this revision.Aug 4 2016, 4:30 AM
erik edited edge metadata.

No problems found with changed code.

But, when created service product without entering price, and then on front-end pressing "By Now" button - got SQL error

SELECT pp.PriceId

FROM inp_ProductsPricing AS pp
LEFT JOIN inp_Products AS p ON p.ProductId = pp.ProductId
WHERE (pp.ProductId = 2) AND (pp.PriceId = )

Function: kDBConnection->GetOne in order_calculator.php on line 473
Function: OrderCalculator->getPriceBracketByQty in order_calculator.php on line 397
Function: OrderCalculator->getPlainProductPrice in order_calculator.php on line 257
Function: OrderCalculator->addProduct in order_manager.php on line 434
Function: OrderManager->addProduct in orders_event_handler.php on line 3152
Function: OrdersEventHandler->AddItemToOrder in orders_event_handler.php on line 996
Function: OrdersEventHandler->OnAddToCart in event_handler.php on line 114
Function: kEventHandler->processEvent in event_manager.php on line 262
Function: kEventManager->HandleEvent in application.php on line 2098
Function: kApplication->HandleEvent in request_manager.php on line 160
Function: kRequestManager->runEvent in request_manager.php on line 48
Function: kRequestManager->process in event_manager.php on line 470
Function: kEventManager->ProcessRequest in application.php on line 1051
Function: kApplication->Run in index.php on line 22

This revision is now accepted and ready to land.Aug 4 2016, 4:30 AM
alex added a comment.Aug 4 2016, 5:28 AM

Thanks for noticing. I'm aware of that problem. Turns out relevant discussion in Confluence was missing and I've created one:

This revision was automatically updated to reflect the committed changes.