Page MenuHomeIn-Portal Phabricator

MINC-177 - Don't send "ORDER.SHIP" email, when email address is missing
ClosedPublic

Authored by erik on Aug 5 2016, 5:21 AM.

Details

Summary

Added condition to send e-mail only when e-mail address is not empty

Test Plan

Main test

  1. Login to adm.console
  2. Create tangible product
  3. Create incomplete order with this product
  4. Do not fill shipping tab at all when input order data, press Save button after filling Billing tab
  5. Select created order in Incomplete grid an press Place Order button in the grid's toolbar
  6. Confirm, that naw order is moved to To Ship tab
  7. Press Ship button in the To Ship grid's toolbar
  8. Go to Logs & ReportsE-mail Log
  9. Confirm that no new e-mail created with ORDER.SHIP value in the Template Name column

Regression testing

  1. Repeat this test with filling e-mail and all required fields on shipping tab when creating incomplete order
  2. Confirm, that in this case new ORDER.SHIP e-mail appears in the Logs & ReportsE-mail Log

Diff Detail

Repository
rMINC Modules.In-Commerce
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erik updated this revision to Diff 589.Aug 5 2016, 5:21 AM
erik retitled this revision from to MINC-177 Don't send "ORDER.SHIP" email, when email address is missing.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): MINC-177.
alex accepted this revision.Jul 26 2022, 1:41 AM
This revision is now accepted and ready to land.Jul 26 2022, 1:41 AM
alex retitled this revision from MINC-177 Don't send "ORDER.SHIP" email, when email address is missing to MINC-177 - Don't send "ORDER.SHIP" email, when email address is missing.Aug 3 2022, 4:42 AM
This revision was automatically updated to reflect the committed changes.