Differential D249

INP-1585 - Take value of "style" parameter of "inp_edit_multioptions" block into account
ClosedPublic
Actions

Authored by alex on Oct 19 2016, 6:14 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16474: Fixes INP-1585 - Take value of "style" parameter of "inp_edit_multioptions"…

Test Plan

in IDE:
- open any editing template, that uses 'inp_edit_options' block
- pick any field on that template, that uses 'inp_edit_options' block
- change following for that field:
  - replace inp_edit_options with inp_edit_multioptions
in Admin Console
- go to template, that you're editing before
- confirm, that for picked field the inp_edit_multioptions block is used and it's style attribute (in HTML) is empty or missing
in IDE:
- add style="height: 200px;" as attribute to picked above field using inp_edit_multioptions block
in Admin Console
- go to template, that you're editing before
- confirm, that for picked field the inp_edit_multioptions block is used and it's style attribute matches the one specified in template

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 601.Oct 19 2016, 6:14 AM

alex retitled this revision from to INP-1585 - Take value of "style" parameter of "inp_edit_multioptions" block into account.

alex updated this object.

alex edited the test plan for this revision. (Show Details)

alex added 1 JIRA issue(s): INP-1585.

Herald added a reviewer: erik. · View Herald TranscriptOct 19 2016, 6:14 AM

alex edited edge metadata.Oct 19 2016, 6:14 AM

alex added a project: Restricted Project.

erik accepted this revision.Oct 21 2016, 4:17 AM

erik edited edge metadata.

This revision is now accepted and ready to land.Oct 21 2016, 4:17 AM

Closed by commit rINP16474: Fixes INP-1585 - Take value of "style" parameter of "inp_edit_multioptions"… (authored by alex). · Explain WhyNov 24 2016, 2:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 640

branches/5.2.x/core/admin_templates/incs/form_blocks.tpl

Loading...