Page MenuHomeIn-Portal Phabricator

INP-1688 - Support both "%s" and "{param_name}" in validation error messages
ClosedPublic

Authored by alex on Mar 21 2017, 6:29 AM.

Details

Test Plan
NOTE: Test both clean install & upgrade.

Part 1

  1. login to Admin Console
  2. go to Website & ContentStructure & Data section
  3. click on Sections tab in main frame
  4. open Directory category for editing
  5. change value in Created On to become invalid (e.g. replace one digit with a letter)
  6. clear value of Section Title field
  7. press Save button
  8. confirm, that validation error for Section Title field looks like Field is required
  9. confirm, that validation error for Created On field looks like Incorrect date format, please use (XXX) ex. (YYY), where XXX is field format and YYY is sample value in that format
  10. confirm, that no other notices/warnings other than validation ones are present in Debugger Report
  11. press Cancel to close popup/modal window

Part 2

  1. login to Admin Console
  2. go to Website & ContentLabels & Phrases section
  3. in translation of la_err_bad_date_format phrase replace {format} and {sample} with '%s`
  4. repeat test in Part 1

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex updated this revision to Diff 717.Mar 21 2017, 6:29 AM
alex retitled this revision from to INP-1688 - Support both "%s" and "{param_name}" in validation error messages.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1688.
alex updated this revision to Diff 718.Mar 21 2017, 6:31 AM
alex edited edge metadata.

Don't attempt to replace parameters in the error message, when none were given.

alex edited the test plan for this revision. (Show Details)Mar 21 2017, 6:34 AM
erik accepted this revision.Apr 4 2017, 5:45 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2017, 5:45 AM
This revision was automatically updated to reflect the committed changes.