Page MenuHomeIn-Portal Phabricator

INP-1742 Apply "ItemType" filter in JOIN to Search Results table
ClosedPublic

Authored by glebs on Apr 26 2018, 6:26 AM.

Details

Test Plan
NOTE: Test with enables In-Link module
  1. Create new category and new link with same word in titles in admin
  2. Search for this word and confirm both found
  3. In DB directly set category ResourseId equals to link's ResourseId
  4. Search by some word that exists only in category title
  5. Confirm there is no link in search results
  6. Search by some word that exists only in link title
  7. Confirm there is no category in search results

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

glebs created this revision.Apr 26 2018, 6:26 AM
alex added a project: Restricted Project.Apr 26 2018, 9:20 AM
alex added inline comments.
core/units/categories/categories_event_handler.php
383 ↗(On Diff #852)

How it is possible, that CS issues were reported on a line, that doesn't have them?

glebs edited the test plan for this revision. (Show Details)Apr 26 2018, 10:37 AM
glebs edited reviewers, added: erik; removed: alex.
erik accepted this revision.Apr 26 2018, 10:56 AM
This revision is now accepted and ready to land.Apr 26 2018, 10:56 AM
alex edited the test plan for this revision. (Show Details)Apr 26 2018, 11:10 AM
This revision was landed with ongoing or failed builds.Tue, Feb 9, 3:00 AM
This revision was automatically updated to reflect the committed changes.