Page MenuHomeIn-Portal Phabricator

INP-1784 - Adjust "grid_total_td" block to respect "format" parameter
ClosedPublic

Authored by alex on May 29 2020, 5:34 AM.

Details

Test Plan

Preparation

  1. open core/units/phrases/phrases_config.php file for editing
  2. add 'formatter' => 'kFormatter' field option to PhraseId field declaration
  3. add 'totals' => 'SUM' and 'format' => '%.2f' column options to PhraseId column declaration in all grids
  4. save changes
  5. open core/admin_templates/languages/phrase_list.tpl file for editing
  6. add totals_render_as="grid_total_row" parameter, when rendring a grid block
  7. save changes

Testing

  1. login to Admin Console
  2. go to Website & ContentLabels & Phrases section
  3. confirm, that "PhraseId" column values (including total value) has thousands separators and decimal part (the ".00")

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.May 29 2020, 5:34 AM
alex requested review of this revision.May 29 2020, 5:34 AM
alex added a project: Restricted Project.May 29 2020, 5:35 AM
erik accepted this revision.Aug 17 2020, 1:14 PM
This revision is now accepted and ready to land.Aug 17 2020, 1:14 PM
This revision was automatically updated to reflect the committed changes.