Differential D464

INP-1859 - Escape MySQL 8.3 keywords
ClosedPublic
Actions

Authored by alex on Jan 23 2024, 5:27 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16786: Fixes INP-1859 - Escape MySQL 8.3 keywords
rMINC16787: Bug INP-1859 - Escape MySQL 8.3 keywords

Test Plan

NOTE: You must use MySQL 8.x (or equivalent in other MySQL forks) to verify, that a fix is working

perform a clean install
confirm, that no SQL error, that blocks the installation process, happened
login to Admin Console
go to the Website & Content → Structure & Data → Products section
click on the Products tab
confirm, that no SQL error has happened
create a product
confirm, that no SQL error has happened

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alex created this revision.Jan 23 2024, 5:27 AM

Herald added a reviewer: erik. · View Herald TranscriptJan 23 2024, 5:27 AM

alex requested review of this revision.Jan 23 2024, 5:27 AM

Harbormaster completed remote builds in B1238: Diff 1194.Jan 23 2024, 5:27 AM

alex retitled this revision from MINC-201 - Escape MySQL 8.3 keywords to INP-1859 - Escape MySQL 8.3 keywords.Jan 23 2024, 7:28 AM

alex updated JIRA issue(s): added 1 INP-1859; removed 1 MINC-201.

Handle an SQL error during the Clean Install.

Harbormaster completed remote builds in B1239: Diff 1195.Jan 23 2024, 7:30 AM

alex edited the test plan for this revision. (Show Details)Jan 23 2024, 7:31 AM

Can't test with correct MySQL version, but visually code looks good and works good with current MySQL version.

This revision is now accepted and ready to land.Jan 24 2024, 5:01 AM

alex mentioned this in D466: INP-1854 - Create global switch for Web Request/Session Data logging into the System Log.Jan 24 2024, 6:21 AM

alex added a project: Restricted Project.Jan 24 2024, 10:54 AM

This revision was landed with ongoing or failed builds.Jun 17 2024, 9:53 AM

Closed by commit rINP16786: Fixes INP-1859 - Escape MySQL 8.3 keywords (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1194	16780		Jan 23 2024, 5:27 AM	★	★
Diff 2	1195	16780	Handle an SQL error during the Clean Install.	Jan 23 2024, 7:30 AM	★	★
Diff 3	1213	16785	rINP16786	Jun 17 2024, 9:53 AM	★	★

Diff 1213

branches/5.2.x/core/install/install_schema.sql

Loading...