Differential D481

INP-1873 - Support MySQL 8 database collations
AcceptedPublic
Actions

Authored by alex on Aug 5 2024, 7:38 AM.

Tags

Subscribers

None

Details

Reviewers

Test Plan

Part 1

delete the /system/config.php file
open the /core/install.php in the Web Browser
perform clean install
on the Database Configuration step:
1. select Database Collation that doesn't match your MySQL Server version
2. attempt to proceed to the next installation step
3. confirm, that a validation error appeared
4. select Database Collation that does match your MySQL Server version
5. attempt to proceed to the next installation step
6. confirm, that no validation error appeared and both DBCharset and DBCollation keys of the /system/config.php are non-empty

Part 2

open the /core/install.php in the Web Browser
select Update Database Configuration option and proceed to the next step
on the Update Database Configuration step:
1. select Database Collation that doesn't match your MySQL Server version
2. attempt to proceed to the next installation step
3. confirm, that a validation error appeared
4. select Database Collation that does match your MySQL Server version
5. attempt to proceed to the next installation step
6. confirm, that no validation error appeared and both DBCharset and DBCollation keys of the /system/config.php are non-empty

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

Lint Warnings

Excuse: Unrelated.

Severity	Location	Code	Message
Warning	core/install.php:548	PHPCS.W.Generic.Files.LineLength.TooLong	Generic.Files.LineLength.TooLong

Unit

No Unit Test Coverage

Build Status

Buildable 1278
Build 1278: arc lint + arc unit

Event Timeline

alex created this revision.Aug 5 2024, 7:38 AM

Herald added a reviewer: erik. · View Herald TranscriptAug 5 2024, 7:38 AM

alex requested review of this revision.Aug 5 2024, 7:38 AM

Harbormaster completed remote builds in B1278: Diff 1233.Aug 5 2024, 7:38 AM

alex added a project: Restricted Project.Aug 5 2024, 7:38 AM

erik accepted this revision.Aug 5 2024, 9:38 AM

This revision is now accepted and ready to land.Aug 5 2024, 9:38 AM

Revision Contents
Changeset List

Diff 1233

core/install.php

Loading...

core/install/step_templates/db_config.tpl

Loading...

core/install/step_templates/db_reconfig.tpl

Loading...