Page MenuHomeIn-Portal Phabricator

TADV-34 - Incorrect usage of "block_no_data" attribute
Needs ReviewPublic

Authored by erik on Sep 25 2014, 9:45 AM.

Details

Reviewers
alex
Test Plan

Simple test

  1. In the development environment, make search by keyword block_no_data in the advanced theme.
  2. Confirm, that in the each of found cases block_no_data tag parameter goes together with data_exists="1" tag parameter.

Preparations

  1. go to User ManagementUsers, create some user
  2. go to E-commerceAfiliates, create new affiliate with same user, entered in Username field
  3. go to User ManagementUsers, select same user in the grid and press Login As button in toolbar
  4. confirm that front-end page is opened

Affiliate payments (case of empty list)

  1. click on Affiliate link in the My Account sidebar section
  2. confirm that Affiliate Program page is opened
  3. click on Affiliate Payments link in the main page part
  4. confirm that page with No payments text is shown

Affiliate orders (case of empty list)

  1. click on Affiliate link in the My Account sidebar section
  2. confirm that Affiliate Program page is opened
  3. click on Affiliate Statistics link in the main page part
  4. confirm that Affiliate Statistics page is opened
  5. click on Details link in the Total orders row
  6. confirm that Orders Statistics page is opened, and No orders text is shown on this page

Affiliate visits (case of empty list)

  1. click on Affiliate link in the My Account sidebar section
  2. confirm that Affiliate Program page is opened
  3. click on Affiliate Statistics link in the main page part
  4. confirm that Affiliate Statistics page is opened
  5. click on Details link in the Total visitors row
  6. confirm that Visitor Statistics page is opened, and No visitors text is shown on this page

My downloads (case of empty list)

  1. click on My Downloads link in the My Account sidebar section
  2. confirm that My Downloads page is opened, and No products text is shown on this page

My orders (case of empty list)

  1. click on My Orders link in the My Account sidebar section
  2. confirm that My Orders page is opened, and No orders text is shown on this page

In-commerce category/section (not in-commerce home page, case of empty products list)

  1. go to adm.console
  2. create Services section as child of Products category
  3. go to front-ent, to the URL products/services.html of current project
  4. confirm that Services page is opened, and it contains No products text under Products subsection

Preparations to get all above lists have records

  1. go to ToolsQuery Database section
  2. run SQL like: "INSERT INTO inp_AffiliatePayments SET AffiliateId = 1" where "1" may be replaced with ID of affiliate, created in Preparations above
  3. run SQL like: "INSERT INTO inp_UserVisits SET PortalUserId = 2, AffiliateId = 1" where "1" may be replaced with ID of affiliate, created in Preparations above, "2" may be replaced with ID of user, created in Preparations above
  4. run SQL like: "INSERT INTO inp_Orders SET VisitId = 1, Status = 4" where "1" may be replaced with ID of inp_UserVisits record, created by SQL command above
  5. run SQL like: "INSERT INTO inp_Orders SET PortalUserId = 2, Status = 4" where "2" may be replaced with ID of user, created in Preparations above
  6. go to adm.console and create active product of type "Downloadable" under "Products -> Services" category
  7. run SQL like: "INSERT INTO inp_UserFileAccess SET ProductId = 1, PortalUserId = 2" where "1" may be replaced with ID of inp_Products record, created in adm.console above, "2" may be replaced with ID of user, created in Preparations above
  8. confirm that all above lists, that were empty, now have record(s).

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 467
Build 467: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 10.Sep 25 2014, 9:45 AM
erik retitled this revision from to Incorrect usage of "block_no_data" attribute.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik set the repository for this revision to rINP In-Portal.
erik added 1 JIRA issue(s): TADV-34.
alex edited edge metadata.Nov 23 2014, 3:09 AM

Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.

alex retitled this revision from Incorrect usage of "block_no_data" attribute to TADV-34 - Incorrect usage of "block_no_data" attribute.Dec 7 2014, 3:29 PM
alex edited edge metadata.
alex set the repository for this revision to rINP In-Portal.Dec 7 2014, 3:43 PM
alex requested changes to this revision.May 19 2015, 7:36 PM
alex edited edge metadata.
alex added inline comments.
themes/advanced/in-commerce/my_account/cancel_recurring.tpl
48

Add <inp2:m_include template="in-commerce/elements/orders.elm"/> above this line.

52–53

Remove.

themes/advanced/in-commerce/my_account/cancel_recurring_ok.tpl
48

Add <inp2:m_include template="in-commerce/elements/orders.elm"/> above this line.

52–53

Remove.

This revision now requires changes to proceed.May 19 2015, 7:36 PM
erik edited the test plan for this revision. (Show Details)Aug 26 2015, 4:19 AM
erik edited edge metadata.
erik updated this revision to Diff 264.Aug 26 2015, 4:23 AM
erik edited edge metadata.

Changed place of orders elements include.

alex requested changes to this revision.Sep 7 2016, 7:58 AM
alex edited edge metadata.

Please update test plan to test end user experience:

  • fact, that "No Orders" and similar message are shown when no data available on a given page
  • fact, that actual data is shown, when data is available on a given page
This revision now requires changes to proceed.Sep 7 2016, 7:58 AM
erik edited the test plan for this revision. (Show Details)Sep 8 2016, 4:57 AM
erik edited edge metadata.
erik updated this revision to Diff 597.Sep 9 2016, 5:15 AM
erik edited edge metadata.

Removed excessive block_no_data parameter from tags in cancel_recurring and cancel_recurring_ok templates.

erik edited the test plan for this revision. (Show Details)Sep 9 2016, 5:16 AM
erik edited edge metadata.
erik planned changes to this revision.Sep 9 2016, 5:27 AM

Needs changes in test plan

erik requested a review of this revision.Sep 13 2016, 4:09 AM
erik edited the test plan for this revision. (Show Details)