- Create several orders with different payment types: with CC and without
- Update element grid_billinglink_td and add some usage of tag UsingCreditCard
- Check any orders list for SQL queries - it should have only one select from payment types table
Details
Details
- Reviewers
alex - Commits
- rMINC16248: Fixes MINC-127 - Optimize "ord:UsingCreditCard" tag
Diff Detail
Diff Detail
- Repository
- rMINC Modules.In-Commerce
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
| modules/in-commerce/units/orders/orders_tag_processor.php | ||
|---|---|---|
| 523 ↗ | (On Diff #213) | It should be boolean, not bool. |
| 534 ↗ | (On Diff #213) | The INNER JOIN is equivalent to just JOIN. |
| 538–539 ↗ | (On Diff #213) | This should be done only when needed, not all the time. |
| 544 ↗ | (On Diff #213) | Please rename to $payment_type. |
| modules/in-commerce/units/orders/orders_tag_processor.php | ||
|---|---|---|
| 544–547 ↗ | (On Diff #214) | We can actually extract this to separate getPrimaryPaymentType that will have $primary_payment_type variable in it. |