Page MenuHomeIn-Portal Phabricator
Differential D9

INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username
ClosedPublic
Actions

Authored by erik on Sep 25 2014, 10:09 AM.

Details

Reviewers
alex
Commits
rINP16201: Fixes INP-1373 - Admins are receiving e-mails with empty quotes
Test Plan
  1. go to Configuration → Users → General section
  2. set Allow new user registration to Immediate
  3. go to front-end registration page and register user with minimal data (e-mail and password)
  4. go to Logs & Reports → E-mail Log section
  5. confirm that USER.ADD admin e-mail content have no empty quotes, but have registered user e-mail into quotes

Diff Detail

Repository
rINP In-Portal
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

erik updated this revision to Diff 14.Sep 25 2014, 10:09 AM
erik retitled this revision from to Admins are receiving e-mails with empty quotes.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik set the repository for this revision to rINP In-Portal.
erik added 1 JIRA issue(s): INP-1373.
alex requested changes to this revision.Sep 25 2014, 10:40 AM
alex edited edge metadata.
alex added inline comments.
core/install/upgrades.sql
2911 ↗(On Diff #14)

While patch was created the 5.2.1 version was already released, so this needs to be changed to 5.2.2-B1.

This revision now requires changes to proceed.Sep 25 2014, 10:40 AM
erik updated this revision to Diff 31.Oct 31 2014, 7:37 AM
erik edited edge metadata.
erik set the repository for this revision to rINP In-Portal.

Changed version in upgredes.sql

alex added a comment.Nov 23 2014, 3:12 AM

Adding comment to create corresponding "Issue Link" from JIRA Issue back to this Differential Revision.

alex retitled this revision from Admins are receiving e-mails with empty quotes to INP-1373 - Admins are receiving e-mails with empty quotes.Dec 7 2014, 3:30 PM
alex edited edge metadata.
alex set the repository for this revision to rINP In-Portal.Dec 7 2014, 3:41 PM
alex requested changes to this revision.May 19 2015, 8:30 PM
alex edited edge metadata.
alex added inline comments.
core/install/upgrades.sql
2986 ↗(On Diff #31)

Please rebase on the latest code, because patch can't be applied cleanly. Looking from the patch there is an SQL error.

This revision now requires changes to proceed.May 19 2015, 8:30 PM
erik edited the test plan for this revision. (Show Details)May 28 2015, 4:20 AM
erik edited edge metadata.
erik updated this revision to Diff 203.May 28 2015, 4:26 AM
erik edited edge metadata.

Rebased on the latest code

Closed by commit rINP16201: Fixes INP-1373 - Admins are receiving e-mails with empty quotes (authored by alex). · Explain WhyMay 30 2015, 5:13 AM
This revision was automatically updated to reflect the committed changes.
alex retitled this revision from INP-1373 - Admins are receiving e-mails with empty quotes to INP-1373 - Show user's e-mail in UI/emails when he/she doesn't have username.Mar 27 2016, 8:10 AM
alex edited edge metadata.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 114Sep 25 2014, 10:07 AM
★
★
Diff 231Oct 31 2014, 7:34 AM
★
★
Diff 320316200Rebased on the latest codeMay 28 2015, 4:26 AM
★
★
Diff 420516199Commit rINP16201May 30 2015, 5:13 AM
★
★

Diff 205

View Options

branches/5.2.x/core/admin_templates/user_selector.tpl

Loading...
View Options

branches/5.2.x/core/install/english.lang

Loading...
View Options

branches/5.2.x/core/install/upgrades.sql

Loading...
View Options

branches/5.2.x/core/units/users/users_tag_processor.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server