Differential D468

INP-1862 - Execute "lint" prior to deploy during the build
ClosedPublic
Actions

Authored by alex on May 30 2024, 7:16 AM.

Tags

Subscribers

None

Details

Reviewers

Commits

rINP16784: Fixes INP-1862 - Execute "lint" prior to deploy during the build

Test Plan

in the IDE:
- open modules/custom/units/sections/custom_eh.php file for editing
- add a syntax error in there, e.g. replace function OnOverrideClonedSubItems($event) with function OnOverride ClonedSubItems($event)
- save changes
in CLI:
- - run the phing -f tools/build/build_custom.xml db-dump command to create a dump
- for each of the build-*.sql files created in the system directory:
  - remove the mysqldump: [Warning] Using a password on the command line interface can be insecure. line (if found)
  - save changes
- run the phing -f tools/build/build_custom.xml verify command
- confirm, that build output clearly shows where the syntax error is made

Diff Detail

Repository

Branch

/in-portal/branches/5.2.x

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 1246
Build 1246: arc lint + arc unit

Event Timeline

alex created this revision.May 30 2024, 7:16 AM

Herald added a reviewer: erik. · View Herald TranscriptMay 30 2024, 7:16 AM

alex requested review of this revision.May 30 2024, 7:16 AM

Harbormaster completed remote builds in B1246: Diff 1202.May 30 2024, 7:16 AM

alex added a project: Restricted Project.May 30 2024, 7:17 AM

erik accepted this revision.May 30 2024, 10:35 AM

This revision is now accepted and ready to land.May 30 2024, 10:35 AM

Closed by commit rINP16784: Fixes INP-1862 - Execute "lint" prior to deploy during the build (authored by alex, committed by ). · Explain WhyJun 6 2024, 2:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1202

tools/build/targets/common.xml

Loading...

tools/build/targets/deploy.xml

Loading...