Page MenuHomeIn-Portal Phabricator

INP-1463 - Use "http_build_query" for file editing link building
ClosedPublic

Authored by alex on Aug 15 2015, 2:26 PM.

Details

Test Plan
  1. before applying the patch open debugger and copy link to any file (e.g application.php looks like phpstorm://open?file=/Volumes/web/d/in-portal.53x/core/kernel/application.php&line=305 for me)
  2. apply the patch
  3. copy link to same file again (e.g. application.php looks like phpstorm://open?file=%2FVolumes%2Fweb%2Fd%2Fin-portal.53x%2Fcore%2Fkernel%2Fapplication.php&line=305 for me)
  4. confirm that argument values in url are url-encoded

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.3.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 83
Build 83: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 253.Aug 15 2015, 2:26 PM
alex retitled this revision from to INP-1463 - Use "http_build_query" for file editing link building.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1463.
glebs accepted this revision.Aug 31 2015, 2:11 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Aug 31 2015, 2:11 AM
This revision was automatically updated to reflect the committed changes.