Page MenuHomeIn-Portal Phabricator

INP-1493 - Always expand calculated fields in WHERE filters
ClosedPublic

Authored by alex on Oct 3 2015, 6:26 AM.

Details

Test Plan

Part 1

  1. create DiscountItemsEventHandler::SetCustomQuery method
  2. add WHERE filter to the ItemName calculated field (e.g. $object->addFilter('test_filter', 'ItemName LIKE ' . $this->Conn->qstr('z'));)
  3. go to E-commerceDiscounts & Certificates section
  4. create a discount with 1 product
  5. confirm, that applied before filter works as expected

Part 2

  1. create DiscountItemsEventHandler::SetCustomQuery method
  2. add HAVING filter to the ItemName calculated field (e.g. $object->addFilter('test_filter', 'ItemName LIKE ' . $this->Conn->qstr('z'), kDBList::HAVING_FILTER);)
  3. go to E-commerceDiscounts & Certificates section
  4. create a discount with 1 product
  5. confirm, that applied before filter works as expected

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 200
Build 200: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 358.Oct 3 2015, 6:26 AM
alex retitled this revision from to INP-1493 - Always expand calculated fields in WHERE filters.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1493.
glebs accepted this revision.Oct 6 2015, 2:01 AM
glebs edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2015, 2:01 AM
This revision was automatically updated to reflect the committed changes.
alex edited edge metadata.Mar 10 2016, 6:04 AM
alex added a project: Restricted Project.