Page MenuHomeIn-Portal Phabricator
Differential D266

INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation
ClosedPublic
Actions

Authored by alex on Nov 26 2016, 10:19 AM.

Details

Reviewers
erik
Commits
rINP16525: Fixes INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation
Test Plan

Part 1

  • run all tests from D224

Part 2

  1. create test.tpl file with this content
<inp2:m_DefaultParam param_name="wow" wow="ok"/>
[<inp2:m_Param name="$param_name"/>]
[<inp2:m_Param name="param_name"/>]
  1. open URL matching that template in browser
  2. confirm, that in View Source of opened page contains:
[ok]
[wow]

Part 3

  1. create test.tpl file with this content
<inp2:m_DefaultParam param_name="wow" wow="ok"/>

<inp2:m_Capture to_var="wow">
	la-la
</inp2:m_Capture>

[<inp2:m_Param name="$param_name"/>]
[<inp2:m_Param name="param_name"/>]
  1. open URL matching that template in browser
  2. confirm, that in View Source of opened page contains:
[la-la]
[wow]

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint ErrorsExcuse: It's easier to write code for tag compilation this way.
SeverityLocationCodeMessage
Errorcore/kernel/nparser/ntags.php:417PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:418PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:418PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:419PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:419PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:420PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:421PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Errorcore/kernel/nparser/ntags.php:427PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:428PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Errorcore/kernel/nparser/ntags.php:441PHPCS.E.Squiz.Strings.DoubleQuoteUsage.ContainsVarSquiz.Strings.DoubleQuoteUsage.ContainsVar
Errorcore/kernel/nparser/ntags.php:444PHPCS.E.Squiz.Strings.DoubleQuoteUsage.NotRequiredSquiz.Strings.DoubleQuoteUsage.NotRequired
Unit
No Unit Test Coverage
Build Status
Buildable 608
Build 608: arc lint + arc unit

Event Timeline

alex updated this revision to Diff 652.Nov 26 2016, 10:19 AM
alex retitled this revision from to INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation.
alex updated this object.
alex edited the test plan for this revision. (Show Details)
alex added 1 JIRA issue(s): INP-1646.
alex edited the test plan for this revision. (Show Details)Nov 26 2016, 10:24 AM
alex edited edge metadata.
alex added a parent revision: D224: INP-1562 - Don't overwrite template parameter value in <inp2:m_Param/> tag.
erik accepted this revision.Nov 29 2016, 4:25 AM
erik edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 4:25 AM
Closed by commit rINP16525: Fixes INP-1646 - Handle dynamic parameter names during "m_Param" tag compilation (authored by alex). · Explain WhyJan 21 2017, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 165216466Nov 26 2016, 10:19 AM
★
★
Diff 268916519rINP16525Jan 21 2017, 10:24 AM
★
★

Diff 652

View Options

core/kernel/nparser/ntags.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server