Unexpected output: Affected paths: no mapping - resubmit patch.
⚙ D186 Remove excessive "dest_country" conversion in Shipping Quotes Engine
Page MenuHomeIn-Portal Phabricator
Differential D186

Remove excessive "dest_country" conversion in Shipping Quotes Engine
ClosedPublic
Actions

Authored by erik on Jan 14 2016, 5:05 AM.

Details

Reviewers
alex
Commits
rMINC16527: Fixes MINC-141 - Remove excessive "dest_country" conversion in Shipping…
Summary

Removed excessive conversion.

Test Plan
  • login to Admin Console
    1. go to Configuration → E-commerce → Shipping section
    2. create new Custom Shipping Type
      • on General tab set Shipping Type field set to handling
      • on Shipping Zones tab add zone covering all countries
    3. go to Website & Content → Structure & Data → Products section
    4. create a tangible product in Active status
    5. go to Configuration → E-commerce → General section
    6. ensure, that Require login before checkout checkbox is turned off
  • go to Front-End
    1. start checkout using advanced theme
    2. input valid address with "United States" as Country
    3. press "Update Address" button
    4. confirm, that some shipping options appeared below after page refresh
    5. make empty State field of shipping address
    6. press "Update Address" button
    7. confirm, that no shipping options appeared below after page refresh

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 281
Build 281: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 437.Jan 14 2016, 5:05 AM
erik retitled this revision from to MINC-141 Remove excessive dest_country conversion in shipping quotes engine.
erik updated this object.
erik edited the test plan for this revision. (Show Details)
erik added a reviewer: alex.
erik added 1 JIRA issue(s): MINC-141.
alex retitled this revision from MINC-141 Remove excessive dest_country conversion in shipping quotes engine to Remove excessive "dest_country" conversion in Shipping Quotes Engine.Jan 14 2016, 5:44 AM
alex requested changes to this revision.Jan 14 2016, 5:46 AM
alex edited edge metadata.

The test plan is incomplete. Test plan should be written for someone, who doesn't understand what they are testing.

In this particular case all preface (adding products, creating shipping types, etc.) should be described as well. You can copy/paste parts from test plans I've written for my revisions as well.

This revision now requires changes to proceed.Jan 14 2016, 5:46 AM
erik edited the test plan for this revision. (Show Details)Jan 18 2016, 4:03 AM
erik edited edge metadata.
erik edited the test plan for this revision. (Show Details)
alex added a comment.Jan 23 2016, 2:19 PM

@erik, please also send this revision for testing, because Phabricator-JIRA integration works one way only (action in Phabricator changes JIRA task, but action in JIRA task doesn't change Phabricator revision).

erik requested a review of this revision.Mar 10 2016, 5:26 AM
erik edited edge metadata.
alex edited edge metadata.Mar 10 2016, 5:34 AM
alex added a project: Restricted Project.
alex edited the test plan for this revision. (Show Details)Nov 19 2016, 8:32 AM
alex requested changes to this revision.Nov 19 2016, 8:39 AM
alex edited edge metadata.
alex added inline comments.
modules/in-commerce/units/shipping_quote_engines/shipping_quote_collector.php
20

Please replace CountryStatesHelper with kCountryStatesHelper.

Before the @var type comment was moved up it had correct class name in it.

This revision now requires changes to proceed.Nov 19 2016, 8:39 AM
erik updated this revision to Diff 653.Nov 29 2016, 4:55 AM
erik edited edge metadata.

Fixed class name in the @var type comment

alex accepted this revision.Nov 29 2016, 7:51 AM
alex edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 7:51 AM
Closed by commit rMINC16527: Fixes MINC-141 - Remove excessive "dest_country" conversion in Shipping… (authored by alex). · Explain WhyJan 21 2017, 10:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 143716303Jan 14 2016, 5:05 AM
★
★
Diff 265316502Fixed class name in the @var type commentNov 29 2016, 4:55 AM
★
★
Diff 369116522rMINC16527Jan 21 2017, 10:36 AM
★
★

Diff 437

View Options

modules/in-commerce/units/shipping_quote_engines/shipping_quote_collector.php

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server