Removed excessive conversion.
Details
Details
- login to Admin Console
- go to Configuration → E-commerce → Shipping section
- create new Custom Shipping Type
- on General tab set Shipping Type field set to handling
- on Shipping Zones tab add zone covering all countries
- go to Website & Content → Structure & Data → Products section
- create a tangible product in Active status
- go to Configuration → E-commerce → General section
- ensure, that Require login before checkout checkbox is turned off
- go to Front-End
- start checkout using advanced theme
- input valid address with "United States" as Country
- press "Update Address" button
- confirm, that some shipping options appeared below after page refresh
- make empty State field of shipping address
- press "Update Address" button
- confirm, that no shipping options appeared below after page refresh
Diff Detail
Diff Detail
- Repository
- rMINC Modules.In-Commerce
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
The test plan is incomplete. Test plan should be written for someone, who doesn't understand what they are testing.
In this particular case all preface (adding products, creating shipping types, etc.) should be described as well. You can copy/paste parts from test plans I've written for my revisions as well.
Comment Actions
@erik, please also send this revision for testing, because Phabricator-JIRA integration works one way only (action in Phabricator changes JIRA task, but action in JIRA task doesn't change Phabricator revision).
| modules/in-commerce/units/shipping_quote_engines/shipping_quote_collector.php | ||
|---|---|---|
| 20 ↗ | (On Diff #437) | Please replace CountryStatesHelper with kCountryStatesHelper. Before the @var type comment was moved up it had correct class name in it. |