Differential D231

INP-1560 Migrate "mysql" to "mysqli" database type during upgrade
ClosedPublic
Actions

Authored by erik on Jul 4 2016, 5:06 AM.

Details

Reviewers

alex

Commits

rINP16689: Fixes INP-1560 - Migrate "mysql" to "mysqli" database type during upgrade

Summary

Replaced "mysql" to "mysqli" on installation process

Test Plan

drop all tables in the 5.2.x database
copy all 5.2.1 project's database tables to the 5.2.x project's database
delete system/config.php file from the 5.2.x project
copy system/config.php file from 5.2.1 project to 5.2.x project
confirm, that copied file contain 'mysql' among values of configuration variables and do not contain 'mysqli' there
in the system/config.php file change value of $_CONFIG['Database']['DBName'] configuration variable from 5.2.1 project's database name to 5.2.x project's database name
in the system/config.php file change value of $_CONFIG['Misc']['WebsitePath'] configuration variable from 5.2.1 project's base path to 5.2.x project's base path
in the command-line run command chmod 777 system/config.php
in the browser open core/install.php of 5.2.x project
confirm that system/config.php file contains 'mysqli' in place of recent 'mysql' value

Diff Detail

Repository

rINP In-Portal

Branch

/in-portal/branches/5.2.x

Lint

Lint Errors

Excuse: Full file reformatting is not part of this task.

Severity	Location	Code	Message
Error	core/install.php:301	PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExact	Generic.WhiteSpace.ScopeIndent.IncorrectExact
Error	core/install.php:303	PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExact	Generic.WhiteSpace.ScopeIndent.IncorrectExact
Error	core/install.php:306	PHPCS.E.Generic.WhiteSpace.ScopeIndent.IncorrectExact	Generic.WhiteSpace.ScopeIndent.IncorrectExact

Unit

No Unit Test Coverage

Build Status

Buildable 612
Build 612: arc lint + arc unit

Event Timeline

erik updated this revision to Diff 543.Jul 4 2016, 5:06 AM

erik retitled this revision from to INP-1560 Migrate "mysql" to "mysqli" database type during upgrade.

erik updated this object.

erik edited the test plan for this revision. (Show Details)

erik added a reviewer: alex.

erik added 1 JIRA issue(s): INP-1560.

alex requested changes to this revision.Jul 4 2016, 5:45 AM

alex edited edge metadata.

alex added inline comments.

core/install.php
294–306	Thank you, but please revert these changes. Random CS fixes to unrelated code does more harm than good.
303	Please also check, that `DBType` is `mysql` currently. The config is changed (even to same value) on each installator visit.

This revision now requires changes to proceed.Jul 4 2016, 5:45 AM

Removed CS fixes, added condition for DBType update.

Please rebuild this patch for In-Portal 5.2.x.

This revision now requires changes to proceed.Nov 16 2016, 4:51 AM

erik edited the test plan for this revision. (Show Details)Dec 2 2016, 4:30 AM

erik edited edge metadata.

Rebuilt in In-Portal 5.2.x.

alex accepted this revision.Jun 11 2020, 4:59 AM

This revision is now accepted and ready to land.Jun 11 2020, 4:59 AM

This revision was landed with ongoing or failed builds.Mar 16 2021, 3:33 AM

Closed by commit rINP16689: Fixes INP-1560 - Migrate "mysql" to "mysqli" database type during upgrade (authored by alex, committed by ). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			core/install.php (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	543	16347		Jul 4 2016, 5:06 AM	★	★
Diff 2	544	16347	Removed CS fixes, added condition for DBType update.	Jul 5 2016, 4:30 AM	★	★
Diff 3	656	16502	Rebuilt in In-Portal 5.2.x.	Dec 2 2016, 4:43 AM	★	★
Diff 4	1005	16688	rINP16689	Mar 16 2021, 3:33 AM	★	★

Commit	Parents	Author	Summary	Date
#fake-hash			Ignore it :) (Show More…)

Diff 656

View Options

INP-1560 Migrate "mysql" to "mysqli" database type during upgradeClosedPublicActions