Unexpected output: Affected paths: relative - resubmit patch.
⚙ D289 INP-1683 - Actualize texts in Forgot Password Wizard
Page MenuHomeIn-Portal Phabricator
Differential D289

INP-1683 - Actualize texts in Forgot Password Wizard
Needs RevisionPublic
Actions

Authored by glebs on Mar 1 2017, 4:04 AM.

Details

Reviewers
alex
Test Plan
NOTE: Test with advanced theme
  1. Go to Admin area
  2. Go to User Management → Users and add frontend user test with working email
  3. Logout
  4. Go to frontend as
  5. Click on Forgot Password? link. Got through all steps and confirm you see changed phrases (underlined on screenshots)
stepnewold
1
2
3
4

Diff Detail

Repository
rINP In-Portal
Branch
/in-portal/branches/5.2.x
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 686
Build 686: arc lint + arc unit

Event Timeline

glebs updated this revision to Diff 707.Mar 1 2017, 4:04 AM
glebs retitled this revision from to INP-1681 Add "Forgot Password" functionality to Admin Console.
glebs updated this object.
glebs edited the test plan for this revision. (Show Details)
glebs added 1 JIRA issue(s): INP-1681.
glebs retitled this revision from INP-1681 Add "Forgot Password" functionality to Admin Console to INP-1683 Actualize texts in Forgot Password Wizard.Mar 1 2017, 4:11 AM
glebs edited edge metadata.
glebs updated JIRA issue(s): added 1 INP-1683; removed 1 INP-1681.
alex requested changes to this revision.EditedMar 1 2017, 6:28 AM
alex edited edge metadata.

Test plan is way off.

Whole task was about changing texts on forgot password wizard and therefore tests plan must include:

  • assertions of actual texts and their placement (including email text) during forgot password usage (you can attach screenshots with needed areas highlighted)
  • request to run tests on both clean and upgraded install
  • as regressive test describing how forgot password is expected to work (the tester have no idea if whole forgot password wizard isn't broken after these changes)

The test plan needs to be written not based on how it works now, but on how it should be working.

core/admin_templates/js/dropdown_mapper.js
13

How is this related?

This revision now requires changes to proceed.Mar 1 2017, 6:28 AM
alex edited edge metadata.Mar 2 2017, 8:57 AM
alex added a project: Restricted Project.
glebs updated this revision to Diff 713.Mar 10 2017, 3:03 AM
glebs edited edge metadata.

Remove changes from core/admin_templates/js/dropdown_mapper.js

glebs edited the test plan for this revision. (Show Details)Mar 28 2017, 2:34 AM
glebs edited edge metadata.
This revision now requires changes to proceed.Jul 17 2017, 4:29 AM
alex retitled this revision from INP-1683 Actualize texts in Forgot Password Wizard to INP-1683 - Actualize texts in Forgot Password Wizard.Aug 3 2022, 4:41 AM

Revision Contents
Changeset List

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 170716536Mar 1 2017, 4:03 AM
★
★
Diff 271316536Remove changes from core/admin_templates/js/dropdown_mapper.jsMar 10 2017, 3:03 AM
★
★

Diff 707

View Options

core/admin_templates/js/dropdown_mapper.js

Loading...
View Options

core/install/english.lang

Loading...
View Options

core/install/upgrades.sql

Loading...
View Options

themes/advanced/_install/english.lang

Loading...
View Options

themes/advanced/platform/login/forgot_password.tpl

Loading...
View Options

themes/advanced/platform/login/forgot_password_reset.tpl

Loading...
View Options

themes/advanced/platform/login/forgot_password_reset_confirm.tpl

Loading...
View Options

themes/advanced/platform/login/forgot_password_reset_notice.tpl

Loading...
In-Portal CMS · In-Portal Community Pages · In-Portal Issue Tracker · In-Portal Repository Browser · Quality Assurance · In-Portal CI Server